From 1718a02caada407af2eea39cc4ff0855961037bf Mon Sep 17 00:00:00 2001
From: Harsha Muralidhar <hmuralidhar@gitlab.com>
Date: Tue, 20 Sep 2022 07:50:37 +0000
Subject: [PATCH] De-quarantining false positives spec
---
.../ee/browser_ui/13_secure/security_reports_spec.rb | 12 ++++++------
1 file changed, 6 insertions(+), 6 deletions(-)
diff --git a/qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb b/qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb
index 79968bbca4aaf..5a61451ce2606 100644
--- a/qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb
+++ b/qa/qa/specs/features/ee/browser_ui/13_secure/security_reports_spec.rb
@@ -131,13 +131,13 @@ module QA
end
end
- it 'displays false positives for the vulnerabilities', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/350412',
- quarantine: {
- type: :flaky,
- issue: 'https://gitlab.com/gitlab-org/gitlab/-/issues/351183'
- } do
+ it 'displays false positives for the vulnerabilities', testcase: 'https://gitlab.com/gitlab-org/gitlab/-/quality/test_cases/350412' do
push_security_reports
Page::Project::Menu.perform(&:click_project)
+ Support::Waiter.wait_until(sleep_interval: 3) do
+ pipelines = project.pipelines
+ !pipelines.empty? && pipelines.last[:status] == "success"
+ end
Page::Project::Menu.perform(&:click_on_vulnerability_report)
EE::Page::Project::Secure::Show.perform do |security_dashboard|
@@ -147,7 +147,7 @@ module QA
end
EE::Page::Project::Secure::SecurityDashboard.perform do |security_dashboard|
- Support::Retrier.retry_on_exception(max_attempts: 2, reload_page: page, message: 'False positive vuln retry') do
+ Support::Retrier.retry_on_exception(max_attempts: 2, sleep_interval: 3, reload_page: page, message: 'False positive vuln retry') do
security_dashboard.click_vulnerability(description: sast_scan_fp_example_vuln)
end
end
--
GitLab