From 11e99e53faf76e96bf8840f098a2faffdebae1a5 Mon Sep 17 00:00:00 2001
From: Samantha Ming <sming@gitlab.com>
Date: Fri, 25 Feb 2022 06:26:29 -0800
Subject: [PATCH] Refactor metric constant name
Add action suffix so to match other constant name.
---
app/assets/javascripts/security_configuration/constants.js | 2 +-
.../vulnerabilities/components/vulnerability_training.vue | 4 ++--
.../frontend/vulnerabilities/vulnerability_training_spec.js | 4 ++--
3 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/app/assets/javascripts/security_configuration/constants.js b/app/assets/javascripts/security_configuration/constants.js
index 1afbdbfd348c..9de3197844ea 100644
--- a/app/assets/javascripts/security_configuration/constants.js
+++ b/app/assets/javascripts/security_configuration/constants.js
@@ -1,6 +1,6 @@
export const TRACK_TOGGLE_TRAINING_PROVIDER_ACTION = 'toggle_security_training_provider';
export const TRACK_TOGGLE_TRAINING_PROVIDER_LABEL = 'update_security_training_provider';
-export const TRACK_CLICK_TRAINING_LINK = 'click_security_training_link';
+export const TRACK_CLICK_TRAINING_LINK_ACTION = 'click_security_training_link';
export const TRACK_PROVIDER_LEARN_MORE_CLICK_ACTION = 'click_link';
export const TRACK_PROVIDER_LEARN_MORE_CLICK_LABEL = 'security_training_provider';
export const TRACK_TRAINING_LOADED_ACTION = 'security_training_link_loaded';
diff --git a/ee/app/assets/javascripts/vulnerabilities/components/vulnerability_training.vue b/ee/app/assets/javascripts/vulnerabilities/components/vulnerability_training.vue
index 2cd97e6f6861..d724d12692bb 100644
--- a/ee/app/assets/javascripts/vulnerabilities/components/vulnerability_training.vue
+++ b/ee/app/assets/javascripts/vulnerabilities/components/vulnerability_training.vue
@@ -7,7 +7,7 @@ import glFeatureFlagsMixin from '~/vue_shared/mixins/gl_feature_flags_mixin';
import axios from '~/lib/utils/axios_utils';
import Tracking from '~/tracking';
import {
- TRACK_CLICK_TRAINING_LINK,
+ TRACK_CLICK_TRAINING_LINK_ACTION,
TRACK_TRAINING_LOADED_ACTION,
} from '~/security_configuration/constants';
import { SUPPORTED_IDENTIFIER_TYPES } from '../constants';
@@ -127,7 +127,7 @@ export default {
}
},
clickTrainingLink() {
- this.triggerMetric(TRACK_CLICK_TRAINING_LINK);
+ this.triggerMetric(TRACK_CLICK_TRAINING_LINK_ACTION);
},
triggerMetric(action) {
const { name } = this.supportedIdentifier;
diff --git a/ee/spec/frontend/vulnerabilities/vulnerability_training_spec.js b/ee/spec/frontend/vulnerabilities/vulnerability_training_spec.js
index 0e146855e5d7..036c3772dcf3 100644
--- a/ee/spec/frontend/vulnerabilities/vulnerability_training_spec.js
+++ b/ee/spec/frontend/vulnerabilities/vulnerability_training_spec.js
@@ -15,7 +15,7 @@ import securityTrainingProvidersQuery from '~/security_configuration/graphql/sec
import { shallowMountExtended } from 'helpers/vue_test_utils_helper';
import { SUPPORTED_IDENTIFIER_TYPES } from 'ee/vulnerabilities/constants';
import {
- TRACK_CLICK_TRAINING_LINK,
+ TRACK_CLICK_TRAINING_LINK_ACTION,
TRACK_TRAINING_LOADED_ACTION,
} from '~/security_configuration/constants';
import createMockApollo from 'helpers/mock_apollo_helper';
@@ -236,7 +236,7 @@ describe('VulnerabilityTraining component', () => {
expect(trackingSpy).toHaveBeenCalledWith(
undefined,
- TRACK_CLICK_TRAINING_LINK,
+ TRACK_CLICK_TRAINING_LINK_ACTION,
expectedTrackingOptions,
);
});
--
GitLab