diff --git a/.rubocop_todo.yml b/.rubocop_todo.yml index 19115b7bedbacdf1eba8caaaa05775b74dac4828..582c66bdffdf8706eb7037be4df90061af082a8d 100644 --- a/.rubocop_todo.yml +++ b/.rubocop_todo.yml @@ -1286,8 +1286,5 @@ FactoryBot/InlineAssociation: - 'spec/factories/packages.rb' - 'spec/factories/packages/package_file.rb' - 'spec/factories/sent_notifications.rb' - - 'spec/factories/serverless/domain.rb' - - 'spec/factories/serverless/domain_cluster.rb' - - 'spec/factories/terraform/state.rb' - 'spec/factories/uploads.rb' - 'spec/factories/wiki_pages.rb' diff --git a/ee/spec/replicators/geo/terraform_state_version_replicator_spec.rb b/ee/spec/replicators/geo/terraform_state_version_replicator_spec.rb index 5a9b4a9802834e1aad0e37163897cf772b9b539f..3281deb739850238bda70c507e6a8fddf663be8f 100644 --- a/ee/spec/replicators/geo/terraform_state_version_replicator_spec.rb +++ b/ee/spec/replicators/geo/terraform_state_version_replicator_spec.rb @@ -3,7 +3,7 @@ require 'spec_helper' RSpec.describe Geo::TerraformStateVersionReplicator do - let(:model_record) { build(:terraform_state_version) } + let(:model_record) { build(:terraform_state_version, terraform_state: create(:terraform_state)) } it_behaves_like 'a blob replicator' end diff --git a/spec/factories/serverless/domain.rb b/spec/factories/serverless/domain.rb index 7a6a048fb34668bbe31f5382767d41f032934473..c09af068d19a8ec2a8290347e11e5b4e40c31737 100644 --- a/spec/factories/serverless/domain.rb +++ b/spec/factories/serverless/domain.rb @@ -3,8 +3,8 @@ FactoryBot.define do factory :serverless_domain, class: '::Serverless::Domain' do function_name { 'test-function' } - serverless_domain_cluster { create(:serverless_domain_cluster) } - environment { create(:environment) } + serverless_domain_cluster { association(:serverless_domain_cluster) } + environment { association(:environment) } skip_create end diff --git a/spec/factories/serverless/domain_cluster.rb b/spec/factories/serverless/domain_cluster.rb index 40e0ecad5ade3da2b365d78d5986e5cb19ca7bd8..e8ff6cf42b2acbd6eb32959fc84cc665fa52570d 100644 --- a/spec/factories/serverless/domain_cluster.rb +++ b/spec/factories/serverless/domain_cluster.rb @@ -2,9 +2,9 @@ FactoryBot.define do factory :serverless_domain_cluster, class: '::Serverless::DomainCluster' do - pages_domain { create(:pages_domain) } - knative { create(:clusters_applications_knative) } - creator { create(:user) } + pages_domain { association(:pages_domain) } + knative { association(:clusters_applications_knative) } + creator { association(:user) } certificate do File.read(Rails.root.join('spec/fixtures/', 'ssl_certificate.pem')) diff --git a/spec/factories/terraform/state.rb b/spec/factories/terraform/state.rb index d80c1315e28c0cff178e98267300531ced6c6f32..e5cea9e252e3f05ae06ce43000fa27a1a2a6176d 100644 --- a/spec/factories/terraform/state.rb +++ b/spec/factories/terraform/state.rb @@ -2,7 +2,7 @@ FactoryBot.define do factory :terraform_state, class: 'Terraform::State' do - project { create(:project) } + project { association(:project) } sequence(:name) { |n| "state-#{n}" } @@ -14,7 +14,7 @@ trait :locked do sequence(:lock_xid) { |n| "lock-#{n}" } locked_at { Time.current } - locked_by_user { create(:user) } + locked_by_user { association(:user) } end trait :with_version do