From 08759e4d74c0aa12487e7b90f1276ceb57f0ea93 Mon Sep 17 00:00:00 2001 From: Tomas Vik <tvik@gitlab.com> Date: Tue, 14 Feb 2023 10:43:44 +0000 Subject: [PATCH] docs: MR authors can't merge their MRs --- doc/development/code_review.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/development/code_review.md b/doc/development/code_review.md index 1b39b74a23b46..245fb2152cdea 100644 --- a/doc/development/code_review.md +++ b/doc/development/code_review.md @@ -539,8 +539,8 @@ Before taking the decision to merge: - If the MR contains both Quality and non-Quality-related changes, the MR should be merged by the relevant maintainer for user-facing changes (backend, frontend, or database) after the Quality related changes are approved by a Software Engineer in Test. At least one maintainer must approve an MR before it can be merged. MR authors and -people who add commits to an MR are not authorized to approve the merge request, -so they must seek a maintainer who has not contributed to the MR to approve the MR before it can be merged. +people who add commits to an MR are not authorized to approve or merge the MR and +must seek a maintainer who has not contributed to the MR to approve and merge it. This policy is in place to satisfy the CHG-04 control of the GitLab [Change Management Controls](https://about.gitlab.com/handbook/security/security-assurance/security-compliance/guidance/change-management.html). -- GitLab