From 079266ecafc29596de74fef0c877857045aa73fe Mon Sep 17 00:00:00 2001
From: ddieulivol <ddieulivol@gitlab.com>
Date: Mon, 20 Nov 2023 16:02:40 +0100
Subject: [PATCH] Wait 1min for runner to finish in review-apps
We noticed that the namespace could not be
deleted because the gitlab runner pod takes
too long to be deleted.
This commit ensures we kill the gitlab runner review-
apps container after 1min.
---
scripts/review_apps/base-config.yaml | 1 +
1 file changed, 1 insertion(+)
diff --git a/scripts/review_apps/base-config.yaml b/scripts/review_apps/base-config.yaml
index 721733f6f6817..0ba0648cf015c 100644
--- a/scripts/review_apps/base-config.yaml
+++ b/scripts/review_apps/base-config.yaml
@@ -161,6 +161,7 @@ gitlab-runner:
memory: 150Mi
nodeSelector:
preemptible: "true"
+ terminationGracePeriodSeconds: 60 # Wait for 1min before killing gitlab-runner
podAnnotations:
<<: *safe-to-evict
--
GitLab