From 03b02dab5dc938081736f9b3659fe092bc95c472 Mon Sep 17 00:00:00 2001
From: John McDonnell <jmcdonnell@gitlab.com>
Date: Thu, 17 Oct 2024 21:46:52 +0000
Subject: [PATCH] E2E: Always expand breadcrumbs prior to checking for text
In some situations the breadcrumbs may be condensed if the full path
cannot be rendered in a limited amount of space. Certain tests execute
checks against text in the breadcrumbs and so in these situations if
the part of the component that is expected is hidden the test would
fail. It should be safe to expand the breadcrumb prior to checking for
text, which should still result in the the check has_breadcrumb?(text)
returnign the same true/false value.
Fixes https://gitlab.com/gitlab-org/gitlab/-/issues/497758
---
qa/qa/page/component/breadcrumbs.rb | 6 ++++++
.../browser_ui/9_data_stores/group/transfer_project_spec.rb | 6 +-----
2 files changed, 7 insertions(+), 5 deletions(-)
diff --git a/qa/qa/page/component/breadcrumbs.rb b/qa/qa/page/component/breadcrumbs.rb
index 08faea0c7607f..e3c9f0c48d609 100644
--- a/qa/qa/page/component/breadcrumbs.rb
+++ b/qa/qa/page/component/breadcrumbs.rb
@@ -15,6 +15,12 @@ def self.included(base)
end
def has_breadcrumb?(text)
+ # In some situations the length of the breadcrumbs may lead to it being condensed. For these situations
+ # open the dropdown toggle which should allow us to see the all components of the breadcrumb.
+ if has_no_element?('breadcrumb-links', text: text, wait: 0)
+ within_element('breadcrumb-links') { click_element('base-dropdown-toggle') }
+ end
+
has_element?('breadcrumb-links', text: text)
end
end
diff --git a/qa/qa/specs/features/browser_ui/9_data_stores/group/transfer_project_spec.rb b/qa/qa/specs/features/browser_ui/9_data_stores/group/transfer_project_spec.rb
index 5b510b5aadf7e..284dd221251a6 100644
--- a/qa/qa/specs/features/browser_ui/9_data_stores/group/transfer_project_spec.rb
+++ b/qa/qa/specs/features/browser_ui/9_data_stores/group/transfer_project_spec.rb
@@ -31,11 +31,7 @@ module QA
Page::Project::Menu.perform(&:click_project)
Page::Project::Show.perform do |project|
- # TODO breadcrumb test should be updated.
- # I'm commenting it out for now. I will create a follow-up issue to fix this.
- # https://gitlab.com/gitlab-org/gitlab/-/issues/497758#note_2145018495
- # expect(project).to have_breadcrumb(target_group.path)
-
+ expect(project).to have_breadcrumb(target_group.path)
expect(project).to have_readme_content(readme_content)
end
end
--
GitLab