diff --git a/ee/spec/controllers/ee/groups_controller_spec.rb b/ee/spec/controllers/ee/groups_controller_spec.rb
index e2671b25ee80a53bcdec601649026cdf15ffe1ed..6509ae8e7316dcfb74162bc0f965b77ab735033f 100644
--- a/ee/spec/controllers/ee/groups_controller_spec.rb
+++ b/ee/spec/controllers/ee/groups_controller_spec.rb
@@ -12,10 +12,6 @@
let_it_be(:subgroup) { create(:group, :private, parent: group) }
let_it_be(:subgroup2) { create(:group, :private, parent: subgroup) }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
describe 'GET #show' do
let(:namespace) { group }
diff --git a/ee/spec/controllers/projects/issues_controller_spec.rb b/ee/spec/controllers/projects/issues_controller_spec.rb
index bd73969e64e63df3981cb43d745e4bd2651c4736..f695ca6c64774d6ae3890547e177c2956380f7c2 100644
--- a/ee/spec/controllers/projects/issues_controller_spec.rb
+++ b/ee/spec/controllers/projects/issues_controller_spec.rb
@@ -7,10 +7,6 @@
let(:project) { create(:project_empty_repo, :public, namespace: namespace) }
let(:user) { create(:user) }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
describe 'licensed features' do
let(:project) { create(:project, group: namespace) }
let(:user) { create(:user) }
diff --git a/ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb b/ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb
index b6a16656db9ae2aa91a4c6a7e0b4a8de11cc96d3..392a8908bc491e721170f8106e11bcd3d9aae17d 100644
--- a/ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb
+++ b/ee/spec/features/issues/filtered_search/filter_issues_by_iteration_spec.rb
@@ -19,10 +19,6 @@
let_it_be(:iteration_2_issue) { create(:issue, project: project, iteration: iteration_2) }
let_it_be(:no_iteration_issue) { create(:issue, project: project) }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
shared_examples 'filters by iteration' do
context 'when iterations are not available' do
before do
diff --git a/ee/spec/features/issues/filtered_search/filter_issues_by_multiple_assignees_spec.rb b/ee/spec/features/issues/filtered_search/filter_issues_by_multiple_assignees_spec.rb
index a7376c4e86a03a60bd6120a105a50ca2df6d4585..f93904d73999f5a5f7af607e5b20a05506c8b0a4 100644
--- a/ee/spec/features/issues/filtered_search/filter_issues_by_multiple_assignees_spec.rb
+++ b/ee/spec/features/issues/filtered_search/filter_issues_by_multiple_assignees_spec.rb
@@ -17,8 +17,6 @@
end
before do
- stub_feature_flags(vue_issues_list: true)
-
sign_in(user)
visit project_issues_path(project)
end
diff --git a/ee/spec/features/issues/filtered_search/filter_issues_epic_spec.rb b/ee/spec/features/issues/filtered_search/filter_issues_epic_spec.rb
index ad5362fd8dc532c0429cb01a116ca13262bae7f8..e95eb7c09fdda5f8fec69e9ba00ac9419ed63422 100644
--- a/ee/spec/features/issues/filtered_search/filter_issues_epic_spec.rb
+++ b/ee/spec/features/issues/filtered_search/filter_issues_epic_spec.rb
@@ -18,7 +18,6 @@
let_it_be(:epic_issue3) { create(:epic_issue, issue: issue3, epic: epic2) }
before do
- stub_feature_flags(vue_issues_list: true)
stub_licensed_features(epics: true)
group.add_maintainer(user)
diff --git a/ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb b/ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb
index bb2bdc3cc9dc5ece9dcf68c77906b6b623cfa854..35fc080329e30bc3cfb3072654422572de8fd06c 100644
--- a/ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb
+++ b/ee/spec/features/issues/filtered_search/filter_issues_weight_spec.rb
@@ -22,7 +22,6 @@ def expect_issues_list_count(open_count, closed_count = 0)
end
before do
- stub_feature_flags(vue_issues_list: true)
project.add_maintainer(user)
sign_in(user)
diff --git a/ee/spec/features/issues/user_sees_empty_state_spec.rb b/ee/spec/features/issues/user_sees_empty_state_spec.rb
index 37570a035de480d4afeecacaf52adc9a07340569..54de00b75dfb18dd17217f7ee6f3092535074b1f 100644
--- a/ee/spec/features/issues/user_sees_empty_state_spec.rb
+++ b/ee/spec/features/issues/user_sees_empty_state_spec.rb
@@ -6,10 +6,6 @@
let_it_be(:project) { create(:project, :public) }
let_it_be(:auditor) { create(:user, auditor: true) }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
shared_examples 'empty state' do |expect_button|
it "shows empty state #{expect_button ? 'with' : 'without'} \"New issue\" button" do
visit project_issues_path(project)
diff --git a/ee/spec/features/issues/user_views_issues_spec.rb b/ee/spec/features/issues/user_views_issues_spec.rb
index 264b077d4b01957b63b8810d70d06b3858c10c25..4c9262141657a5201b49315724cf63a915c25351 100644
--- a/ee/spec/features/issues/user_views_issues_spec.rb
+++ b/ee/spec/features/issues/user_views_issues_spec.rb
@@ -10,9 +10,7 @@
let_it_be(:issue3) { create(:issue, project: project, health_status: 'at_risk') }
before do
- stub_feature_flags(vue_issues_list: true)
stub_licensed_features(blocked_issues: true, issuable_health_status: true, issue_weights: true)
-
sign_in(user)
visit project_issues_path(project)
end
diff --git a/spec/controllers/groups_controller_spec.rb b/spec/controllers/groups_controller_spec.rb
index 4a74eff90dc0faf45d587a5e8b84f9cf356c4494..148e08ba8e6764e187fe14058dbd5506a80d875a 100644
--- a/spec/controllers/groups_controller_spec.rb
+++ b/spec/controllers/groups_controller_spec.rb
@@ -18,7 +18,6 @@
let_it_be(:guest) { group.add_guest(create(:user)).user }
before do
- stub_feature_flags(vue_issues_list: true)
enable_admin_mode!(admin_with_admin_mode)
end
diff --git a/spec/controllers/projects/issues_controller_spec.rb b/spec/controllers/projects/issues_controller_spec.rb
index 8a03c1e709bdad3a5c7dfe1ccac470c625a52e54..d06ecd086ca352c65f69aa4634ecb6f3002db913 100644
--- a/spec/controllers/projects/issues_controller_spec.rb
+++ b/spec/controllers/projects/issues_controller_spec.rb
@@ -12,10 +12,6 @@
let(:issue) { create(:issue, project: project) }
let(:spam_action_response_fields) { { 'stub_spam_action_response_fields' => true } }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
describe "GET #index" do
context 'external issue tracker' do
before do
diff --git a/spec/features/groups/empty_states_spec.rb b/spec/features/groups/empty_states_spec.rb
index 71f38401fa11c5e36eec7efc328b354cd480b952..f11e5c565455466add0b9369fa60fb2bef661306 100644
--- a/spec/features/groups/empty_states_spec.rb
+++ b/spec/features/groups/empty_states_spec.rb
@@ -7,8 +7,6 @@
let(:user) { create(:group_member, :developer, user: create(:user), group: group ).user }
before do
- stub_feature_flags(vue_issues_list: true)
-
sign_in(user)
end
diff --git a/spec/features/groups/issues_spec.rb b/spec/features/groups/issues_spec.rb
index ef3346b97634b14a96e1b5360827a41edddbd9b2..c86705832b1f1926f0fd393a29fd89a573082fe4 100644
--- a/spec/features/groups/issues_spec.rb
+++ b/spec/features/groups/issues_spec.rb
@@ -11,10 +11,6 @@
let(:project_with_issues_disabled) { create(:project, :issues_disabled, group: group) }
let(:path) { issues_group_path(group) }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
context 'with shared examples', :js do
let(:issuable) { create(:issue, project: project, title: "this is my created issuable")}
@@ -140,8 +136,6 @@
let!(:issue3) { create(:issue, project: project, title: 'Issue #3', relative_position: 3) }
before do
- stub_feature_flags(vue_issues_list: false)
-
sign_in(user_in_group)
end
@@ -164,45 +158,36 @@
end
it 'issues should be draggable and persist order' do
- visit issues_group_path(group, sort: 'relative_position')
-
- wait_for_requests
+ visit issues_group_path(group)
+ select_manual_sort
- drag_to(selector: '.manual-ordering',
- from_index: 0,
- to_index: 2)
+ drag_to(selector: '.manual-ordering', from_index: 0, to_index: 2)
- wait_for_requests
+ expect_issue_order
- check_issue_order
-
- visit issues_group_path(group, sort: 'relative_position')
+ visit issues_group_path(group)
- check_issue_order
+ expect_issue_order
end
it 'issues should not be draggable when user is not logged in' do
sign_out(user_in_group)
-
- visit issues_group_path(group, sort: 'relative_position')
-
wait_for_requests
+ visit issues_group_path(group)
+ select_manual_sort
- drag_to(selector: '.manual-ordering',
- from_index: 0,
- to_index: 2)
+ drag_to(selector: '.manual-ordering', from_index: 0, to_index: 2)
- wait_for_requests
+ expect(page).to have_text 'An error occurred while reordering issues.'
+ end
- # Issue order should remain the same
- page.within('.manual-ordering') do
- expect(find('.issue:nth-child(1) .title')).to have_content('Issue #1')
- expect(find('.issue:nth-child(2) .title')).to have_content('Issue #2')
- expect(find('.issue:nth-child(3) .title')).to have_content('Issue #3')
- end
+ def select_manual_sort
+ click_button 'Created date'
+ click_button 'Manual'
+ wait_for_requests
end
- def check_issue_order
+ def expect_issue_order
expect(page).to have_css('.issue:nth-child(1) .title', text: 'Issue #2')
expect(page).to have_css('.issue:nth-child(2) .title', text: 'Issue #3')
expect(page).to have_css('.issue:nth-child(3) .title', text: 'Issue #1')
diff --git a/spec/features/groups/user_sees_users_dropdowns_in_issuables_list_spec.rb b/spec/features/groups/user_sees_users_dropdowns_in_issuables_list_spec.rb
index 9fe110701871483bd3cf39cff902d634deade271..4e4c0e509b03e2559ddf97a4d9e45f1b77cc40e9 100644
--- a/spec/features/groups/user_sees_users_dropdowns_in_issuables_list_spec.rb
+++ b/spec/features/groups/user_sees_users_dropdowns_in_issuables_list_spec.rb
@@ -2,23 +2,50 @@
require 'spec_helper'
-RSpec.describe 'Groups > User sees users dropdowns in issuables list' do
- let(:entity) { create(:group) }
+RSpec.describe 'Groups > User sees users dropdowns in issuables list', :js do
+ include FilteredSearchHelpers
+
+ let(:group) { create(:group) }
let(:user_in_dropdown) { create(:user) }
let!(:user_not_in_dropdown) { create(:user) }
- let!(:project) { create(:project, group: entity) }
+ let!(:project) { create(:project, group: group) }
before do
- entity.add_developer(user_in_dropdown)
+ group.add_developer(user_in_dropdown)
+ sign_in(user_in_dropdown)
end
- it_behaves_like 'issuable user dropdown behaviors' do
- let(:issuable) { create(:issue, project: project) }
- let(:issuables_path) { issues_group_path(entity) }
+ describe 'issues' do
+ let!(:issuable) { create(:issue, project: project) }
+
+ %w[Author Assignee].each do |dropdown|
+ describe "#{dropdown} dropdown" do
+ it 'only includes members of the project/group' do
+ visit issues_group_path(group)
+
+ select_tokens dropdown, '=', submit: false
+
+ expect_suggestion(user_in_dropdown.name)
+ expect_no_suggestion(user_not_in_dropdown.name)
+ end
+ end
+ end
end
- it_behaves_like 'issuable user dropdown behaviors' do
- let(:issuable) { create(:merge_request, source_project: project) }
- let(:issuables_path) { merge_requests_group_path(entity) }
+ describe 'merge requests' do
+ let!(:issuable) { create(:merge_request, source_project: project) }
+
+ %w[author assignee].each do |dropdown|
+ describe "#{dropdown} dropdown" do
+ it 'only includes members of the project/group' do
+ visit merge_requests_group_path(group)
+
+ filtered_search.set("#{dropdown}:=")
+
+ expect(find("#js-dropdown-#{dropdown} .filter-dropdown")).to have_content(user_in_dropdown.name)
+ expect(find("#js-dropdown-#{dropdown} .filter-dropdown")).not_to have_content(user_not_in_dropdown.name)
+ end
+ end
+ end
end
end
diff --git a/spec/features/issuables/issuable_list_spec.rb b/spec/features/issuables/issuable_list_spec.rb
index 7edf5fdc5ffcda936e02024c0f7fa2c9b3db3390..0fa2d238b0a2dc8c94a67b7115d4e60f840ac749 100644
--- a/spec/features/issuables/issuable_list_spec.rb
+++ b/spec/features/issuables/issuable_list_spec.rb
@@ -9,8 +9,6 @@
issuable_types = [:issue, :merge_request]
before do
- stub_feature_flags(vue_issues_list: true)
-
project.add_user(user, :developer)
sign_in(user)
issuable_types.each { |type| create_issuables(type) }
diff --git a/spec/features/issue_rebalancing_spec.rb b/spec/features/issue_rebalancing_spec.rb
index 8a05aeec7ece8e826cb5a5ee6177cb95346b9362..686aa5eb1b6d30f5688e7395de2a1f017d98ea1f 100644
--- a/spec/features/issue_rebalancing_spec.rb
+++ b/spec/features/issue_rebalancing_spec.rb
@@ -15,10 +15,6 @@
group.add_developer(user)
end
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
context 'when issue rebalancing is in progress' do
before do
sign_in(user)
diff --git a/spec/features/issues/filtered_search/dropdown_assignee_spec.rb b/spec/features/issues/filtered_search/dropdown_assignee_spec.rb
index 18b70c9622a1c5346e6f5235e67d5aa2f83475bc..05eb656461ef43a2bca3e868a55c6578149bbb8b 100644
--- a/spec/features/issues/filtered_search/dropdown_assignee_spec.rb
+++ b/spec/features/issues/filtered_search/dropdown_assignee_spec.rb
@@ -9,10 +9,6 @@
let_it_be(:user) { create(:user) }
let_it_be(:issue) { create(:issue, project: project) }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
describe 'behavior' do
before do
project.add_maintainer(user)
diff --git a/spec/features/issues/filtered_search/dropdown_author_spec.rb b/spec/features/issues/filtered_search/dropdown_author_spec.rb
index 07e2bd3b7e477aa4a66c05d177183b04e4da0092..36a8f1f390290706cc1caff0a0df2064b0271d09 100644
--- a/spec/features/issues/filtered_search/dropdown_author_spec.rb
+++ b/spec/features/issues/filtered_search/dropdown_author_spec.rb
@@ -10,8 +10,6 @@
let_it_be(:issue) { create(:issue, project: project) }
before do
- stub_feature_flags(vue_issues_list: true)
-
project.add_maintainer(user)
sign_in(user)
diff --git a/spec/features/issues/filtered_search/dropdown_base_spec.rb b/spec/features/issues/filtered_search/dropdown_base_spec.rb
index 5fdab288b2d2c21e1278610a3b5e86d49818ec48..9e3e3d394cdca40a36f22b5ff3190b8448a595f9 100644
--- a/spec/features/issues/filtered_search/dropdown_base_spec.rb
+++ b/spec/features/issues/filtered_search/dropdown_base_spec.rb
@@ -10,8 +10,6 @@
let_it_be(:issue) { create(:issue, project: project) }
before do
- stub_feature_flags(vue_issues_list: true)
-
project.add_maintainer(user)
sign_in(user)
diff --git a/spec/features/issues/filtered_search/dropdown_emoji_spec.rb b/spec/features/issues/filtered_search/dropdown_emoji_spec.rb
index d6d59b89a8c0cc81858407a32017135f7265a814..78450a9c3f700f24017ca330513eeba222f00cff 100644
--- a/spec/features/issues/filtered_search/dropdown_emoji_spec.rb
+++ b/spec/features/issues/filtered_search/dropdown_emoji_spec.rb
@@ -11,8 +11,6 @@
let_it_be(:award_emoji_star) { create(:award_emoji, name: 'star', user: user, awardable: issue) }
before do
- stub_feature_flags(vue_issues_list: true)
-
project.add_maintainer(user)
create_list(:award_emoji, 2, user: user, name: 'thumbsup')
create_list(:award_emoji, 1, user: user, name: 'thumbsdown')
diff --git a/spec/features/issues/filtered_search/dropdown_hint_spec.rb b/spec/features/issues/filtered_search/dropdown_hint_spec.rb
index c64247b2b15a153181102be60597b37bd1c4a992..dcbab308efaccef9d7f872209dfc87de7e92eeae 100644
--- a/spec/features/issues/filtered_search/dropdown_hint_spec.rb
+++ b/spec/features/issues/filtered_search/dropdown_hint_spec.rb
@@ -10,8 +10,6 @@
let_it_be(:issue) { create(:issue, project: project) }
before do
- stub_feature_flags(vue_issues_list: true)
-
project.add_maintainer(user)
end
diff --git a/spec/features/issues/filtered_search/dropdown_label_spec.rb b/spec/features/issues/filtered_search/dropdown_label_spec.rb
index 67e3792a04cf178dc2567804a08febe3334de049..0ff56909ad115894af3928498758c7b4004e0a5a 100644
--- a/spec/features/issues/filtered_search/dropdown_label_spec.rb
+++ b/spec/features/issues/filtered_search/dropdown_label_spec.rb
@@ -11,8 +11,6 @@
let_it_be(:label) { create(:label, project: project, title: 'bug-label') }
before do
- stub_feature_flags(vue_issues_list: true)
-
project.add_maintainer(user)
sign_in(user)
diff --git a/spec/features/issues/filtered_search/dropdown_milestone_spec.rb b/spec/features/issues/filtered_search/dropdown_milestone_spec.rb
index 19a4c8853f118fe8f170bb52189bac999e81c06c..37d604106f180f1cf7492bd9a783589783dee521 100644
--- a/spec/features/issues/filtered_search/dropdown_milestone_spec.rb
+++ b/spec/features/issues/filtered_search/dropdown_milestone_spec.rb
@@ -12,8 +12,6 @@
let_it_be(:issue) { create(:issue, project: project) }
before do
- stub_feature_flags(vue_issues_list: true)
-
project.add_maintainer(user)
sign_in(user)
diff --git a/spec/features/issues/filtered_search/dropdown_release_spec.rb b/spec/features/issues/filtered_search/dropdown_release_spec.rb
index 50ac9068b26764a7635f0c45a9ac3e4fe05f4598..08e20563c8e00b4b8725007842d03491e830e036 100644
--- a/spec/features/issues/filtered_search/dropdown_release_spec.rb
+++ b/spec/features/issues/filtered_search/dropdown_release_spec.rb
@@ -12,8 +12,6 @@
let_it_be(:issue) { create(:issue, project: project) }
before do
- stub_feature_flags(vue_issues_list: true)
-
project.add_maintainer(user)
sign_in(user)
diff --git a/spec/features/issues/filtered_search/filter_issues_spec.rb b/spec/features/issues/filtered_search/filter_issues_spec.rb
index 13bce49e6d1e99b20d7f55bb1106213f943eabf1..8d96bbc38cb9dc1121ac312dfc4f1b6626f00b83 100644
--- a/spec/features/issues/filtered_search/filter_issues_spec.rb
+++ b/spec/features/issues/filtered_search/filter_issues_spec.rb
@@ -19,7 +19,6 @@ def expect_no_issues_list
end
before do
- stub_feature_flags(vue_issues_list: true)
project.add_maintainer(user)
create(:issue, project: project, author: user2, title: "Bug report 1")
diff --git a/spec/features/issues/filtered_search/recent_searches_spec.rb b/spec/features/issues/filtered_search/recent_searches_spec.rb
index bb5964258be0ab56ea3d5349d4b47e3eed865fb4..cb17349dd432fa2833400bed9dd06e25080a45b4 100644
--- a/spec/features/issues/filtered_search/recent_searches_spec.rb
+++ b/spec/features/issues/filtered_search/recent_searches_spec.rb
@@ -13,8 +13,6 @@
let(:project_1_local_storage_key) { "#{project_1.full_path}-issue-recent-searches" }
before do
- stub_feature_flags(vue_issues_list: true)
-
# Visit any fast-loading page so we can clear local storage without a DOM exception
visit '/404'
remove_recent_searches
diff --git a/spec/features/issues/filtered_search/search_bar_spec.rb b/spec/features/issues/filtered_search/search_bar_spec.rb
index 8639ec2a227198c9ec019f12ffab4b5a45f297a6..e075547e326c90b6c141943f76539bb5089c6eb8 100644
--- a/spec/features/issues/filtered_search/search_bar_spec.rb
+++ b/spec/features/issues/filtered_search/search_bar_spec.rb
@@ -10,7 +10,6 @@
let_it_be(:issue) { create(:issue, project: project) }
before do
- stub_feature_flags(vue_issues_list: true)
project.add_maintainer(user)
sign_in(user)
diff --git a/spec/features/issues/filtered_search/visual_tokens_spec.rb b/spec/features/issues/filtered_search/visual_tokens_spec.rb
index 9fb6a4cc2af5d543ce7054cbaf06b933ee255bbf..7a367723609b5e45c6921bbe1a2224d0216dfc4b 100644
--- a/spec/features/issues/filtered_search/visual_tokens_spec.rb
+++ b/spec/features/issues/filtered_search/visual_tokens_spec.rb
@@ -15,7 +15,6 @@
let_it_be(:issue) { create(:issue, project: project) }
before do
- stub_feature_flags(vue_issues_list: true)
project.add_user(user, :maintainer)
project.add_user(user_rock, :maintainer)
sign_in(user)
diff --git a/spec/features/issues/rss_spec.rb b/spec/features/issues/rss_spec.rb
index bdc5f282875d0e4fe840c56435f9729d96322715..e3faed81c732f6d7dd329ba1bc210680d2d0f790 100644
--- a/spec/features/issues/rss_spec.rb
+++ b/spec/features/issues/rss_spec.rb
@@ -13,10 +13,6 @@
group.add_developer(user)
end
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
context 'when signed in' do
let_it_be(:user) { create(:user) }
diff --git a/spec/features/issues/user_bulk_edits_issues_labels_spec.rb b/spec/features/issues/user_bulk_edits_issues_labels_spec.rb
index 27377f6e1fd9efb399ecd00ac357dc00c419180a..4837d13574cacda8eb5ab11b79625c9d50ff5a94 100644
--- a/spec/features/issues/user_bulk_edits_issues_labels_spec.rb
+++ b/spec/features/issues/user_bulk_edits_issues_labels_spec.rb
@@ -15,10 +15,6 @@
let(:issue_1_selector) { "#issuable_#{issue1.id}" }
let(:issue_2_selector) { "#issuable_#{issue2.id}" }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
context 'as an allowed user', :js do
before do
project.add_maintainer(user)
diff --git a/spec/features/issues/user_bulk_edits_issues_spec.rb b/spec/features/issues/user_bulk_edits_issues_spec.rb
index 625303f89e430d12750dc4b1021b8ed636a7e324..0533f1688e2cdbc4238824351a1e31dbbba5e6e9 100644
--- a/spec/features/issues/user_bulk_edits_issues_spec.rb
+++ b/spec/features/issues/user_bulk_edits_issues_spec.rb
@@ -107,10 +107,6 @@
describe 'select all issues' do
let!(:issue_2) { create(:issue, project: project) }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
it 'after selecting all issues, unchecking one issue only unselects that one issue' do
visit project_issues_path(project)
diff --git a/spec/features/issues/user_creates_issue_spec.rb b/spec/features/issues/user_creates_issue_spec.rb
index 3bba041dab7680e2c546aec589d9bc263aa1eb83..151d3c60fa2e0f4d495bd1f8bdd9ac6d6146131a 100644
--- a/spec/features/issues/user_creates_issue_spec.rb
+++ b/spec/features/issues/user_creates_issue_spec.rb
@@ -8,10 +8,6 @@
let_it_be(:project) { create(:project_empty_repo, :public) }
let_it_be(:user) { create(:user) }
- before do
- stub_feature_flags(vue_issues_list: true)
- end
-
context "when unauthenticated" do
before do
sign_out(:user)
diff --git a/spec/features/issues/user_filters_issues_spec.rb b/spec/features/issues/user_filters_issues_spec.rb
index 42c2b5d32c112726fe1f823fc43f3ee4191995c6..2941ea6ec36261c57f517c812e136ef169a5cce9 100644
--- a/spec/features/issues/user_filters_issues_spec.rb
+++ b/spec/features/issues/user_filters_issues_spec.rb
@@ -7,8 +7,6 @@
let_it_be(:project) { create(:project_empty_repo, :public) }
before do
- stub_feature_flags(vue_issues_list: true)
-
%w[foobar barbaz].each do |title|
create(:issue,
author: user,
diff --git a/spec/features/issues/user_sees_breadcrumb_links_spec.rb b/spec/features/issues/user_sees_breadcrumb_links_spec.rb
index 1577d7d5ce81201222ca3db27adcb1d5f6c93b96..4ec13533a8d106801d1d2fd6f8598aa1b76a9073 100644
--- a/spec/features/issues/user_sees_breadcrumb_links_spec.rb
+++ b/spec/features/issues/user_sees_breadcrumb_links_spec.rb
@@ -8,8 +8,6 @@
let(:user) { project.creator }
before do
- stub_feature_flags(vue_issues_list: true)
-
sign_in(user)
visit(new_project_issue_path(project))
end
diff --git a/spec/features/issues/user_sorts_issues_spec.rb b/spec/features/issues/user_sorts_issues_spec.rb
index 4af313576edf0c524a1bf0c7db5dcdc63608dc42..7add6c782f7cbdca5c14d7aa6801b31a50b38418 100644
--- a/spec/features/issues/user_sorts_issues_spec.rb
+++ b/spec/features/issues/user_sorts_issues_spec.rb
@@ -16,8 +16,6 @@
let_it_be(:later_due_milestone) { create(:milestone, project: project, due_date: '2013-12-12') }
before do
- stub_feature_flags(vue_issues_list: true)
-
create_list(:award_emoji, 2, :upvote, awardable: issue1)
create_list(:award_emoji, 2, :downvote, awardable: issue2)
create(:award_emoji, :downvote, awardable: issue1)
diff --git a/spec/features/labels_hierarchy_spec.rb b/spec/features/labels_hierarchy_spec.rb
index ea888d4b2541af77f5c0b9afcfca76a9b38d4926..2f22ac8b3953df798b167f2edd5e5dbcaec87ac5 100644
--- a/spec/features/labels_hierarchy_spec.rb
+++ b/spec/features/labels_hierarchy_spec.rb
@@ -17,8 +17,6 @@
let!(:project_label_1) { create(:label, project: project_1, title: 'Label_4') }
before do
- stub_feature_flags(vue_issues_list: true)
-
grandparent.add_owner(user)
sign_in(user)
diff --git a/spec/features/merge_requests/user_sorts_merge_requests_spec.rb b/spec/features/merge_requests/user_sorts_merge_requests_spec.rb
index 459145d3ef0735127eedea0452d0cc4d606358e8..4a124299c6104b4916fe555504f887c3563563e1 100644
--- a/spec/features/merge_requests/user_sorts_merge_requests_spec.rb
+++ b/spec/features/merge_requests/user_sorts_merge_requests_spec.rb
@@ -17,8 +17,6 @@
let_it_be(:project) { create(:project, :public, group: group) }
before do
- stub_feature_flags(vue_issues_list: true)
-
sign_in(user)
visit(project_merge_requests_path(project))
diff --git a/spec/features/user_sorts_things_spec.rb b/spec/features/user_sorts_things_spec.rb
index bcf3defe9c69360dbadc8413ae94ee99edc631ff..c6a1cfdc146130d16faaf1c6f0c784e09c737f7b 100644
--- a/spec/features/user_sorts_things_spec.rb
+++ b/spec/features/user_sorts_things_spec.rb
@@ -16,8 +16,6 @@
let_it_be(:merge_request) { create(:merge_request, target_project: project, source_project: project, author: current_user) }
before do
- stub_feature_flags(vue_issues_list: true)
-
project.add_developer(current_user)
sign_in(current_user)
end
diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
index e49e82f6ab6443f17ec71c3e7ceb2c8eef99d7b8..a8b5908c57e2c9d6fd5312b6492e11f88e8a2978 100644
--- a/spec/spec_helper.rb
+++ b/spec/spec_helper.rb
@@ -308,10 +308,6 @@
# See https://gitlab.com/gitlab-org/gitlab/-/issues/33867
stub_feature_flags(file_identifier_hash: false)
- # The following `vue_issues_list` stub can be removed
- # once the Vue issues page has feature parity with the current Haml page
- stub_feature_flags(vue_issues_list: false)
-
# Disable `main_branch_over_master` as we migrate
# from `master` to `main` accross our codebase.
# It's done in order to preserve the concistency in tests
diff --git a/spec/support/shared_examples/features/issuables_user_dropdown_behaviors_shared_examples.rb b/spec/support/shared_examples/features/issuables_user_dropdown_behaviors_shared_examples.rb
deleted file mode 100644
index 1848b4fffd919e876c803e4519208bd574151131..0000000000000000000000000000000000000000
--- a/spec/support/shared_examples/features/issuables_user_dropdown_behaviors_shared_examples.rb
+++ /dev/null
@@ -1,23 +0,0 @@
-# frozen_string_literal: true
-
-RSpec.shared_examples 'issuable user dropdown behaviors' do
- include FilteredSearchHelpers
-
- before do
- issuable # ensure we have at least one issuable
- sign_in(user_in_dropdown)
- end
-
- %w[author assignee].each do |dropdown|
- describe "#{dropdown} dropdown", :js do
- it 'only includes members of the project/group' do
- visit issuables_path
-
- filtered_search.set("#{dropdown}:=")
-
- expect(find("#js-dropdown-#{dropdown} .filter-dropdown")).to have_content(user_in_dropdown.name)
- expect(find("#js-dropdown-#{dropdown} .filter-dropdown")).not_to have_content(user_not_in_dropdown.name)
- end
- end
- end
-end