From fcabe6f0fd1330618775a15c06d671ae7b78e5dc Mon Sep 17 00:00:00 2001
From: Pranav K <prkrishn@hotmail.com>
Date: Mon, 3 Aug 2020 15:43:34 -0700
Subject: [PATCH] Turn off full GC (#24545)
Using the full gc sometimes leads to an infinite recursion resulting
in a browser freeze. This was noted as part of running Blazor's benchmarks.
This is being addressed in rc1, in the meanwhile this reverts the behavior to 3.2 defaults.
Browser freezes when using a Blazor WASM application.
Yes. Full GC on is new to WASM on .NET Core
Low. Off by default is the behavior we had in 3.2.
---
.../Web.JS/dist/Release/blazor.webassembly.js | Bin 65088 -> 65146 bytes
.../Web.JS/src/Platform/Mono/MonoPlatform.ts | 5 +++++
2 files changed, 5 insertions(+)
diff --git a/src/Components/Web.JS/dist/Release/blazor.webassembly.js b/src/Components/Web.JS/dist/Release/blazor.webassembly.js
index caaa8d8a97e69abecef59466f8f1107d50e1f39c..cd99a3089a22c368fc35f4e72cab4227fa267207 100644
GIT binary patch
delta 54
zcmX@`hxykZ<_&+=si)>8Cgr5Y=jX+zq~<2(rNpNvE9vBw=H%!^E9I5uCZ!fB#cFC8
KY<{^e+#dj~L>Bn~
delta 14
WcmezMhxx!C<_&+=Z8lr);tv2skO)2i
diff --git a/src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts b/src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts
index 3b906b00a1f..d2abd2a70ed 100644
--- a/src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts
+++ b/src/Components/Web.JS/src/Platform/Mono/MonoPlatform.ts
@@ -363,6 +363,11 @@ function createEmscriptenModuleInstance(resourceLoader: WebAssemblyResourceLoade
resourceLoader.purgeUnusedCacheEntriesAsync(); // Don't await - it's fine to run in background
MONO.mono_wasm_setenv("MONO_URI_DOTNETRELATIVEORABSOLUTE", "true");
+
+ // Turn off full-gc to prevent browser freezing.
+ const mono_wasm_enable_on_demand_gc = cwrap('mono_wasm_enable_on_demand_gc', null, ['number']);
+ mono_wasm_enable_on_demand_gc(0);
+
const load_runtime = cwrap('mono_wasm_load_runtime', null, ['string', 'number']);
// -1 enables debugging with logging disabled. 0 disables debugging entirely.
load_runtime(appBinDirName, hasDebuggingEnabled() ? -1 : 0);
--
GitLab