From c4c6e25a0660ffbcae2d81c979495ec9533ccaff Mon Sep 17 00:00:00 2001 From: Doug Bunting <6431421+dougbu@users.noreply.github.com> Date: Wed, 17 Jun 2020 13:04:45 -0700 Subject: [PATCH] Add missing doc files and cleanup nits (#22931) * nit: Remove useless `$(HasReferenceAssembly)` settings - set in /Directory.Build.targets - `true` only in `$(IsAspNetCoreApp)` projects * nit: Remove useless `$(CompileUsingReferenceAssemblies)` settings - no current versioning differences between ref/ and src/ assemblies when targeting default TFM * Add more `$(GenerateDocumentationFile)` settings - increases the number of generated doc files, mostly without problems - !fixup! correct typo in `DebugProxyHost` doc comments - was not generating a doc file before - remove previous (ineffective) src/Components/Directory.Build.targets setting - nit: remove a duplicate `$(GenerateDocumentationFile)` setting * nit: Remove useless `$(IsPackable)` settings - only analyzers and implementation projects are packable by default - main use case for explicit setting is projects shipping only in shared framework - conditional setting in src/Mvc/Directory.Build.props just subset logic in /Directory.Build.targets * nit: Remove useless `$(IsProjectReferenceProvider)` settings - only implementation projects are providers by default * nit: Remove useless `$(IsTestAssetProject)` settings - set in src/Mvc/test/WebSites/Directory.Build.props * !fixup! Looks like `InProcessNewShimWebSite` must compile w/o ref/ assemblies - restore `$(CompileUsingReferenceAssemblies)` in this one project --- eng/tools/Directory.Build.props | 1 - .../Analyzers/src/Microsoft.AspNetCore.Analyzers.csproj | 1 - .../src/Internal.AspNetCore.Analyzers.csproj | 1 - .../src/Microsoft.AspNetCore.Analyzer.Testing.csproj | 1 - .../Microsoft.AspNetCore.Authentication.AzureAD.UI.csproj | 1 - .../Microsoft.AspNetCore.Authentication.AzureADB2C.UI.csproj | 1 - ...crosoft.AspNetCore.AzureAppServices.HostingStartup.csproj | 1 - .../Microsoft.AspNetCore.AzureAppServicesIntegration.csproj | 1 - .../src/Microsoft.AspNetCore.Components.Analyzers.csproj | 2 -- src/Components/Directory.Build.targets | 4 ---- src/Components/Ignitor/src/Ignitor.csproj | 5 +---- src/Components/Ignitor/test/Ignitor.Test.csproj | 2 -- .../Samples/BlazorServerApp/BlazorServerApp.csproj | 1 - .../Server/src/Microsoft.AspNetCore.Components.Server.csproj | 2 +- .../src/Microsoft.Authentication.WebAssembly.Msal.csproj | 1 + .../Microsoft.AspNetCore.Components.WebAssembly.Build.csproj | 2 +- ...soft.AspNetCore.Components.WebAssembly.Build.Tests.csproj | 2 -- ...ore.Components.WebAssembly.Build.BrotliCompression.csproj | 1 - .../WebAssembly/DebugProxy/src/Hosting/DebugProxyHost.cs | 2 +- ...osoft.AspNetCore.Components.WebAssembly.DebugProxy.csproj | 2 +- ...rosoft.AspNetCore.Components.WebAssembly.DevServer.csproj | 2 +- .../JSInterop/src/Microsoft.JSInterop.WebAssembly.csproj | 3 --- ...Microsoft.AspNetCore.Components.WebAssembly.Server.csproj | 1 - ...t.AspNetCore.Components.WebAssembly.Authentication.csproj | 1 - ...etCore.Components.WebAssembly.Authentication.Tests.csproj | 2 -- .../Microsoft.AspNetCore.Components.WebAssembly.Tests.csproj | 2 -- .../testassets/MonoSanityClient/MonoSanityClient.csproj | 1 - .../Wasm.Authentication.Client.csproj | 2 -- .../Wasm.Authentication.Server.csproj | 1 - .../Wasm.Performance/Driver/Wasm.Performance.Driver.csproj | 5 ----- .../Wasm.Performance/TestApp/Wasm.Performance.TestApp.csproj | 3 --- .../E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj | 3 --- .../test/testassets/TestServer/Components.TestServer.csproj | 1 - .../src/Microsoft.Extensions.Configuration.KeyPerFile.csproj | 1 - ...soft.AspNetCore.DataProtection.EntityFrameworkCore.csproj | 3 +-- ...AspNetCore.DataProtection.EntityFrameworkCore.Test.csproj | 2 -- ...osoft.AspNetCore.DataProtection.StackExchangeRedis.csproj | 3 +-- ...AspNetCore.DataProtection.StackExchangeRedis.Tests.csproj | 2 -- .../EntityFrameworkCoreSample.csproj | 2 -- src/DataProtection/samples/Redis/Redis.csproj | 2 -- .../JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj | 1 - .../src/Microsoft.Extensions.FileProviders.Embedded.csproj | 1 - .../App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj | 2 -- ...t.Extensions.Diagnostics.HealthChecks.Abstractions.csproj | 1 - .../src/Microsoft.Extensions.Diagnostics.HealthChecks.csproj | 1 - .../TestHost/src/Microsoft.AspNetCore.TestHost.csproj | 1 - .../src/Microsoft.AspNetCore.Hosting.WindowsServices.csproj | 1 - .../Http/perf/Microsoft.AspNetCore.Http.Performance.csproj | 1 - src/Http/Owin/src/Microsoft.AspNetCore.Owin.csproj | 1 - .../perf/Microsoft.AspNetCore.Routing.Performance.csproj | 1 - .../Microsoft.AspNetCore.WebUtilities.Performance.csproj | 1 - .../samples/ApiAuthSample/ApiAuthSample.csproj | 2 -- ...crosoft.AspNetCore.ApiAuthorization.IdentityServer.csproj | 3 --- .../Microsoft.AspNetCore.Identity.EntityFrameworkCore.csproj | 1 - ...NetCore.Identity.EntityFrameworkCore.InMemory.Test.csproj | 2 -- ...osoft.AspNetCore.Identity.EntityFrameworkCore.Test.csproj | 2 -- .../Microsoft.AspNetCore.Identity.Specification.Tests.csproj | 1 - src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj | 1 - .../IdentitySample.DefaultUI/IdentitySample.DefaultUI.csproj | 2 -- .../samples/IdentitySample.Mvc/IdentitySample.Mvc.csproj | 2 -- .../Microsoft.AspNetCore.Identity.FunctionalTests.csproj | 2 -- .../Identity.DefaultUI.WebSite.csproj | 2 -- .../Microsoft.JSInterop/src/Microsoft.JSInterop.csproj | 1 - .../Microsoft.Extensions.Localization.Abstractions.csproj | 1 - .../src/Microsoft.Extensions.Localization.csproj | 1 - .../src/Microsoft.Extensions.Logging.AzureAppServices.csproj | 1 - .../src/Microsoft.AspNetCore.ConcurrencyLimiter.csproj | 1 - ...crosoft.AspNetCore.Diagnostics.EntityFrameworkCore.csproj | 1 - .../Diagnostics.EFCore.FunctionalTests.csproj | 2 -- ...t.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.csproj | 2 -- .../DatabaseErrorPageSample/DatabaseErrorPageSample.csproj | 2 -- .../src/Microsoft.AspNetCore.HeaderPropagation.csproj | 1 - ...sions.Diagnostics.HealthChecks.EntityFrameworkCore.csproj | 1 - ...Diagnostics.HealthChecks.EntityFrameworkCore.Tests.csproj | 2 -- .../testassets/HealthChecksSample/HealthChecksSample.csproj | 2 -- .../src/Microsoft.AspNetCore.MiddlewareAnalysis.csproj | 1 - .../samples/NodeServicesExamples/NodeServicesExamples.csproj | 1 - .../src/Microsoft.AspNetCore.NodeServices.csproj | 1 - .../src/Microsoft.AspNetCore.SpaServices.Extensions.csproj | 1 - .../SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj | 1 - src/MusicStore/samples/MusicStore/MusicStore.csproj | 2 -- .../test/MusicStore.E2ETests/MusicStore.E2ETests.csproj | 1 - src/MusicStore/test/MusicStore.Test/MusicStore.Test.csproj | 2 -- src/Mvc/Directory.Build.props | 1 - .../WebSites/ApiExplorerWebSite/ApiExplorerWebSite.csproj | 1 - .../ApplicationModelWebSite/ApplicationModelWebSite.csproj | 1 - src/Mvc/test/WebSites/BasicWebSite/BasicWebSite.csproj | 1 - .../ControllersFromServicesClassLibrary.csproj | 1 - .../ControllersFromServicesWebSite.csproj | 1 - src/Mvc/test/WebSites/CorsWebSite/CorsWebSite.csproj | 1 - .../ErrorPageMiddlewareWebSite.csproj | 1 - src/Mvc/test/WebSites/FilesWebSite/FilesWebSite.csproj | 1 - .../test/WebSites/FormatterWebSite/FormatterWebSite.csproj | 1 - .../WebSites/GenericHostWebSite/GenericHostWebSite.csproj | 1 - .../HtmlGenerationWebSite/HtmlGenerationWebSite.csproj | 1 - .../RazorBuildWebSite.PrecompiledViews.csproj | 1 - .../RazorBuildWebSite.Views/RazorBuildWebSite.Views.csproj | 1 - .../test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj | 1 - .../RazorPagesClassLibrary/RazorPagesClassLibrary.csproj | 1 - .../test/WebSites/RazorPagesWebSite/RazorPagesWebSite.csproj | 1 - src/Mvc/test/WebSites/RazorWebSite/RazorWebSite.csproj | 1 - .../test/WebSites/RoutingWebSite/Mvc.RoutingWebSite.csproj | 1 - src/Mvc/test/WebSites/SecurityWebSite/SecurityWebSite.csproj | 1 - src/Mvc/test/WebSites/SimpleWebSite/SimpleWebSite.csproj | 1 - .../test/WebSites/TagHelpersWebSite/TagHelpersWebSite.csproj | 1 - .../test/WebSites/VersioningWebSite/VersioningWebSite.csproj | 1 - .../XmlFormattersWebSite/XmlFormattersWebSite.csproj | 1 - src/ObjectPool/src/Microsoft.Extensions.ObjectPool.csproj | 1 - src/ProjectTemplates/Directory.Build.props | 1 - .../Microsoft.DotNet.Web.Client.ItemTemplates.csproj | 1 - .../Microsoft.DotNet.Web.ItemTemplates.csproj | 1 - .../Microsoft.DotNet.Web.ProjectTemplates.csproj | 1 - .../Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj | 1 - .../Microsoft.AspNetCore.Razor.Performance.csproj | 1 - .../Microsoft.AspNetCore.Razor.Internal.Transport.csproj | 1 - .../Microsoft.AspNetCore.Authentication.Certificate.csproj | 1 - .../src/Microsoft.AspNetCore.Authentication.Facebook.csproj | 1 - .../src/Microsoft.AspNetCore.Authentication.Google.csproj | 1 - .../src/Microsoft.AspNetCore.Authentication.JwtBearer.csproj | 1 - ...crosoft.AspNetCore.Authentication.MicrosoftAccount.csproj | 1 - .../src/Microsoft.AspNetCore.Authentication.Negotiate.csproj | 1 - .../Microsoft.AspNetCore.Authentication.OpenIdConnect.csproj | 1 - .../src/Microsoft.AspNetCore.Authentication.Twitter.csproj | 1 - .../Microsoft.AspNetCore.Authentication.WsFederation.csproj | 1 - .../Microsoft.AspNetCore.Security.Performance.csproj | 1 - .../Identity.ExternalClaims/Identity.ExternalClaims.csproj | 2 -- .../Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj | 1 - .../IIS/benchmarks/IIS.Performance/IIS.Performance.csproj | 1 - ...Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj | 1 - ...icrosoft.AspNetCore.Server.Kestrel.Transport.Libuv.csproj | 1 - ...NetCore.Server.Kestrel.Transport.Experimental.Quic.csproj | 1 - .../Microsoft.AspNetCore.Server.Kestrel.Performance.csproj | 1 - .../Kestrel/samples/Http2SampleApp/Http2SampleApp.csproj | 1 - .../Kestrel/samples/Http3SampleApp/Http3SampleApp.csproj | 1 - .../Kestrel/samples/LargeResponseApp/LargeResponseApp.csproj | 1 - src/Servers/Kestrel/samples/PlaintextApp/PlaintextApp.csproj | 1 - .../Kestrel/samples/QuicSampleApp/QuicSampleApp.csproj | 1 - .../Kestrel/samples/QuicSampleClient/QuicSampleClient.csproj | 1 - .../Kestrel/samples/SampleApp/Kestrel.SampleApp.csproj | 1 - .../Kestrel/samples/SystemdTestApp/SystemdTestApp.csproj | 1 - .../test/testassets/ThrowingLibrary/ThrowingLibrary.csproj | 1 - .../src/Microsoft.AspNetCore.SignalR.Client.Core.csproj | 1 - .../Client/src/Microsoft.AspNetCore.SignalR.Client.csproj | 1 - ...icrosoft.AspNetCore.SignalR.Client.FunctionalTests.csproj | 2 -- .../Microsoft.AspNetCore.SignalR.Client.Tests.csproj | 2 -- .../src/Microsoft.AspNetCore.Http.Connections.Client.csproj | 1 - .../FunctionalTests/SignalR.Client.FunctionalTestApp.csproj | 2 -- .../signalr-protocol-msgpack.npmproj | 1 - src/SignalR/clients/ts/signalr/signalr.npmproj | 1 - .../test/Microsoft.AspNetCore.Http.Connections.Tests.csproj | 2 -- ...Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj | 1 - ...rosoft.AspNetCore.SignalR.Protocols.NewtonsoftJson.csproj | 1 - .../test/Microsoft.AspNetCore.SignalR.Common.Tests.csproj | 2 -- .../Microsoft.AspNetCore.SignalR.Tests.Utils.csproj | 2 -- .../Microsoft.AspNetCore.SignalR.Microbenchmarks.csproj | 2 -- src/SignalR/samples/ClientSample/ClientSample.csproj | 2 -- src/SignalR/samples/JwtClientSample/JwtClientSample.csproj | 2 -- src/SignalR/samples/SignalRSamples/SignalRSamples.csproj | 2 -- .../SignalR/test/Microsoft.AspNetCore.SignalR.Tests.csproj | 4 +--- .../Microsoft.AspNetCore.SignalR.Specification.Tests.csproj | 3 --- .../Microsoft.AspNetCore.SignalR.StackExchangeRedis.csproj | 1 - ...rosoft.AspNetCore.SignalR.StackExchangeRedis.Tests.csproj | 2 -- ...icrosoft.AspNetCore.AzureAppServices.SiteExtension.csproj | 4 ++-- .../src/Microsoft.Web.Xdt.Extensions.csproj | 1 - .../src/Microsoft.Extensions.ApiDescription.Client.csproj | 2 -- .../src/Microsoft.Extensions.ApiDescription.Server.csproj | 2 -- .../Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj | 3 +-- src/Tools/GetDocumentInsider/src/GetDocumentInsider.csproj | 1 - .../src/Microsoft.dotnet-openapi.csproj | 1 - src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj | 1 - src/Tools/dotnet-sql-cache/src/dotnet-sql-cache.csproj | 1 - src/WebEncoders/src/Microsoft.Extensions.WebEncoders.csproj | 1 - 172 files changed, 13 insertions(+), 236 deletions(-) diff --git a/eng/tools/Directory.Build.props b/eng/tools/Directory.Build.props index 771294cf659..255d95ac666 100644 --- a/eng/tools/Directory.Build.props +++ b/eng/tools/Directory.Build.props @@ -3,7 +3,6 @@ <PropertyGroup> <IsPackable>false</IsPackable> - <HasReferenceAssembly>false</HasReferenceAssembly> <DisablePackageReferenceRestrictions>true</DisablePackageReferenceRestrictions> </PropertyGroup> </Project> diff --git a/src/Analyzers/Analyzers/src/Microsoft.AspNetCore.Analyzers.csproj b/src/Analyzers/Analyzers/src/Microsoft.AspNetCore.Analyzers.csproj index feec3324be1..d0e52bc923b 100644 --- a/src/Analyzers/Analyzers/src/Microsoft.AspNetCore.Analyzers.csproj +++ b/src/Analyzers/Analyzers/src/Microsoft.AspNetCore.Analyzers.csproj @@ -9,7 +9,6 @@ We do need to pack it so it can be picked up by the Web SDK. --> <IsShippingPackage>false</IsShippingPackage> - <IsPackable>true</IsPackable> <TargetFramework>netstandard2.0</TargetFramework> <IncludeBuildOutput>false</IncludeBuildOutput> diff --git a/src/Analyzers/Internal.AspNetCore.Analyzers/src/Internal.AspNetCore.Analyzers.csproj b/src/Analyzers/Internal.AspNetCore.Analyzers/src/Internal.AspNetCore.Analyzers.csproj index 30c5ab44330..f4d42dc817b 100644 --- a/src/Analyzers/Internal.AspNetCore.Analyzers/src/Internal.AspNetCore.Analyzers.csproj +++ b/src/Analyzers/Internal.AspNetCore.Analyzers/src/Internal.AspNetCore.Analyzers.csproj @@ -14,7 +14,6 @@ <IsProjectReferenceProvider>false</IsProjectReferenceProvider> <UseLatestPackageReferences>true</UseLatestPackageReferences> <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking> - <IsPackable>true</IsPackable> <IsShippingPackage>false</IsShippingPackage> <!-- This project needs an older version of M.CA.CSharp.Workspaces since it targets netstandard1.3 --> <DisablePackageReferenceRestrictions>true</DisablePackageReferenceRestrictions> diff --git a/src/Analyzers/Microsoft.AspNetCore.Analyzer.Testing/src/Microsoft.AspNetCore.Analyzer.Testing.csproj b/src/Analyzers/Microsoft.AspNetCore.Analyzer.Testing/src/Microsoft.AspNetCore.Analyzer.Testing.csproj index ef5773c6daf..01e88ae148a 100644 --- a/src/Analyzers/Microsoft.AspNetCore.Analyzer.Testing/src/Microsoft.AspNetCore.Analyzer.Testing.csproj +++ b/src/Analyzers/Microsoft.AspNetCore.Analyzer.Testing/src/Microsoft.AspNetCore.Analyzer.Testing.csproj @@ -9,7 +9,6 @@ <IsUnitTestProject>false</IsUnitTestProject> <!-- This package is internal, so we don't generate a package baseline. Always build against the latest dependencies. --> <UseLatestPackageReferences>true</UseLatestPackageReferences> - <IsPackable>true</IsPackable> <IsShippingPackage>false</IsShippingPackage> </PropertyGroup> diff --git a/src/Azure/AzureAD/Authentication.AzureAD.UI/src/Microsoft.AspNetCore.Authentication.AzureAD.UI.csproj b/src/Azure/AzureAD/Authentication.AzureAD.UI/src/Microsoft.AspNetCore.Authentication.AzureAD.UI.csproj index a17773b58dc..86f2ac73d86 100644 --- a/src/Azure/AzureAD/Authentication.AzureAD.UI/src/Microsoft.AspNetCore.Authentication.AzureAD.UI.csproj +++ b/src/Azure/AzureAD/Authentication.AzureAD.UI/src/Microsoft.AspNetCore.Authentication.AzureAD.UI.csproj @@ -6,7 +6,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <PackageTags>aspnetcore;authentication;AzureAD</PackageTags> <GenerateDocumentationFile>true</GenerateDocumentationFile> - <IsPackable>true</IsPackable> <ProvideApplicationPartFactoryAttributeTypeName>Microsoft.AspNetCore.Mvc.ApplicationParts.NullApplicationPartFactory, Microsoft.AspNetCore.Mvc.Core</ProvideApplicationPartFactoryAttributeTypeName> <AddRazorSupportForMvc>true</AddRazorSupportForMvc> </PropertyGroup> diff --git a/src/Azure/AzureAD/Authentication.AzureADB2C.UI/src/Microsoft.AspNetCore.Authentication.AzureADB2C.UI.csproj b/src/Azure/AzureAD/Authentication.AzureADB2C.UI/src/Microsoft.AspNetCore.Authentication.AzureADB2C.UI.csproj index 77ec20937b7..e92ddfff11d 100644 --- a/src/Azure/AzureAD/Authentication.AzureADB2C.UI/src/Microsoft.AspNetCore.Authentication.AzureADB2C.UI.csproj +++ b/src/Azure/AzureAD/Authentication.AzureADB2C.UI/src/Microsoft.AspNetCore.Authentication.AzureADB2C.UI.csproj @@ -6,7 +6,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <PackageTags>aspnetcore;authentication;AzureADB2C</PackageTags> <GenerateDocumentationFile>true</GenerateDocumentationFile> - <IsPackable>true</IsPackable> <ProvideApplicationPartFactoryAttributeTypeName>Microsoft.AspNetCore.Mvc.ApplicationParts.NullApplicationPartFactory, Microsoft.AspNetCore.Mvc.Core</ProvideApplicationPartFactoryAttributeTypeName> <AddRazorSupportForMvc>true</AddRazorSupportForMvc> </PropertyGroup> diff --git a/src/Azure/AzureAppServices.HostingStartup/src/Microsoft.AspNetCore.AzureAppServices.HostingStartup.csproj b/src/Azure/AzureAppServices.HostingStartup/src/Microsoft.AspNetCore.AzureAppServices.HostingStartup.csproj index 5d4b07647f1..649833effac 100644 --- a/src/Azure/AzureAppServices.HostingStartup/src/Microsoft.AspNetCore.AzureAppServices.HostingStartup.csproj +++ b/src/Azure/AzureAppServices.HostingStartup/src/Microsoft.AspNetCore.AzureAppServices.HostingStartup.csproj @@ -7,7 +7,6 @@ <TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;azure;appservices</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Azure/AzureAppServicesIntegration/src/Microsoft.AspNetCore.AzureAppServicesIntegration.csproj b/src/Azure/AzureAppServicesIntegration/src/Microsoft.AspNetCore.AzureAppServicesIntegration.csproj index a9f4eae94d1..9a8b2827f9b 100644 --- a/src/Azure/AzureAppServicesIntegration/src/Microsoft.AspNetCore.AzureAppServicesIntegration.csproj +++ b/src/Azure/AzureAppServicesIntegration/src/Microsoft.AspNetCore.AzureAppServicesIntegration.csproj @@ -7,7 +7,6 @@ <AllowUnsafeBlocks>true</AllowUnsafeBlocks> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;azure;appservices</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Components/Analyzers/src/Microsoft.AspNetCore.Components.Analyzers.csproj b/src/Components/Analyzers/src/Microsoft.AspNetCore.Components.Analyzers.csproj index dab047ca116..4030f627675 100644 --- a/src/Components/Analyzers/src/Microsoft.AspNetCore.Components.Analyzers.csproj +++ b/src/Components/Analyzers/src/Microsoft.AspNetCore.Components.Analyzers.csproj @@ -6,8 +6,6 @@ <NoPackageAnalysis>true</NoPackageAnalysis> <GenerateDocumentationFile>false</GenerateDocumentationFile> <Description>Roslyn analyzers for ASP.NET Core Components.</Description> - <IsPackable>true</IsPackable> - <HasReferenceAssembly>false</HasReferenceAssembly> </PropertyGroup> <ItemGroup> diff --git a/src/Components/Directory.Build.targets b/src/Components/Directory.Build.targets index c72c9c4c35b..9a5acfd3e65 100644 --- a/src/Components/Directory.Build.targets +++ b/src/Components/Directory.Build.targets @@ -1,8 +1,4 @@ <Project> - <PropertyGroup Condition="'$(IsUnitTestProject)' != 'true'"> - <GenerateDocumentationFile Condition="'$(GenerateDocumentationFile)' == ''">true</GenerateDocumentationFile> - </PropertyGroup> - <ItemGroup> <!-- Add a project dependency without reference output assemblies to enforce build order --> <!-- Applying workaround for https://github.com/microsoft/msbuild/issues/2661 and https://github.com/dotnet/sdk/issues/952 --> diff --git a/src/Components/Ignitor/src/Ignitor.csproj b/src/Components/Ignitor/src/Ignitor.csproj index 140496e8265..1176fa2c6c3 100644 --- a/src/Components/Ignitor/src/Ignitor.csproj +++ b/src/Components/Ignitor/src/Ignitor.csproj @@ -3,12 +3,9 @@ <PropertyGroup> <!-- Intentionally targeting netcoreapp3.0 because we do not want to update the Benchmark client to use 3.1 --> <TargetFramework>netcoreapp3.0</TargetFramework> - <IsPackable>true</IsPackable> <IsShippingPackage>false</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> <DefineConstants>$(DefineConstants);IGNITOR</DefineConstants> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> + <GenerateDocumentationFile>true</GenerateDocumentationFile> </PropertyGroup> <ItemGroup> diff --git a/src/Components/Ignitor/test/Ignitor.Test.csproj b/src/Components/Ignitor/test/Ignitor.Test.csproj index 32e40b083f9..99ec3b143b0 100644 --- a/src/Components/Ignitor/test/Ignitor.Test.csproj +++ b/src/Components/Ignitor/test/Ignitor.Test.csproj @@ -3,8 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <DefineConstants>$(DefineConstants);IGNITOR</DefineConstants> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Components/Samples/BlazorServerApp/BlazorServerApp.csproj b/src/Components/Samples/BlazorServerApp/BlazorServerApp.csproj index 101fe45c133..cf38df5d001 100644 --- a/src/Components/Samples/BlazorServerApp/BlazorServerApp.csproj +++ b/src/Components/Samples/BlazorServerApp/BlazorServerApp.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <HasReferenceAssembly>false</HasReferenceAssembly> <IsShippingPackage>false</IsShippingPackage> </PropertyGroup> diff --git a/src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj b/src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj index f176a30378e..169ef3fac69 100644 --- a/src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj +++ b/src/Components/Server/src/Microsoft.AspNetCore.Components.Server.csproj @@ -95,4 +95,4 @@ <EmbeddedResource Include="$(BlazorServerJSFile)" LogicalName="_framework/%(Filename)%(Extension)" /> <EmbeddedResource Include="$(BlazorServerJSFile).map" LogicalName="_framework/%(Filename)%(Extension)" Condition="Exists('$(BlazorServerJSFile).map')" /> </ItemGroup> -</Project> \ No newline at end of file +</Project> diff --git a/src/Components/WebAssembly/Authentication.Msal/src/Microsoft.Authentication.WebAssembly.Msal.csproj b/src/Components/WebAssembly/Authentication.Msal/src/Microsoft.Authentication.WebAssembly.Msal.csproj index 6bf468596a1..09b63f4ed39 100644 --- a/src/Components/WebAssembly/Authentication.Msal/src/Microsoft.Authentication.WebAssembly.Msal.csproj +++ b/src/Components/WebAssembly/Authentication.Msal/src/Microsoft.Authentication.WebAssembly.Msal.csproj @@ -6,6 +6,7 @@ <TargetFramework>netstandard2.1</TargetFramework> <Description>Authenticate your Blazor webassembly applications with Azure Active Directory and Azure Active Directory B2C</Description> <RazorLangVersion>3.0</RazorLangVersion> + <GenerateDocumentationFile>true</GenerateDocumentationFile> </PropertyGroup> <ItemGroup> diff --git a/src/Components/WebAssembly/Build/src/Microsoft.AspNetCore.Components.WebAssembly.Build.csproj b/src/Components/WebAssembly/Build/src/Microsoft.AspNetCore.Components.WebAssembly.Build.csproj index b70e10a0598..d15e4ca7616 100644 --- a/src/Components/WebAssembly/Build/src/Microsoft.AspNetCore.Components.WebAssembly.Build.csproj +++ b/src/Components/WebAssembly/Build/src/Microsoft.AspNetCore.Components.WebAssembly.Build.csproj @@ -6,8 +6,8 @@ <AssemblyName>Microsoft.AspNetCore.Components.WebAssembly.Build</AssemblyName> <Description>Build mechanism for ASP.NET Core Blazor WebAssembly applications.</Description> <IsShippingPackage>true</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> <GenerateDependencyFile>false</GenerateDependencyFile> + <GenerateDocumentationFile>true</GenerateDocumentationFile> </PropertyGroup> <!-- Pack settings --> diff --git a/src/Components/WebAssembly/Build/test/Microsoft.AspNetCore.Components.WebAssembly.Build.Tests.csproj b/src/Components/WebAssembly/Build/test/Microsoft.AspNetCore.Components.WebAssembly.Build.Tests.csproj index fd25c908f9c..e7b4c82883f 100644 --- a/src/Components/WebAssembly/Build/test/Microsoft.AspNetCore.Components.WebAssembly.Build.Tests.csproj +++ b/src/Components/WebAssembly/Build/test/Microsoft.AspNetCore.Components.WebAssembly.Build.Tests.csproj @@ -6,8 +6,6 @@ <!-- Exclude the TestFiles directory from default wildcards --> <DefaultItemExcludes>$(DefaultItemExcludes);TestFiles\**\*</DefaultItemExcludes> <BuildHelixPayload>false</BuildHelixPayload> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Components/WebAssembly/Compression/src/Microsoft.AspNetCore.Components.WebAssembly.Build.BrotliCompression.csproj b/src/Components/WebAssembly/Compression/src/Microsoft.AspNetCore.Components.WebAssembly.Build.BrotliCompression.csproj index 31f42257b57..7267b5ed545 100644 --- a/src/Components/WebAssembly/Compression/src/Microsoft.AspNetCore.Components.WebAssembly.Build.BrotliCompression.csproj +++ b/src/Components/WebAssembly/Compression/src/Microsoft.AspNetCore.Components.WebAssembly.Build.BrotliCompression.csproj @@ -5,7 +5,6 @@ <OutputType>Exe</OutputType> <AssemblyName>blazor-brotli</AssemblyName> <IsShippingPackage>false</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> </PropertyGroup> </Project> diff --git a/src/Components/WebAssembly/DebugProxy/src/Hosting/DebugProxyHost.cs b/src/Components/WebAssembly/DebugProxy/src/Hosting/DebugProxyHost.cs index 4dfa2f44a22..4edbddc2f54 100644 --- a/src/Components/WebAssembly/DebugProxy/src/Hosting/DebugProxyHost.cs +++ b/src/Components/WebAssembly/DebugProxy/src/Hosting/DebugProxyHost.cs @@ -21,7 +21,7 @@ namespace Microsoft.AspNetCore.Components.WebAssembly.DebugProxy.Hosting /// </summary> /// <param name="args">Command line arguments passed in</param> /// <param name="browserHost">Host where browser is listening for debug connections</param> - /// <returns><see cref="IHostBuilder"></returns> + /// <returns><see cref="IHostBuilder" /></returns> public static IHostBuilder CreateDefaultBuilder(string[] args, string browserHost) { var builder = new HostBuilder(); diff --git a/src/Components/WebAssembly/DebugProxy/src/Microsoft.AspNetCore.Components.WebAssembly.DebugProxy.csproj b/src/Components/WebAssembly/DebugProxy/src/Microsoft.AspNetCore.Components.WebAssembly.DebugProxy.csproj index cfb9f1ecb0a..4a727c739db 100644 --- a/src/Components/WebAssembly/DebugProxy/src/Microsoft.AspNetCore.Components.WebAssembly.DebugProxy.csproj +++ b/src/Components/WebAssembly/DebugProxy/src/Microsoft.AspNetCore.Components.WebAssembly.DebugProxy.csproj @@ -5,11 +5,11 @@ <OutputType>Exe</OutputType> <PackageId>Microsoft.AspNetCore.Components.WebAssembly.DebugProxy</PackageId> <IsShippingPackage>true</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> <Description>Debug proxy for use when building Blazor applications.</Description> <!-- Set this to false because assemblies should not reference this assembly directly, (except for tests, of course). --> <IsProjectReferenceProvider>false</IsProjectReferenceProvider> <NoWarn>$(NoWarn);CS0649</NoWarn> + <GenerateDocumentationFile>true</GenerateDocumentationFile> </PropertyGroup> <ItemGroup> diff --git a/src/Components/WebAssembly/DevServer/src/Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj b/src/Components/WebAssembly/DevServer/src/Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj index 8738565f906..2df6ac053f3 100644 --- a/src/Components/WebAssembly/DevServer/src/Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj +++ b/src/Components/WebAssembly/DevServer/src/Microsoft.AspNetCore.Components.WebAssembly.DevServer.csproj @@ -6,9 +6,9 @@ <AssemblyName>blazor-devserver</AssemblyName> <PackageId>Microsoft.AspNetCore.Components.WebAssembly.DevServer</PackageId> <IsShippingPackage>true</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> <StartupObject>Microsoft.AspNetCore.Components.WebAssembly.DevServer.Program</StartupObject> <Description>Development server for use when building Blazor applications.</Description> + <GenerateDocumentationFile>true</GenerateDocumentationFile> <!-- Set this to false because assemblies should not reference this assembly directly, (except for tests, of course). --> <IsProjectReferenceProvider>false</IsProjectReferenceProvider> </PropertyGroup> diff --git a/src/Components/WebAssembly/JSInterop/src/Microsoft.JSInterop.WebAssembly.csproj b/src/Components/WebAssembly/JSInterop/src/Microsoft.JSInterop.WebAssembly.csproj index 3c199bc49c5..02e31b41b5c 100644 --- a/src/Components/WebAssembly/JSInterop/src/Microsoft.JSInterop.WebAssembly.csproj +++ b/src/Components/WebAssembly/JSInterop/src/Microsoft.JSInterop.WebAssembly.csproj @@ -5,10 +5,7 @@ <Description>Abstractions and features for interop between .NET WebAssembly and JavaScript code.</Description> <PackageTags>wasm;javascript;interop</PackageTags> <GenerateDocumentationFile>true</GenerateDocumentationFile> - <IsPackable>true</IsPackable> <IsShippingPackage>true</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> - <GenerateDocumentationFile>true</GenerateDocumentationFile> </PropertyGroup> <ItemGroup> diff --git a/src/Components/WebAssembly/Server/src/Microsoft.AspNetCore.Components.WebAssembly.Server.csproj b/src/Components/WebAssembly/Server/src/Microsoft.AspNetCore.Components.WebAssembly.Server.csproj index 0432f421fe2..f7a3fef2ae2 100644 --- a/src/Components/WebAssembly/Server/src/Microsoft.AspNetCore.Components.WebAssembly.Server.csproj +++ b/src/Components/WebAssembly/Server/src/Microsoft.AspNetCore.Components.WebAssembly.Server.csproj @@ -4,7 +4,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <Description>Runtime server features for ASP.NET Core Blazor applications.</Description> <IsShippingPackage>true</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> <!-- We're deliberately bundling assemblies as content files. Suppress the warning. --> <NoWarn>$(NoWarn);NU5100</NoWarn> diff --git a/src/Components/WebAssembly/WebAssembly.Authentication/src/Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj b/src/Components/WebAssembly/WebAssembly.Authentication/src/Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj index bbd49f3293e..e95a6956851 100644 --- a/src/Components/WebAssembly/WebAssembly.Authentication/src/Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj +++ b/src/Components/WebAssembly/WebAssembly.Authentication/src/Microsoft.AspNetCore.Components.WebAssembly.Authentication.csproj @@ -6,7 +6,6 @@ <TargetFramework>netstandard2.1</TargetFramework> <Description>Build client-side authentication for single-page applications (SPAs).</Description> <IsShippingPackage>true</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> <RazorLangVersion>3.0</RazorLangVersion> <GenerateDocumentationFile>true</GenerateDocumentationFile> </PropertyGroup> diff --git a/src/Components/WebAssembly/WebAssembly.Authentication/test/Microsoft.AspNetCore.Components.WebAssembly.Authentication.Tests.csproj b/src/Components/WebAssembly/WebAssembly.Authentication/test/Microsoft.AspNetCore.Components.WebAssembly.Authentication.Tests.csproj index 684b468b328..0de52938c6d 100644 --- a/src/Components/WebAssembly/WebAssembly.Authentication/test/Microsoft.AspNetCore.Components.WebAssembly.Authentication.Tests.csproj +++ b/src/Components/WebAssembly/WebAssembly.Authentication/test/Microsoft.AspNetCore.Components.WebAssembly.Authentication.Tests.csproj @@ -3,8 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <NoWarn>$(NoWarn);BL0005;BL0006</NoWarn> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Components/WebAssembly/WebAssembly/test/Microsoft.AspNetCore.Components.WebAssembly.Tests.csproj b/src/Components/WebAssembly/WebAssembly/test/Microsoft.AspNetCore.Components.WebAssembly.Tests.csproj index 6450d01d8aa..2f9ac20c7c0 100644 --- a/src/Components/WebAssembly/WebAssembly/test/Microsoft.AspNetCore.Components.WebAssembly.Tests.csproj +++ b/src/Components/WebAssembly/WebAssembly/test/Microsoft.AspNetCore.Components.WebAssembly.Tests.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Components/WebAssembly/testassets/MonoSanityClient/MonoSanityClient.csproj b/src/Components/WebAssembly/testassets/MonoSanityClient/MonoSanityClient.csproj index d1e6606fb55..9df38c64eb0 100644 --- a/src/Components/WebAssembly/testassets/MonoSanityClient/MonoSanityClient.csproj +++ b/src/Components/WebAssembly/testassets/MonoSanityClient/MonoSanityClient.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>netstandard2.1</TargetFramework> - <IsPackable>false</IsPackable> <BlazorWebAssemblyEnableLinking>false</BlazorWebAssemblyEnableLinking> <OutputType>exe</OutputType> <RazorLangVersion>3.0</RazorLangVersion> diff --git a/src/Components/WebAssembly/testassets/Wasm.Authentication.Client/Wasm.Authentication.Client.csproj b/src/Components/WebAssembly/testassets/Wasm.Authentication.Client/Wasm.Authentication.Client.csproj index bd2ecad9e44..6ade900b99a 100644 --- a/src/Components/WebAssembly/testassets/Wasm.Authentication.Client/Wasm.Authentication.Client.csproj +++ b/src/Components/WebAssembly/testassets/Wasm.Authentication.Client/Wasm.Authentication.Client.csproj @@ -5,8 +5,6 @@ <RazorLangVersion>3.0</RazorLangVersion> <ReferenceBlazorBuildLocally>true</ReferenceBlazorBuildLocally> <FixupWebAssemblyHttpHandlerReference>true</FixupWebAssemblyHttpHandlerReference> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Components/WebAssembly/testassets/Wasm.Authentication.Server/Wasm.Authentication.Server.csproj b/src/Components/WebAssembly/testassets/Wasm.Authentication.Server/Wasm.Authentication.Server.csproj index 3d6b47ebe76..8f0b7091981 100644 --- a/src/Components/WebAssembly/testassets/Wasm.Authentication.Server/Wasm.Authentication.Server.csproj +++ b/src/Components/WebAssembly/testassets/Wasm.Authentication.Server/Wasm.Authentication.Server.csproj @@ -6,7 +6,6 @@ <!-- This project references the shared framework transitively. Prevent restore errors by setting this flag. --> <GenerateErrorForMissingTargetingPacks>false</GenerateErrorForMissingTargetingPacks> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Components/benchmarkapps/Wasm.Performance/Driver/Wasm.Performance.Driver.csproj b/src/Components/benchmarkapps/Wasm.Performance/Driver/Wasm.Performance.Driver.csproj index 5e82b713a62..523c04d26bf 100644 --- a/src/Components/benchmarkapps/Wasm.Performance/Driver/Wasm.Performance.Driver.csproj +++ b/src/Components/benchmarkapps/Wasm.Performance/Driver/Wasm.Performance.Driver.csproj @@ -4,15 +4,10 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <OutputType>exe</OutputType> - <HasReferenceAssembly>false</HasReferenceAssembly> - <IsProjectReferenceProvider>false</IsProjectReferenceProvider> <IsShippingPackage>false</IsShippingPackage> - <IsPackable>false</IsPackable> - <!-- WebDriver is not strong-named, so this test project cannot be strong named either. --> <SignAssembly>false</SignAssembly> <IsTestAssetProject>true</IsTestAssetProject> - <IsPackable>false</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Components/benchmarkapps/Wasm.Performance/TestApp/Wasm.Performance.TestApp.csproj b/src/Components/benchmarkapps/Wasm.Performance/TestApp/Wasm.Performance.TestApp.csproj index e3a69ae6ace..57de501f634 100644 --- a/src/Components/benchmarkapps/Wasm.Performance/TestApp/Wasm.Performance.TestApp.csproj +++ b/src/Components/benchmarkapps/Wasm.Performance/TestApp/Wasm.Performance.TestApp.csproj @@ -3,9 +3,6 @@ <PropertyGroup> <TargetFramework>netstandard2.1</TargetFramework> <RazorLangVersion>3.0</RazorLangVersion> - - <HasReferenceAssembly>false</HasReferenceAssembly> - <IsProjectReferenceProvider>false</IsProjectReferenceProvider> <ReferenceBlazorBuildLocally>true</ReferenceBlazorBuildLocally> <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> diff --git a/src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj b/src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj index 2c10d302506..fb063e00c8e 100644 --- a/src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj +++ b/src/Components/test/E2ETest/Microsoft.AspNetCore.Components.E2ETests.csproj @@ -21,9 +21,6 @@ <GenerateLoggingTestingAssemblyAttributes>false</GenerateLoggingTestingAssemblyAttributes> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> - <!-- This project references the shared framework transitively. Prevent restore errors by setting this flag. --> <GenerateErrorForMissingTargetingPacks>false</GenerateErrorForMissingTargetingPacks> </PropertyGroup> diff --git a/src/Components/test/testassets/TestServer/Components.TestServer.csproj b/src/Components/test/testassets/TestServer/Components.TestServer.csproj index 90c9f98bc41..2af0147461e 100644 --- a/src/Components/test/testassets/TestServer/Components.TestServer.csproj +++ b/src/Components/test/testassets/TestServer/Components.TestServer.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Configuration.KeyPerFile/src/Microsoft.Extensions.Configuration.KeyPerFile.csproj b/src/Configuration.KeyPerFile/src/Microsoft.Extensions.Configuration.KeyPerFile.csproj index af1ecb684fe..aeffe0a751c 100644 --- a/src/Configuration.KeyPerFile/src/Microsoft.Extensions.Configuration.KeyPerFile.csproj +++ b/src/Configuration.KeyPerFile/src/Microsoft.Extensions.Configuration.KeyPerFile.csproj @@ -4,7 +4,6 @@ <Description>Configuration provider that uses files in a directory for Microsoft.Extensions.Configuration.</Description> <TargetFrameworks>netstandard2.0;$(DefaultNetCoreTargetFramework)</TargetFrameworks> <TargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">$(DefaultNetCoreTargetFramework)</TargetFrameworks> - <IsPackable>true</IsPackable> <IsAspNetCoreApp>true</IsAspNetCoreApp> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>configuration</PackageTags> diff --git a/src/DataProtection/EntityFrameworkCore/src/Microsoft.AspNetCore.DataProtection.EntityFrameworkCore.csproj b/src/DataProtection/EntityFrameworkCore/src/Microsoft.AspNetCore.DataProtection.EntityFrameworkCore.csproj index 63c9ad80dc2..b5fc6a74ed8 100644 --- a/src/DataProtection/EntityFrameworkCore/src/Microsoft.AspNetCore.DataProtection.EntityFrameworkCore.csproj +++ b/src/DataProtection/EntityFrameworkCore/src/Microsoft.AspNetCore.DataProtection.EntityFrameworkCore.csproj @@ -1,4 +1,4 @@ -<Project Sdk="Microsoft.NET.Sdk"> +<Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <Description>Support for storing keys using Entity Framework Core.</Description> @@ -6,7 +6,6 @@ <AllowUnsafeBlocks>true</AllowUnsafeBlocks> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;dataprotection;entityframeworkcore</PackageTags> - <IsPackable>true</IsPackable> <Nullable>enable</Nullable> </PropertyGroup> diff --git a/src/DataProtection/EntityFrameworkCore/test/Microsoft.AspNetCore.DataProtection.EntityFrameworkCore.Test.csproj b/src/DataProtection/EntityFrameworkCore/test/Microsoft.AspNetCore.DataProtection.EntityFrameworkCore.Test.csproj index dab3dbb68a2..89f5b49dd9b 100644 --- a/src/DataProtection/EntityFrameworkCore/test/Microsoft.AspNetCore.DataProtection.EntityFrameworkCore.Test.csproj +++ b/src/DataProtection/EntityFrameworkCore/test/Microsoft.AspNetCore.DataProtection.EntityFrameworkCore.Test.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/DataProtection/StackExchangeRedis/src/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.csproj b/src/DataProtection/StackExchangeRedis/src/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.csproj index ab7553df960..499e6be9caf 100644 --- a/src/DataProtection/StackExchangeRedis/src/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.csproj +++ b/src/DataProtection/StackExchangeRedis/src/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.csproj @@ -1,4 +1,4 @@ -<Project Sdk="Microsoft.NET.Sdk"> +<Project Sdk="Microsoft.NET.Sdk"> <PropertyGroup> <Description>Support for storing data protection keys in Redis.</Description> @@ -6,7 +6,6 @@ <AllowUnsafeBlocks>true</AllowUnsafeBlocks> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;dataprotection;redis</PackageTags> - <IsPackable>true</IsPackable> <Nullable>enable</Nullable> </PropertyGroup> diff --git a/src/DataProtection/StackExchangeRedis/test/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.Tests.csproj b/src/DataProtection/StackExchangeRedis/test/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.Tests.csproj index 3bfb97422c2..149d2fff52b 100644 --- a/src/DataProtection/StackExchangeRedis/test/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.Tests.csproj +++ b/src/DataProtection/StackExchangeRedis/test/Microsoft.AspNetCore.DataProtection.StackExchangeRedis.Tests.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/DataProtection/samples/EntityFrameworkCoreSample/EntityFrameworkCoreSample.csproj b/src/DataProtection/samples/EntityFrameworkCoreSample/EntityFrameworkCoreSample.csproj index 24b0634e1c4..5556759fab6 100644 --- a/src/DataProtection/samples/EntityFrameworkCoreSample/EntityFrameworkCoreSample.csproj +++ b/src/DataProtection/samples/EntityFrameworkCoreSample/EntityFrameworkCoreSample.csproj @@ -3,8 +3,6 @@ <PropertyGroup> <OutputType>exe</OutputType> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/DataProtection/samples/Redis/Redis.csproj b/src/DataProtection/samples/Redis/Redis.csproj index 4ba6eaccc7f..b053b917b24 100644 --- a/src/DataProtection/samples/Redis/Redis.csproj +++ b/src/DataProtection/samples/Redis/Redis.csproj @@ -3,8 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <OutputType>exe</OutputType> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Features/JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj b/src/Features/JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj index 73e2f0025b6..f6f11fd3b3f 100644 --- a/src/Features/JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj +++ b/src/Features/JsonPatch/src/Microsoft.AspNetCore.JsonPatch.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;json;jsonpatch</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/FileProviders/Embedded/src/Microsoft.Extensions.FileProviders.Embedded.csproj b/src/FileProviders/Embedded/src/Microsoft.Extensions.FileProviders.Embedded.csproj index 13000f08144..459a9973b94 100644 --- a/src/FileProviders/Embedded/src/Microsoft.Extensions.FileProviders.Embedded.csproj +++ b/src/FileProviders/Embedded/src/Microsoft.Extensions.FileProviders.Embedded.csproj @@ -7,7 +7,6 @@ <NuspecFile>$(MSBuildProjectName).multitarget.nuspec</NuspecFile> <TargetFrameworks Condition="'$(DotNetBuildFromSource)' == 'true'">$(DefaultNetCoreTargetFramework)</TargetFrameworks> <NuspecFile Condition="'$(DotNetBuildFromSource)' == 'true'">$(MSBuildProjectName).netcoreapp.nuspec</NuspecFile> - <IsPackable>true</IsPackable> <IsAspNetCoreApp>true</IsAspNetCoreApp> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>files;filesystem</PackageTags> diff --git a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj index 091b78b776e..ae75b05dad2 100644 --- a/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj +++ b/src/Framework/App.Runtime/src/Microsoft.AspNetCore.App.Runtime.csproj @@ -7,10 +7,8 @@ <!-- Even though RuntimeIdentifier is set, shared framework projects are not self-contained projects --> <SelfContained>false</SelfContained> <PackageId>$(MSBuildProjectName).$(RuntimeIdentifier)</PackageId> - <IsPackable>true</IsPackable> <!-- Do not exclude this project from source build --> <ExcludeFromSourceBuild>false</ExcludeFromSourceBuild> - <HasReferenceAssembly>false</HasReferenceAssembly> <PackageDescription>Provides a default set of APIs for building an ASP.NET Core application. Contains assets used for self-contained deployments. This package is an internal implementation of the .NET Core SDK and is not meant to be used as a normal PackageReference. diff --git a/src/HealthChecks/Abstractions/src/Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions.csproj b/src/HealthChecks/Abstractions/src/Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions.csproj index 9575431a564..93fda5d4de8 100644 --- a/src/HealthChecks/Abstractions/src/Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions.csproj +++ b/src/HealthChecks/Abstractions/src/Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions.csproj @@ -12,7 +12,6 @@ Microsoft.Extensions.Diagnostics.HealthChecks.IHealthCheck <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>diagnostics;healthchecks</PackageTags> - <IsPackable>true</IsPackable> <IsAspNetCoreApp>true</IsAspNetCoreApp> <Nullable>enable</Nullable> </PropertyGroup> diff --git a/src/HealthChecks/HealthChecks/src/Microsoft.Extensions.Diagnostics.HealthChecks.csproj b/src/HealthChecks/HealthChecks/src/Microsoft.Extensions.Diagnostics.HealthChecks.csproj index 505a90fc3d9..7b000f96578 100644 --- a/src/HealthChecks/HealthChecks/src/Microsoft.Extensions.Diagnostics.HealthChecks.csproj +++ b/src/HealthChecks/HealthChecks/src/Microsoft.Extensions.Diagnostics.HealthChecks.csproj @@ -11,7 +11,6 @@ Microsoft.Extensions.Diagnostics.HealthChecks.IHealthChecksBuilder <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>diagnostics;healthchecks</PackageTags> - <IsPackable>true</IsPackable> <IsAspNetCoreApp>true</IsAspNetCoreApp> <Nullable>enable</Nullable> </PropertyGroup> diff --git a/src/Hosting/TestHost/src/Microsoft.AspNetCore.TestHost.csproj b/src/Hosting/TestHost/src/Microsoft.AspNetCore.TestHost.csproj index 4afca002df3..d91a72748de 100644 --- a/src/Hosting/TestHost/src/Microsoft.AspNetCore.TestHost.csproj +++ b/src/Hosting/TestHost/src/Microsoft.AspNetCore.TestHost.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;hosting;testing</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Hosting/WindowsServices/src/Microsoft.AspNetCore.Hosting.WindowsServices.csproj b/src/Hosting/WindowsServices/src/Microsoft.AspNetCore.Hosting.WindowsServices.csproj index 18171d7c57a..eabc8caa828 100644 --- a/src/Hosting/WindowsServices/src/Microsoft.AspNetCore.Hosting.WindowsServices.csproj +++ b/src/Hosting/WindowsServices/src/Microsoft.AspNetCore.Hosting.WindowsServices.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;hosting</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Http/Http/perf/Microsoft.AspNetCore.Http.Performance.csproj b/src/Http/Http/perf/Microsoft.AspNetCore.Http.Performance.csproj index 7f371de3801..01539b81e19 100644 --- a/src/Http/Http/perf/Microsoft.AspNetCore.Http.Performance.csproj +++ b/src/Http/Http/perf/Microsoft.AspNetCore.Http.Performance.csproj @@ -5,7 +5,6 @@ <OutputType>Exe</OutputType> <ServerGarbageCollection>true</ServerGarbageCollection> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsPackable>false</IsPackable> <RootNamespace>Microsoft.AspNetCore.Http</RootNamespace> </PropertyGroup> diff --git a/src/Http/Owin/src/Microsoft.AspNetCore.Owin.csproj b/src/Http/Owin/src/Microsoft.AspNetCore.Owin.csproj index 590ab5661ce..dcac86d91e5 100644 --- a/src/Http/Owin/src/Microsoft.AspNetCore.Owin.csproj +++ b/src/Http/Owin/src/Microsoft.AspNetCore.Owin.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;owin</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Http/Routing/perf/Microsoft.AspNetCore.Routing.Performance.csproj b/src/Http/Routing/perf/Microsoft.AspNetCore.Routing.Performance.csproj index 4f68c48487a..4c273bafe4a 100644 --- a/src/Http/Routing/perf/Microsoft.AspNetCore.Routing.Performance.csproj +++ b/src/Http/Routing/perf/Microsoft.AspNetCore.Routing.Performance.csproj @@ -5,7 +5,6 @@ <OutputType>Exe</OutputType> <ServerGarbageCollection>true</ServerGarbageCollection> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsPackable>false</IsPackable> <RootNamespace>Microsoft.AspNetCore.Routing</RootNamespace> </PropertyGroup> diff --git a/src/Http/WebUtilities/perf/Microsoft.AspNetCore.WebUtilities.Performance/Microsoft.AspNetCore.WebUtilities.Performance.csproj b/src/Http/WebUtilities/perf/Microsoft.AspNetCore.WebUtilities.Performance/Microsoft.AspNetCore.WebUtilities.Performance.csproj index 4744da361b8..dd68ccd0fc6 100644 --- a/src/Http/WebUtilities/perf/Microsoft.AspNetCore.WebUtilities.Performance/Microsoft.AspNetCore.WebUtilities.Performance.csproj +++ b/src/Http/WebUtilities/perf/Microsoft.AspNetCore.WebUtilities.Performance/Microsoft.AspNetCore.WebUtilities.Performance.csproj @@ -5,7 +5,6 @@ <OutputType>Exe</OutputType> <ServerGarbageCollection>true</ServerGarbageCollection> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsPackable>false</IsPackable> <RootNamespace>Microsoft.AspNetCore.WebUtilities</RootNamespace> </PropertyGroup> diff --git a/src/Identity/ApiAuthorization.IdentityServer/samples/ApiAuthSample/ApiAuthSample.csproj b/src/Identity/ApiAuthorization.IdentityServer/samples/ApiAuthSample/ApiAuthSample.csproj index 09e3ef16002..bedbe38bc3c 100644 --- a/src/Identity/ApiAuthorization.IdentityServer/samples/ApiAuthSample/ApiAuthSample.csproj +++ b/src/Identity/ApiAuthorization.IdentityServer/samples/ApiAuthSample/ApiAuthSample.csproj @@ -6,8 +6,6 @@ <!-- We are a package that depends on the shared framework, this allows us to avoid errors during restore --> <GenerateErrorForMissingTargetingPacks>false</GenerateErrorForMissingTargetingPacks> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Identity/ApiAuthorization.IdentityServer/src/Microsoft.AspNetCore.ApiAuthorization.IdentityServer.csproj b/src/Identity/ApiAuthorization.IdentityServer/src/Microsoft.AspNetCore.ApiAuthorization.IdentityServer.csproj index 95cde240e2a..a04b9bd0b98 100644 --- a/src/Identity/ApiAuthorization.IdentityServer/src/Microsoft.AspNetCore.ApiAuthorization.IdentityServer.csproj +++ b/src/Identity/ApiAuthorization.IdentityServer/src/Microsoft.AspNetCore.ApiAuthorization.IdentityServer.csproj @@ -5,9 +5,6 @@ <Description>ASP.NET Core API Authorization package powered by Identity Server.</Description> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;apiauth;identity</PackageTags> - <HasReferenceAssembly>false</HasReferenceAssembly> - <IsPackable>true</IsPackable> - <HasReferenceAssembly>false</HasReferenceAssembly> <!-- We are a package that depends on the shared framework, this allows us to avoid errors during restore --> <GenerateErrorForMissingTargetingPacks>false</GenerateErrorForMissingTargetingPacks> diff --git a/src/Identity/EntityFrameworkCore/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore.csproj b/src/Identity/EntityFrameworkCore/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore.csproj index 3e4b1253171..10eca21ec66 100644 --- a/src/Identity/EntityFrameworkCore/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore.csproj +++ b/src/Identity/EntityFrameworkCore/src/Microsoft.AspNetCore.Identity.EntityFrameworkCore.csproj @@ -5,7 +5,6 @@ <TargetFrameworks>netstandard2.1;$(DefaultNetCoreTargetFramework)</TargetFrameworks> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;entityframeworkcore;identity;membership</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Identity/EntityFrameworkCore/test/EF.InMemory.Test/Microsoft.AspNetCore.Identity.EntityFrameworkCore.InMemory.Test.csproj b/src/Identity/EntityFrameworkCore/test/EF.InMemory.Test/Microsoft.AspNetCore.Identity.EntityFrameworkCore.InMemory.Test.csproj index 811dfd7b768..a28e0951f53 100644 --- a/src/Identity/EntityFrameworkCore/test/EF.InMemory.Test/Microsoft.AspNetCore.Identity.EntityFrameworkCore.InMemory.Test.csproj +++ b/src/Identity/EntityFrameworkCore/test/EF.InMemory.Test/Microsoft.AspNetCore.Identity.EntityFrameworkCore.InMemory.Test.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Identity/EntityFrameworkCore/test/EF.Test/Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.csproj b/src/Identity/EntityFrameworkCore/test/EF.Test/Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.csproj index af1c54332cd..2b5b3c87163 100644 --- a/src/Identity/EntityFrameworkCore/test/EF.Test/Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.csproj +++ b/src/Identity/EntityFrameworkCore/test/EF.Test/Microsoft.AspNetCore.Identity.EntityFrameworkCore.Test.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Identity/Specification.Tests/src/Microsoft.AspNetCore.Identity.Specification.Tests.csproj b/src/Identity/Specification.Tests/src/Microsoft.AspNetCore.Identity.Specification.Tests.csproj index dec1c271c39..ab593d04a16 100644 --- a/src/Identity/Specification.Tests/src/Microsoft.AspNetCore.Identity.Specification.Tests.csproj +++ b/src/Identity/Specification.Tests/src/Microsoft.AspNetCore.Identity.Specification.Tests.csproj @@ -7,7 +7,6 @@ <PackageTags>aspnetcore;identity;membership</PackageTags> <IsTestProject>false</IsTestProject> <IsPackable>false</IsPackable> - <HasReferenceAssembly>false</HasReferenceAssembly> </PropertyGroup> <ItemGroup> diff --git a/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj b/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj index 23f9d4bad5a..892feb4fc10 100644 --- a/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj +++ b/src/Identity/UI/src/Microsoft.AspNetCore.Identity.UI.csproj @@ -6,7 +6,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;identity;membership;razorpages</PackageTags> - <IsPackable>true</IsPackable> <ProvideApplicationPartFactoryAttributeTypeName>Microsoft.AspNetCore.Mvc.ApplicationParts.NullApplicationPartFactory, Microsoft.AspNetCore.Mvc.Core</ProvideApplicationPartFactoryAttributeTypeName> <RazorCompileOnBuild>false</RazorCompileOnBuild> <RazorCompileOnPublish>false</RazorCompileOnPublish> diff --git a/src/Identity/samples/IdentitySample.DefaultUI/IdentitySample.DefaultUI.csproj b/src/Identity/samples/IdentitySample.DefaultUI/IdentitySample.DefaultUI.csproj index 2c59fad47a7..e3fe2a3ebe6 100644 --- a/src/Identity/samples/IdentitySample.DefaultUI/IdentitySample.DefaultUI.csproj +++ b/src/Identity/samples/IdentitySample.DefaultUI/IdentitySample.DefaultUI.csproj @@ -5,8 +5,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <UserSecretsId>aspnetcore-2ff9bc27-5e8c-4484-90ca-e3aace89b72a</UserSecretsId> <IdentityUIFrameworkVersion>Bootstrap4</IdentityUIFrameworkVersion> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Identity/samples/IdentitySample.Mvc/IdentitySample.Mvc.csproj b/src/Identity/samples/IdentitySample.Mvc/IdentitySample.Mvc.csproj index cb60d3e0095..493290af245 100644 --- a/src/Identity/samples/IdentitySample.Mvc/IdentitySample.Mvc.csproj +++ b/src/Identity/samples/IdentitySample.Mvc/IdentitySample.Mvc.csproj @@ -4,8 +4,6 @@ <Description>Identity sample MVC application on ASP.NET Core</Description> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <UserSecretsId>aspnetcore-b3d20cbe-418e-4bf2-a0f4-57f91d067e07</UserSecretsId> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Identity/test/Identity.FunctionalTests/Microsoft.AspNetCore.Identity.FunctionalTests.csproj b/src/Identity/test/Identity.FunctionalTests/Microsoft.AspNetCore.Identity.FunctionalTests.csproj index e0d7607b915..43507e7ca68 100644 --- a/src/Identity/test/Identity.FunctionalTests/Microsoft.AspNetCore.Identity.FunctionalTests.csproj +++ b/src/Identity/test/Identity.FunctionalTests/Microsoft.AspNetCore.Identity.FunctionalTests.csproj @@ -4,8 +4,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <!-- Test asset publishing not working on arm64 https://github.com/dotnet/aspnetcore/issues/11205 --> <SkipHelixArm>true</SkipHelixArm> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Identity/testassets/Identity.DefaultUI.WebSite/Identity.DefaultUI.WebSite.csproj b/src/Identity/testassets/Identity.DefaultUI.WebSite/Identity.DefaultUI.WebSite.csproj index 7af6e012025..cb0594a94c8 100644 --- a/src/Identity/testassets/Identity.DefaultUI.WebSite/Identity.DefaultUI.WebSite.csproj +++ b/src/Identity/testassets/Identity.DefaultUI.WebSite/Identity.DefaultUI.WebSite.csproj @@ -4,8 +4,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <UserSecretsId>aspnet-Identity.DefaultUI.WebSite-80C658D8-CED7-467F-9B47-75DA3BC1A16D</UserSecretsId> <IdentityDefaultUIFramework>Bootstrap3</IdentityDefaultUIFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/JSInterop/Microsoft.JSInterop/src/Microsoft.JSInterop.csproj b/src/JSInterop/Microsoft.JSInterop/src/Microsoft.JSInterop.csproj index 07f461121a6..b49d2ea5910 100644 --- a/src/JSInterop/Microsoft.JSInterop/src/Microsoft.JSInterop.csproj +++ b/src/JSInterop/Microsoft.JSInterop/src/Microsoft.JSInterop.csproj @@ -6,7 +6,6 @@ <Description>Abstractions and features for interop between .NET and JavaScript code.</Description> <PackageTags>javascript;interop</PackageTags> <GenerateDocumentationFile>true</GenerateDocumentationFile> - <IsPackable>true</IsPackable> <IsAspNetCoreApp>true</IsAspNetCoreApp> <Nullable>enable</Nullable> </PropertyGroup> diff --git a/src/Localization/Abstractions/src/Microsoft.Extensions.Localization.Abstractions.csproj b/src/Localization/Abstractions/src/Microsoft.Extensions.Localization.Abstractions.csproj index 59c2ee73603..b97304edf82 100644 --- a/src/Localization/Abstractions/src/Microsoft.Extensions.Localization.Abstractions.csproj +++ b/src/Localization/Abstractions/src/Microsoft.Extensions.Localization.Abstractions.csproj @@ -11,7 +11,6 @@ Microsoft.Extensions.Localization.IStringLocalizer<T></Description> <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>localization</PackageTags> - <IsPackable>true</IsPackable> <IsAspNetCoreApp>true</IsAspNetCoreApp> <Nullable>enable</Nullable> </PropertyGroup> diff --git a/src/Localization/Localization/src/Microsoft.Extensions.Localization.csproj b/src/Localization/Localization/src/Microsoft.Extensions.Localization.csproj index be1ebd7044c..d9275db6593 100644 --- a/src/Localization/Localization/src/Microsoft.Extensions.Localization.csproj +++ b/src/Localization/Localization/src/Microsoft.Extensions.Localization.csproj @@ -8,7 +8,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>localization</PackageTags> - <IsPackable>true</IsPackable> <IsAspNetCoreApp>true</IsAspNetCoreApp> <Nullable>enable</Nullable> </PropertyGroup> diff --git a/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj b/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj index 5bedde8c6d8..2a25b5b2c3d 100644 --- a/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj +++ b/src/Logging.AzureAppServices/src/Microsoft.Extensions.Logging.AzureAppServices.csproj @@ -4,7 +4,6 @@ <Description>Logger implementation to support Azure App Services 'Diagnostics logs' and 'Log stream' features.</Description> <TargetFramework>netstandard2.0</TargetFramework> <NoWarn>$(NoWarn);CS1591</NoWarn> - <IsPackable>true</IsPackable> <IsShipping>true</IsShipping> </PropertyGroup> diff --git a/src/Middleware/ConcurrencyLimiter/src/Microsoft.AspNetCore.ConcurrencyLimiter.csproj b/src/Middleware/ConcurrencyLimiter/src/Microsoft.AspNetCore.ConcurrencyLimiter.csproj index 6dae088c1bb..71cb8f7e4e2 100644 --- a/src/Middleware/ConcurrencyLimiter/src/Microsoft.AspNetCore.ConcurrencyLimiter.csproj +++ b/src/Middleware/ConcurrencyLimiter/src/Microsoft.AspNetCore.ConcurrencyLimiter.csproj @@ -5,7 +5,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;queue;queuing</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/Diagnostics.EntityFrameworkCore/src/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.csproj b/src/Middleware/Diagnostics.EntityFrameworkCore/src/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.csproj index 7bb7c4b2f73..8d463180598 100644 --- a/src/Middleware/Diagnostics.EntityFrameworkCore/src/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.csproj +++ b/src/Middleware/Diagnostics.EntityFrameworkCore/src/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;diagnostics;entityframeworkcore</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/Diagnostics.EntityFrameworkCore/test/FunctionalTests/Diagnostics.EFCore.FunctionalTests.csproj b/src/Middleware/Diagnostics.EntityFrameworkCore/test/FunctionalTests/Diagnostics.EFCore.FunctionalTests.csproj index d8c8f759897..38b1212bbc2 100644 --- a/src/Middleware/Diagnostics.EntityFrameworkCore/test/FunctionalTests/Diagnostics.EFCore.FunctionalTests.csproj +++ b/src/Middleware/Diagnostics.EntityFrameworkCore/test/FunctionalTests/Diagnostics.EFCore.FunctionalTests.csproj @@ -4,8 +4,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <!-- Mitigation for long path issues --> <AssemblyName>Diagnostics.EFCore.FunctionalTests</AssemblyName> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/Diagnostics.EntityFrameworkCore/test/UnitTests/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.csproj b/src/Middleware/Diagnostics.EntityFrameworkCore/test/UnitTests/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.csproj index 619ade14213..920e5e38642 100644 --- a/src/Middleware/Diagnostics.EntityFrameworkCore/test/UnitTests/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.csproj +++ b/src/Middleware/Diagnostics.EntityFrameworkCore/test/UnitTests/Microsoft.AspNetCore.Diagnostics.EntityFrameworkCore.Tests.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/Diagnostics/test/testassets/DatabaseErrorPageSample/DatabaseErrorPageSample.csproj b/src/Middleware/Diagnostics/test/testassets/DatabaseErrorPageSample/DatabaseErrorPageSample.csproj index a5fa42625ff..8c2eb744bee 100644 --- a/src/Middleware/Diagnostics/test/testassets/DatabaseErrorPageSample/DatabaseErrorPageSample.csproj +++ b/src/Middleware/Diagnostics/test/testassets/DatabaseErrorPageSample/DatabaseErrorPageSample.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/HeaderPropagation/src/Microsoft.AspNetCore.HeaderPropagation.csproj b/src/Middleware/HeaderPropagation/src/Microsoft.AspNetCore.HeaderPropagation.csproj index c82ea7e2d3f..717e48d7794 100644 --- a/src/Middleware/HeaderPropagation/src/Microsoft.AspNetCore.HeaderPropagation.csproj +++ b/src/Middleware/HeaderPropagation/src/Microsoft.AspNetCore.HeaderPropagation.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <Description>ASP.NET Core middleware to propagate HTTP headers from the incoming request to the outgoing HTTP Client requests</Description> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>true</IsPackable> <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;httpclient</PackageTags> diff --git a/src/Middleware/HealthChecks.EntityFrameworkCore/src/Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.csproj b/src/Middleware/HealthChecks.EntityFrameworkCore/src/Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.csproj index f258cb04101..156acda39c1 100644 --- a/src/Middleware/HealthChecks.EntityFrameworkCore/src/Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.csproj +++ b/src/Middleware/HealthChecks.EntityFrameworkCore/src/Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.csproj @@ -8,7 +8,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>diagnostics;healthchecks;entityframeworkcore</PackageTags> - <IsPackable>true</IsPackable> <BaseNamespace>Microsoft.Extensions.Diagnostics.HealthChecks</BaseNamespace> </PropertyGroup> diff --git a/src/Middleware/HealthChecks.EntityFrameworkCore/test/Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.Tests.csproj b/src/Middleware/HealthChecks.EntityFrameworkCore/test/Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.Tests.csproj index 87931fac8cd..53eab4dbacb 100644 --- a/src/Middleware/HealthChecks.EntityFrameworkCore/test/Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.Tests.csproj +++ b/src/Middleware/HealthChecks.EntityFrameworkCore/test/Microsoft.Extensions.Diagnostics.HealthChecks.EntityFrameworkCore.Tests.csproj @@ -3,8 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <RootNamespace>Microsoft.AspNetCore.Diagnostics.HealthChecks</RootNamespace> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/HealthChecks/test/testassets/HealthChecksSample/HealthChecksSample.csproj b/src/Middleware/HealthChecks/test/testassets/HealthChecksSample/HealthChecksSample.csproj index 9e03c3da4b7..73bf13c1f58 100644 --- a/src/Middleware/HealthChecks/test/testassets/HealthChecksSample/HealthChecksSample.csproj +++ b/src/Middleware/HealthChecks/test/testassets/HealthChecksSample/HealthChecksSample.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/MiddlewareAnalysis/src/Microsoft.AspNetCore.MiddlewareAnalysis.csproj b/src/Middleware/MiddlewareAnalysis/src/Microsoft.AspNetCore.MiddlewareAnalysis.csproj index 4dafc14b701..517a69dea4a 100644 --- a/src/Middleware/MiddlewareAnalysis/src/Microsoft.AspNetCore.MiddlewareAnalysis.csproj +++ b/src/Middleware/MiddlewareAnalysis/src/Microsoft.AspNetCore.MiddlewareAnalysis.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;diagnostics</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/NodeServices/samples/NodeServicesExamples/NodeServicesExamples.csproj b/src/Middleware/NodeServices/samples/NodeServicesExamples/NodeServicesExamples.csproj index 2b834b5b0e8..262b569d434 100644 --- a/src/Middleware/NodeServices/samples/NodeServicesExamples/NodeServicesExamples.csproj +++ b/src/Middleware/NodeServices/samples/NodeServicesExamples/NodeServicesExamples.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks> <TypeScriptCompileBlocked>true</TypeScriptCompileBlocked> - <IsPackable>false</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj b/src/Middleware/NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj index 1ac5e2df8a0..0ff2633422b 100644 --- a/src/Middleware/NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj +++ b/src/Middleware/NodeServices/src/Microsoft.AspNetCore.NodeServices.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <Description>Invoke Node.js modules at runtime in ASP.NET Core applications.</Description> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj b/src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj index 486708b2088..6e6befbe9bb 100644 --- a/src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj +++ b/src/Middleware/SpaServices.Extensions/src/Microsoft.AspNetCore.SpaServices.Extensions.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <Description>Helpers for building single-page applications on ASP.NET MVC Core.</Description> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj b/src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj index 3d7be418f7e..20ad3236ae6 100644 --- a/src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj +++ b/src/Middleware/SpaServices/src/Microsoft.AspNetCore.SpaServices.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <Description>Helpers for building single-page applications on ASP.NET MVC Core.</Description> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/MusicStore/samples/MusicStore/MusicStore.csproj b/src/MusicStore/samples/MusicStore/MusicStore.csproj index 566cc0d6c74..80170076e3b 100644 --- a/src/MusicStore/samples/MusicStore/MusicStore.csproj +++ b/src/MusicStore/samples/MusicStore/MusicStore.csproj @@ -8,8 +8,6 @@ <DefineConstants>$(DefineConstants);DEMO</DefineConstants> <RuntimeIdentifiers>win-x86;win-x64;linux-x64;osx-x64</RuntimeIdentifiers> <InProcessTestSite>true</InProcessTestSite> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/MusicStore/test/MusicStore.E2ETests/MusicStore.E2ETests.csproj b/src/MusicStore/test/MusicStore.E2ETests/MusicStore.E2ETests.csproj index 2861af06f8e..c07555c593b 100644 --- a/src/MusicStore/test/MusicStore.E2ETests/MusicStore.E2ETests.csproj +++ b/src/MusicStore/test/MusicStore.E2ETests/MusicStore.E2ETests.csproj @@ -11,7 +11,6 @@ <!-- https://github.com/dotnet/aspnetcore/issues/8343 --> <BuildHelixPayload>false</BuildHelixPayload> <IsReferenceAssemblyProject>false</IsReferenceAssemblyProject> - <IsProjectReferenceProvider>false</IsProjectReferenceProvider> </PropertyGroup> <ItemGroup> diff --git a/src/MusicStore/test/MusicStore.Test/MusicStore.Test.csproj b/src/MusicStore/test/MusicStore.Test/MusicStore.Test.csproj index 370e72c6f89..9d822e6f6a6 100644 --- a/src/MusicStore/test/MusicStore.Test/MusicStore.Test.csproj +++ b/src/MusicStore/test/MusicStore.Test/MusicStore.Test.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/Directory.Build.props b/src/Mvc/Directory.Build.props index 69911cea29c..ebcc1de5d56 100644 --- a/src/Mvc/Directory.Build.props +++ b/src/Mvc/Directory.Build.props @@ -2,7 +2,6 @@ <Import Project="$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\Directory.Build.props" /> <PropertyGroup Condition=" '$(IsTestProject)' == 'true' "> - <IsPackable>false</IsPackable> <CodeAnalysisRuleSet>$(MSBuildThisFileDirectory)MvcTests.ruleset</CodeAnalysisRuleSet> </PropertyGroup> </Project> diff --git a/src/Mvc/test/WebSites/ApiExplorerWebSite/ApiExplorerWebSite.csproj b/src/Mvc/test/WebSites/ApiExplorerWebSite/ApiExplorerWebSite.csproj index 8ae9c29e7a4..b1fcdbf3ffe 100644 --- a/src/Mvc/test/WebSites/ApiExplorerWebSite/ApiExplorerWebSite.csproj +++ b/src/Mvc/test/WebSites/ApiExplorerWebSite/ApiExplorerWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/ApplicationModelWebSite/ApplicationModelWebSite.csproj b/src/Mvc/test/WebSites/ApplicationModelWebSite/ApplicationModelWebSite.csproj index 4561f10201b..245cae9fb6c 100644 --- a/src/Mvc/test/WebSites/ApplicationModelWebSite/ApplicationModelWebSite.csproj +++ b/src/Mvc/test/WebSites/ApplicationModelWebSite/ApplicationModelWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/BasicWebSite/BasicWebSite.csproj b/src/Mvc/test/WebSites/BasicWebSite/BasicWebSite.csproj index f8ef3662b2f..d57b78a2bd3 100644 --- a/src/Mvc/test/WebSites/BasicWebSite/BasicWebSite.csproj +++ b/src/Mvc/test/WebSites/BasicWebSite/BasicWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/ControllersFromServicesClassLibrary/ControllersFromServicesClassLibrary.csproj b/src/Mvc/test/WebSites/ControllersFromServicesClassLibrary/ControllersFromServicesClassLibrary.csproj index 8a12e89e846..0551d9bf1d5 100644 --- a/src/Mvc/test/WebSites/ControllersFromServicesClassLibrary/ControllersFromServicesClassLibrary.csproj +++ b/src/Mvc/test/WebSites/ControllersFromServicesClassLibrary/ControllersFromServicesClassLibrary.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <PreserveCompilationContext>true</PreserveCompilationContext> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/ControllersFromServicesWebSite/ControllersFromServicesWebSite.csproj b/src/Mvc/test/WebSites/ControllersFromServicesWebSite/ControllersFromServicesWebSite.csproj index 65f6c14c62b..53aa4bf8259 100644 --- a/src/Mvc/test/WebSites/ControllersFromServicesWebSite/ControllersFromServicesWebSite.csproj +++ b/src/Mvc/test/WebSites/ControllersFromServicesWebSite/ControllersFromServicesWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/CorsWebSite/CorsWebSite.csproj b/src/Mvc/test/WebSites/CorsWebSite/CorsWebSite.csproj index 9811da4a16c..a7b866ceeb8 100644 --- a/src/Mvc/test/WebSites/CorsWebSite/CorsWebSite.csproj +++ b/src/Mvc/test/WebSites/CorsWebSite/CorsWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/ErrorPageMiddlewareWebSite/ErrorPageMiddlewareWebSite.csproj b/src/Mvc/test/WebSites/ErrorPageMiddlewareWebSite/ErrorPageMiddlewareWebSite.csproj index e5d9f2e4144..399c6b00b4c 100644 --- a/src/Mvc/test/WebSites/ErrorPageMiddlewareWebSite/ErrorPageMiddlewareWebSite.csproj +++ b/src/Mvc/test/WebSites/ErrorPageMiddlewareWebSite/ErrorPageMiddlewareWebSite.csproj @@ -4,7 +4,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <!-- We want to validate runtime parser \ compilation exceptions --> <RazorCompileOnBuild>false</RazorCompileOnBuild> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/FilesWebSite/FilesWebSite.csproj b/src/Mvc/test/WebSites/FilesWebSite/FilesWebSite.csproj index bac3e462130..b184d086d5e 100644 --- a/src/Mvc/test/WebSites/FilesWebSite/FilesWebSite.csproj +++ b/src/Mvc/test/WebSites/FilesWebSite/FilesWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/FormatterWebSite/FormatterWebSite.csproj b/src/Mvc/test/WebSites/FormatterWebSite/FormatterWebSite.csproj index 0c9ebba1fde..99e5ec73c77 100644 --- a/src/Mvc/test/WebSites/FormatterWebSite/FormatterWebSite.csproj +++ b/src/Mvc/test/WebSites/FormatterWebSite/FormatterWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/GenericHostWebSite/GenericHostWebSite.csproj b/src/Mvc/test/WebSites/GenericHostWebSite/GenericHostWebSite.csproj index fbdd74a34b1..0dedd41518c 100644 --- a/src/Mvc/test/WebSites/GenericHostWebSite/GenericHostWebSite.csproj +++ b/src/Mvc/test/WebSites/GenericHostWebSite/GenericHostWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/HtmlGenerationWebSite/HtmlGenerationWebSite.csproj b/src/Mvc/test/WebSites/HtmlGenerationWebSite/HtmlGenerationWebSite.csproj index cd499d6edd7..f62cdd2b0e3 100644 --- a/src/Mvc/test/WebSites/HtmlGenerationWebSite/HtmlGenerationWebSite.csproj +++ b/src/Mvc/test/WebSites/HtmlGenerationWebSite/HtmlGenerationWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/RazorBuildWebSite.PrecompiledViews/RazorBuildWebSite.PrecompiledViews.csproj b/src/Mvc/test/WebSites/RazorBuildWebSite.PrecompiledViews/RazorBuildWebSite.PrecompiledViews.csproj index 6aa3b0ea19d..2a65e27d378 100644 --- a/src/Mvc/test/WebSites/RazorBuildWebSite.PrecompiledViews/RazorBuildWebSite.PrecompiledViews.csproj +++ b/src/Mvc/test/WebSites/RazorBuildWebSite.PrecompiledViews/RazorBuildWebSite.PrecompiledViews.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <DefineConstants>$(DefineConstants)</DefineConstants> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/RazorBuildWebSite.Views/RazorBuildWebSite.Views.csproj b/src/Mvc/test/WebSites/RazorBuildWebSite.Views/RazorBuildWebSite.Views.csproj index 6aa3b0ea19d..2a65e27d378 100644 --- a/src/Mvc/test/WebSites/RazorBuildWebSite.Views/RazorBuildWebSite.Views.csproj +++ b/src/Mvc/test/WebSites/RazorBuildWebSite.Views/RazorBuildWebSite.Views.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <DefineConstants>$(DefineConstants)</DefineConstants> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj b/src/Mvc/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj index 4664e858908..1262363ef12 100644 --- a/src/Mvc/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj +++ b/src/Mvc/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj @@ -4,7 +4,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <!-- We have tests that test runtime view compilation. --> <RazorCompileOnBuild>false</RazorCompileOnBuild> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/RazorPagesClassLibrary/RazorPagesClassLibrary.csproj b/src/Mvc/test/WebSites/RazorPagesClassLibrary/RazorPagesClassLibrary.csproj index 252fd7e3e28..680c2211606 100644 --- a/src/Mvc/test/WebSites/RazorPagesClassLibrary/RazorPagesClassLibrary.csproj +++ b/src/Mvc/test/WebSites/RazorPagesClassLibrary/RazorPagesClassLibrary.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> <AddRazorSupportForMvc>true</AddRazorSupportForMvc> </PropertyGroup> diff --git a/src/Mvc/test/WebSites/RazorPagesWebSite/RazorPagesWebSite.csproj b/src/Mvc/test/WebSites/RazorPagesWebSite/RazorPagesWebSite.csproj index 8dc95aaf16e..94d6ee4e982 100644 --- a/src/Mvc/test/WebSites/RazorPagesWebSite/RazorPagesWebSite.csproj +++ b/src/Mvc/test/WebSites/RazorPagesWebSite/RazorPagesWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> <!-- Resx files are embedded data --> <GenerateResxSource>false</GenerateResxSource> diff --git a/src/Mvc/test/WebSites/RazorWebSite/RazorWebSite.csproj b/src/Mvc/test/WebSites/RazorWebSite/RazorWebSite.csproj index 02041515430..17de7b68d55 100644 --- a/src/Mvc/test/WebSites/RazorWebSite/RazorWebSite.csproj +++ b/src/Mvc/test/WebSites/RazorWebSite/RazorWebSite.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <DefineConstants>$(DefineConstants);NETCOREAPP2_0_CUSTOM_DEFINE</DefineConstants> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/RoutingWebSite/Mvc.RoutingWebSite.csproj b/src/Mvc/test/WebSites/RoutingWebSite/Mvc.RoutingWebSite.csproj index 312f53cdd3e..0194c0dc8ca 100644 --- a/src/Mvc/test/WebSites/RoutingWebSite/Mvc.RoutingWebSite.csproj +++ b/src/Mvc/test/WebSites/RoutingWebSite/Mvc.RoutingWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/SecurityWebSite/SecurityWebSite.csproj b/src/Mvc/test/WebSites/SecurityWebSite/SecurityWebSite.csproj index 6f65269cd80..f58751997df 100644 --- a/src/Mvc/test/WebSites/SecurityWebSite/SecurityWebSite.csproj +++ b/src/Mvc/test/WebSites/SecurityWebSite/SecurityWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/SimpleWebSite/SimpleWebSite.csproj b/src/Mvc/test/WebSites/SimpleWebSite/SimpleWebSite.csproj index 2535d4f5628..ef489e7bd22 100644 --- a/src/Mvc/test/WebSites/SimpleWebSite/SimpleWebSite.csproj +++ b/src/Mvc/test/WebSites/SimpleWebSite/SimpleWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/TagHelpersWebSite/TagHelpersWebSite.csproj b/src/Mvc/test/WebSites/TagHelpersWebSite/TagHelpersWebSite.csproj index 785b0869c7c..b61ee5fe88d 100644 --- a/src/Mvc/test/WebSites/TagHelpersWebSite/TagHelpersWebSite.csproj +++ b/src/Mvc/test/WebSites/TagHelpersWebSite/TagHelpersWebSite.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/VersioningWebSite/VersioningWebSite.csproj b/src/Mvc/test/WebSites/VersioningWebSite/VersioningWebSite.csproj index 589cfd9fa91..f80af0bb8fc 100644 --- a/src/Mvc/test/WebSites/VersioningWebSite/VersioningWebSite.csproj +++ b/src/Mvc/test/WebSites/VersioningWebSite/VersioningWebSite.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/Mvc/test/WebSites/XmlFormattersWebSite/XmlFormattersWebSite.csproj b/src/Mvc/test/WebSites/XmlFormattersWebSite/XmlFormattersWebSite.csproj index 56abcc28c83..fa3b13eaaca 100644 --- a/src/Mvc/test/WebSites/XmlFormattersWebSite/XmlFormattersWebSite.csproj +++ b/src/Mvc/test/WebSites/XmlFormattersWebSite/XmlFormattersWebSite.csproj @@ -1,7 +1,6 @@ <Project Sdk="Microsoft.NET.Sdk.Web"> <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsTestAssetProject>true</IsTestAssetProject> </PropertyGroup> <ItemGroup> diff --git a/src/ObjectPool/src/Microsoft.Extensions.ObjectPool.csproj b/src/ObjectPool/src/Microsoft.Extensions.ObjectPool.csproj index 1e5d45e9e0f..ff51de0442a 100644 --- a/src/ObjectPool/src/Microsoft.Extensions.ObjectPool.csproj +++ b/src/ObjectPool/src/Microsoft.Extensions.ObjectPool.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>pooling</PackageTags> - <IsPackable>true</IsPackable> <IsAspNetCoreApp>true</IsAspNetCoreApp> <Nullable>enable</Nullable> </PropertyGroup> diff --git a/src/ProjectTemplates/Directory.Build.props b/src/ProjectTemplates/Directory.Build.props index c97ca68bd06..3bf3f50397a 100644 --- a/src/ProjectTemplates/Directory.Build.props +++ b/src/ProjectTemplates/Directory.Build.props @@ -4,7 +4,6 @@ <PropertyGroup> <!-- The .csproj files in this folder do not actually produce .dll's. They are only present to produce .nupkgs and enable Visual Studio support --> <IsProjectReferenceProvider>false</IsProjectReferenceProvider> - <HasReferenceAssembly>false</HasReferenceAssembly> </PropertyGroup> <Import Project="TemplateProjects.props" Condition="'$(IsTestProject)' != 'true' AND '$(IsTestAssetProject)' != 'true'" /> diff --git a/src/ProjectTemplates/Web.Client.ItemTemplates/Microsoft.DotNet.Web.Client.ItemTemplates.csproj b/src/ProjectTemplates/Web.Client.ItemTemplates/Microsoft.DotNet.Web.Client.ItemTemplates.csproj index 7ea486e4b2b..38c7fb6b622 100644 --- a/src/ProjectTemplates/Web.Client.ItemTemplates/Microsoft.DotNet.Web.Client.ItemTemplates.csproj +++ b/src/ProjectTemplates/Web.Client.ItemTemplates/Microsoft.DotNet.Web.Client.ItemTemplates.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <Description>Web Client-Side File Templates for Microsoft Template Engine</Description> - <IsPackable>true</IsPackable> </PropertyGroup> </Project> diff --git a/src/ProjectTemplates/Web.ItemTemplates/Microsoft.DotNet.Web.ItemTemplates.csproj b/src/ProjectTemplates/Web.ItemTemplates/Microsoft.DotNet.Web.ItemTemplates.csproj index d639fb1e0ae..20e88246ec2 100644 --- a/src/ProjectTemplates/Web.ItemTemplates/Microsoft.DotNet.Web.ItemTemplates.csproj +++ b/src/ProjectTemplates/Web.ItemTemplates/Microsoft.DotNet.Web.ItemTemplates.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <Description>Web File Templates for Microsoft Template Engine.</Description> - <IsPackable>true</IsPackable> </PropertyGroup> </Project> diff --git a/src/ProjectTemplates/Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj b/src/ProjectTemplates/Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj index 91c0c3a1654..d36a8d5050c 100644 --- a/src/ProjectTemplates/Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj +++ b/src/ProjectTemplates/Web.ProjectTemplates/Microsoft.DotNet.Web.ProjectTemplates.csproj @@ -4,7 +4,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <PackageId>Microsoft.DotNet.Web.ProjectTemplates.$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion)</PackageId> <Description>ASP.NET Core Web Template Pack for Microsoft Template Engine</Description> - <IsPackable>true</IsPackable> <ComponentsWebAssemblyProjectsRoot>$(RepoRoot)src\Components\WebAssembly\</ComponentsWebAssemblyProjectsRoot> </PropertyGroup> diff --git a/src/ProjectTemplates/Web.Spa.ProjectTemplates/Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj b/src/ProjectTemplates/Web.Spa.ProjectTemplates/Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj index e8e0653f3ca..62e1c07e7db 100644 --- a/src/ProjectTemplates/Web.Spa.ProjectTemplates/Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj +++ b/src/ProjectTemplates/Web.Spa.ProjectTemplates/Microsoft.DotNet.Web.Spa.ProjectTemplates.csproj @@ -5,7 +5,6 @@ <PackageId>Microsoft.DotNet.Web.Spa.ProjectTemplates.$(AspNetCoreMajorVersion).$(AspNetCoreMinorVersion)</PackageId> <Description>Single Page Application templates for ASP.NET Core</Description> <PackageTags>$(PackageTags);spa</PackageTags> - <IsPackable>true</IsPackable> <!-- By default Pack will exclude files that start with '.', we want to include those files --> <NoDefaultExcludes>true</NoDefaultExcludes> </PropertyGroup> diff --git a/src/Razor/perf/Microsoft.AspNetCore.Razor.Performance/Microsoft.AspNetCore.Razor.Performance.csproj b/src/Razor/perf/Microsoft.AspNetCore.Razor.Performance/Microsoft.AspNetCore.Razor.Performance.csproj index 0310ef63a28..c59a1c743ba 100644 --- a/src/Razor/perf/Microsoft.AspNetCore.Razor.Performance/Microsoft.AspNetCore.Razor.Performance.csproj +++ b/src/Razor/perf/Microsoft.AspNetCore.Razor.Performance/Microsoft.AspNetCore.Razor.Performance.csproj @@ -5,7 +5,6 @@ <OutputType>Exe</OutputType> <ServerGarbageCollection>true</ServerGarbageCollection> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsPackable>false</IsPackable> <ExcludeFromSourceBuild>true</ExcludeFromSourceBuild> </PropertyGroup> diff --git a/src/Razor/tools/Microsoft.Aspnetcore.Razor.Internal.Transport/Microsoft.AspNetCore.Razor.Internal.Transport.csproj b/src/Razor/tools/Microsoft.Aspnetcore.Razor.Internal.Transport/Microsoft.AspNetCore.Razor.Internal.Transport.csproj index 7ccfeb54497..7be2683e2a0 100644 --- a/src/Razor/tools/Microsoft.Aspnetcore.Razor.Internal.Transport/Microsoft.AspNetCore.Razor.Internal.Transport.csproj +++ b/src/Razor/tools/Microsoft.Aspnetcore.Razor.Internal.Transport/Microsoft.AspNetCore.Razor.Internal.Transport.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <Description>Transport package for Mvc.Razor.Extensions pdbs. For internal use only.</Description> <TargetFramework>netstandard2.0</TargetFramework> - <IsPackable>true</IsPackable> <IsShipping>false</IsShipping> <IncludeBuildOutput>false</IncludeBuildOutput> <SuppressDependenciesWhenPacking>true</SuppressDependenciesWhenPacking> diff --git a/src/Security/Authentication/Certificate/src/Microsoft.AspNetCore.Authentication.Certificate.csproj b/src/Security/Authentication/Certificate/src/Microsoft.AspNetCore.Authentication.Certificate.csproj index 4bc3a361ec7..0b0e5741605 100644 --- a/src/Security/Authentication/Certificate/src/Microsoft.AspNetCore.Authentication.Certificate.csproj +++ b/src/Security/Authentication/Certificate/src/Microsoft.AspNetCore.Authentication.Certificate.csproj @@ -6,7 +6,6 @@ <DefineConstants>$(DefineConstants);SECURITY</DefineConstants> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;authentication;security;x509;certificate</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Security/Authentication/Facebook/src/Microsoft.AspNetCore.Authentication.Facebook.csproj b/src/Security/Authentication/Facebook/src/Microsoft.AspNetCore.Authentication.Facebook.csproj index 4977e1892b4..12e6e562b55 100644 --- a/src/Security/Authentication/Facebook/src/Microsoft.AspNetCore.Authentication.Facebook.csproj +++ b/src/Security/Authentication/Facebook/src/Microsoft.AspNetCore.Authentication.Facebook.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;authentication;security</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Security/Authentication/Google/src/Microsoft.AspNetCore.Authentication.Google.csproj b/src/Security/Authentication/Google/src/Microsoft.AspNetCore.Authentication.Google.csproj index 774fa9cac04..cfbc074c0e3 100644 --- a/src/Security/Authentication/Google/src/Microsoft.AspNetCore.Authentication.Google.csproj +++ b/src/Security/Authentication/Google/src/Microsoft.AspNetCore.Authentication.Google.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;authentication;security</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Security/Authentication/JwtBearer/src/Microsoft.AspNetCore.Authentication.JwtBearer.csproj b/src/Security/Authentication/JwtBearer/src/Microsoft.AspNetCore.Authentication.JwtBearer.csproj index efee848b372..eedf3cb46b3 100644 --- a/src/Security/Authentication/JwtBearer/src/Microsoft.AspNetCore.Authentication.JwtBearer.csproj +++ b/src/Security/Authentication/JwtBearer/src/Microsoft.AspNetCore.Authentication.JwtBearer.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;authentication;security</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Security/Authentication/MicrosoftAccount/src/Microsoft.AspNetCore.Authentication.MicrosoftAccount.csproj b/src/Security/Authentication/MicrosoftAccount/src/Microsoft.AspNetCore.Authentication.MicrosoftAccount.csproj index 0f2dc832cce..2184a59b2a8 100644 --- a/src/Security/Authentication/MicrosoftAccount/src/Microsoft.AspNetCore.Authentication.MicrosoftAccount.csproj +++ b/src/Security/Authentication/MicrosoftAccount/src/Microsoft.AspNetCore.Authentication.MicrosoftAccount.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;authentication;security</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Security/Authentication/Negotiate/src/Microsoft.AspNetCore.Authentication.Negotiate.csproj b/src/Security/Authentication/Negotiate/src/Microsoft.AspNetCore.Authentication.Negotiate.csproj index 390c449d9fd..265ffb533a1 100644 --- a/src/Security/Authentication/Negotiate/src/Microsoft.AspNetCore.Authentication.Negotiate.csproj +++ b/src/Security/Authentication/Negotiate/src/Microsoft.AspNetCore.Authentication.Negotiate.csproj @@ -5,7 +5,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;authentication;security</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Security/Authentication/OpenIdConnect/src/Microsoft.AspNetCore.Authentication.OpenIdConnect.csproj b/src/Security/Authentication/OpenIdConnect/src/Microsoft.AspNetCore.Authentication.OpenIdConnect.csproj index 8a6c82928d9..c0c782fac63 100644 --- a/src/Security/Authentication/OpenIdConnect/src/Microsoft.AspNetCore.Authentication.OpenIdConnect.csproj +++ b/src/Security/Authentication/OpenIdConnect/src/Microsoft.AspNetCore.Authentication.OpenIdConnect.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;authentication;security</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Security/Authentication/Twitter/src/Microsoft.AspNetCore.Authentication.Twitter.csproj b/src/Security/Authentication/Twitter/src/Microsoft.AspNetCore.Authentication.Twitter.csproj index c59a0fb276b..f29f858f8aa 100644 --- a/src/Security/Authentication/Twitter/src/Microsoft.AspNetCore.Authentication.Twitter.csproj +++ b/src/Security/Authentication/Twitter/src/Microsoft.AspNetCore.Authentication.Twitter.csproj @@ -6,7 +6,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;authentication;security</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Security/Authentication/WsFederation/src/Microsoft.AspNetCore.Authentication.WsFederation.csproj b/src/Security/Authentication/WsFederation/src/Microsoft.AspNetCore.Authentication.WsFederation.csproj index 7d1a23fabde..6e44c68429c 100644 --- a/src/Security/Authentication/WsFederation/src/Microsoft.AspNetCore.Authentication.WsFederation.csproj +++ b/src/Security/Authentication/WsFederation/src/Microsoft.AspNetCore.Authentication.WsFederation.csproj @@ -5,7 +5,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore;authentication;security</PackageTags> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Security/benchmarks/Microsoft.AspNetCore.Security.Performance/Microsoft.AspNetCore.Security.Performance.csproj b/src/Security/benchmarks/Microsoft.AspNetCore.Security.Performance/Microsoft.AspNetCore.Security.Performance.csproj index 65871e5a783..0e1fd48c208 100644 --- a/src/Security/benchmarks/Microsoft.AspNetCore.Security.Performance/Microsoft.AspNetCore.Security.Performance.csproj +++ b/src/Security/benchmarks/Microsoft.AspNetCore.Security.Performance/Microsoft.AspNetCore.Security.Performance.csproj @@ -5,7 +5,6 @@ <OutputType>Exe</OutputType> <ServerGarbageCollection>true</ServerGarbageCollection> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsPackable>false</IsPackable> <RootNamespace>Microsoft.AspNetCore.Security</RootNamespace> </PropertyGroup> diff --git a/src/Security/samples/Identity.ExternalClaims/Identity.ExternalClaims.csproj b/src/Security/samples/Identity.ExternalClaims/Identity.ExternalClaims.csproj index a740b52b2cb..d84700e69f4 100644 --- a/src/Security/samples/Identity.ExternalClaims/Identity.ExternalClaims.csproj +++ b/src/Security/samples/Identity.ExternalClaims/Identity.ExternalClaims.csproj @@ -3,8 +3,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <UserSecretsId>aspnet-Identity.ExternalClaims-E95BE154-CB1B-4633-A2E0-B2DF12FE8BD3</UserSecretsId> <IsTestAssetProject>true</IsTestAssetProject> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> <Reference Include="Microsoft.AspNetCore" /> diff --git a/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj b/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj index 16c9bc44794..befc2407bbb 100644 --- a/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj +++ b/src/Servers/IIS/AspNetCoreModuleV2/Symbols/Microsoft.AspNetCore.ANCMSymbols.csproj @@ -13,7 +13,6 @@ <DebugType>none</DebugType> <CopyBuildOutputToOutputDirectory>false</CopyBuildOutputToOutputDirectory> <GenerateDocumentationFile>false</GenerateDocumentationFile> - <HasReferenceAssembly>false</HasReferenceAssembly> <IsProjectReferenceProvider>false</IsProjectReferenceProvider> <TargetsForTfmSpecificBuildOutput> $(TargetsForTfmSpecificBuildOutput); diff --git a/src/Servers/IIS/IIS/benchmarks/IIS.Performance/IIS.Performance.csproj b/src/Servers/IIS/IIS/benchmarks/IIS.Performance/IIS.Performance.csproj index 2abb302273f..c2d27446478 100644 --- a/src/Servers/IIS/IIS/benchmarks/IIS.Performance/IIS.Performance.csproj +++ b/src/Servers/IIS/IIS/benchmarks/IIS.Performance/IIS.Performance.csproj @@ -8,7 +8,6 @@ <OutputType>Exe</OutputType> <ServerGarbageCollection>true</ServerGarbageCollection> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsPackable>false</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Servers/IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj b/src/Servers/IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj index 33bb78dc4bc..d98aab50da2 100644 --- a/src/Servers/IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj +++ b/src/Servers/IIS/IntegrationTesting.IIS/src/Microsoft.AspNetCore.Server.IntegrationTesting.IIS.csproj @@ -13,7 +13,6 @@ <!-- This is used as a package by aspnet benchmarking infrastructure. It is meant for internal-use only. --> <IsPackable>true</IsPackable> <IsShippingPackage>false</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> <!-- The assembly 'contentFiles\any\any\x64\aspnetcorev2.dll' is intentionally not inside the 'lib' folder and hence it won't be added as a reference when diff --git a/src/Servers/Kestrel/Transport.Libuv/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.csproj b/src/Servers/Kestrel/Transport.Libuv/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.csproj index 9bc5d6b037c..da785c11969 100644 --- a/src/Servers/Kestrel/Transport.Libuv/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.csproj +++ b/src/Servers/Kestrel/Transport.Libuv/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Libuv.csproj @@ -7,7 +7,6 @@ <PackageTags>aspnetcore;kestrel</PackageTags> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> <NoWarn>CS1591;$(NoWarn)</NoWarn> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Servers/Kestrel/Transport.Quic/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Experimental.Quic.csproj b/src/Servers/Kestrel/Transport.Quic/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Experimental.Quic.csproj index 69b85b72046..d06aa4c1119 100644 --- a/src/Servers/Kestrel/Transport.Quic/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Experimental.Quic.csproj +++ b/src/Servers/Kestrel/Transport.Quic/src/Microsoft.AspNetCore.Server.Kestrel.Transport.Experimental.Quic.csproj @@ -7,7 +7,6 @@ <PackageTags>aspnetcore;kestrel</PackageTags> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> <NoWarn>CS1591;CS0436;$(NoWarn)</NoWarn><!-- Conflicts between internal and public Quic APIs --> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Servers/Kestrel/perf/Kestrel.Performance/Microsoft.AspNetCore.Server.Kestrel.Performance.csproj b/src/Servers/Kestrel/perf/Kestrel.Performance/Microsoft.AspNetCore.Server.Kestrel.Performance.csproj index ef22ae3002d..b0dc6d82dc4 100644 --- a/src/Servers/Kestrel/perf/Kestrel.Performance/Microsoft.AspNetCore.Server.Kestrel.Performance.csproj +++ b/src/Servers/Kestrel/perf/Kestrel.Performance/Microsoft.AspNetCore.Server.Kestrel.Performance.csproj @@ -5,7 +5,6 @@ <OutputType>Exe</OutputType> <ServerGarbageCollection>true</ServerGarbageCollection> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsPackable>false</IsPackable> <TieredCompilation>false</TieredCompilation> </PropertyGroup> diff --git a/src/Servers/Kestrel/samples/Http2SampleApp/Http2SampleApp.csproj b/src/Servers/Kestrel/samples/Http2SampleApp/Http2SampleApp.csproj index f039c4208a3..cc404533ad8 100644 --- a/src/Servers/Kestrel/samples/Http2SampleApp/Http2SampleApp.csproj +++ b/src/Servers/Kestrel/samples/Http2SampleApp/Http2SampleApp.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>false</IsPackable> <NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile> <GenerateRazorAssemblyInfo>false</GenerateRazorAssemblyInfo> </PropertyGroup> diff --git a/src/Servers/Kestrel/samples/Http3SampleApp/Http3SampleApp.csproj b/src/Servers/Kestrel/samples/Http3SampleApp/Http3SampleApp.csproj index 04b7e7420cd..ac9287bc380 100644 --- a/src/Servers/Kestrel/samples/Http3SampleApp/Http3SampleApp.csproj +++ b/src/Servers/Kestrel/samples/Http3SampleApp/Http3SampleApp.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>false</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Servers/Kestrel/samples/LargeResponseApp/LargeResponseApp.csproj b/src/Servers/Kestrel/samples/LargeResponseApp/LargeResponseApp.csproj index d042d83830c..615f2698671 100644 --- a/src/Servers/Kestrel/samples/LargeResponseApp/LargeResponseApp.csproj +++ b/src/Servers/Kestrel/samples/LargeResponseApp/LargeResponseApp.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>false</IsPackable> <NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile> <GenerateRazorAssemblyInfo>false</GenerateRazorAssemblyInfo> </PropertyGroup> diff --git a/src/Servers/Kestrel/samples/PlaintextApp/PlaintextApp.csproj b/src/Servers/Kestrel/samples/PlaintextApp/PlaintextApp.csproj index 4256e8df7c6..030843d3be3 100644 --- a/src/Servers/Kestrel/samples/PlaintextApp/PlaintextApp.csproj +++ b/src/Servers/Kestrel/samples/PlaintextApp/PlaintextApp.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>false</IsPackable> <NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile> <GenerateRazorAssemblyInfo>false</GenerateRazorAssemblyInfo> </PropertyGroup> diff --git a/src/Servers/Kestrel/samples/QuicSampleApp/QuicSampleApp.csproj b/src/Servers/Kestrel/samples/QuicSampleApp/QuicSampleApp.csproj index 56ee0e01e14..ac3e766cae8 100644 --- a/src/Servers/Kestrel/samples/QuicSampleApp/QuicSampleApp.csproj +++ b/src/Servers/Kestrel/samples/QuicSampleApp/QuicSampleApp.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>false</IsPackable> <NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile> <GenerateRazorAssemblyInfo>false</GenerateRazorAssemblyInfo> </PropertyGroup> diff --git a/src/Servers/Kestrel/samples/QuicSampleClient/QuicSampleClient.csproj b/src/Servers/Kestrel/samples/QuicSampleClient/QuicSampleClient.csproj index 902824d8367..38725e4cbbd 100644 --- a/src/Servers/Kestrel/samples/QuicSampleClient/QuicSampleClient.csproj +++ b/src/Servers/Kestrel/samples/QuicSampleClient/QuicSampleClient.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <OutputType>Exe</OutputType> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>false</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Servers/Kestrel/samples/SampleApp/Kestrel.SampleApp.csproj b/src/Servers/Kestrel/samples/SampleApp/Kestrel.SampleApp.csproj index 8670c5935bb..663eb21f095 100644 --- a/src/Servers/Kestrel/samples/SampleApp/Kestrel.SampleApp.csproj +++ b/src/Servers/Kestrel/samples/SampleApp/Kestrel.SampleApp.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>false</IsPackable> <NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile> <GenerateRazorAssemblyInfo>false</GenerateRazorAssemblyInfo> </PropertyGroup> diff --git a/src/Servers/Kestrel/samples/SystemdTestApp/SystemdTestApp.csproj b/src/Servers/Kestrel/samples/SystemdTestApp/SystemdTestApp.csproj index 5e87dbdb383..644464fa030 100644 --- a/src/Servers/Kestrel/samples/SystemdTestApp/SystemdTestApp.csproj +++ b/src/Servers/Kestrel/samples/SystemdTestApp/SystemdTestApp.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>false</IsPackable> <NoDefaultLaunchSettingsFile>true</NoDefaultLaunchSettingsFile> <GenerateRazorAssemblyInfo>false</GenerateRazorAssemblyInfo> </PropertyGroup> diff --git a/src/Shared/test/testassets/ThrowingLibrary/ThrowingLibrary.csproj b/src/Shared/test/testassets/ThrowingLibrary/ThrowingLibrary.csproj index 2b2900911a8..d77d392873d 100644 --- a/src/Shared/test/testassets/ThrowingLibrary/ThrowingLibrary.csproj +++ b/src/Shared/test/testassets/ThrowingLibrary/ThrowingLibrary.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <TargetFramework>netstandard2.0</TargetFramework> <DebugType>portable</DebugType> - <IsPackable>false</IsPackable> </PropertyGroup> </Project> diff --git a/src/SignalR/clients/csharp/Client.Core/src/Microsoft.AspNetCore.SignalR.Client.Core.csproj b/src/SignalR/clients/csharp/Client.Core/src/Microsoft.AspNetCore.SignalR.Client.Core.csproj index c1aca1c2756..3f808a93952 100644 --- a/src/SignalR/clients/csharp/Client.Core/src/Microsoft.AspNetCore.SignalR.Client.Core.csproj +++ b/src/SignalR/clients/csharp/Client.Core/src/Microsoft.AspNetCore.SignalR.Client.Core.csproj @@ -4,7 +4,6 @@ <Description>Client for ASP.NET Core SignalR</Description> <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks> <RootNamespace>Microsoft.AspNetCore.SignalR.Client</RootNamespace> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/clients/csharp/Client/src/Microsoft.AspNetCore.SignalR.Client.csproj b/src/SignalR/clients/csharp/Client/src/Microsoft.AspNetCore.SignalR.Client.csproj index 56be28a14c7..7dd94f76740 100644 --- a/src/SignalR/clients/csharp/Client/src/Microsoft.AspNetCore.SignalR.Client.csproj +++ b/src/SignalR/clients/csharp/Client/src/Microsoft.AspNetCore.SignalR.Client.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <Description>Client for ASP.NET Core SignalR</Description> <TargetFramework>netstandard2.0</TargetFramework> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/clients/csharp/Client/test/FunctionalTests/Microsoft.AspNetCore.SignalR.Client.FunctionalTests.csproj b/src/SignalR/clients/csharp/Client/test/FunctionalTests/Microsoft.AspNetCore.SignalR.Client.FunctionalTests.csproj index 64df7e4cf6a..083a6a141af 100644 --- a/src/SignalR/clients/csharp/Client/test/FunctionalTests/Microsoft.AspNetCore.SignalR.Client.FunctionalTests.csproj +++ b/src/SignalR/clients/csharp/Client/test/FunctionalTests/Microsoft.AspNetCore.SignalR.Client.FunctionalTests.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/clients/csharp/Client/test/UnitTests/Microsoft.AspNetCore.SignalR.Client.Tests.csproj b/src/SignalR/clients/csharp/Client/test/UnitTests/Microsoft.AspNetCore.SignalR.Client.Tests.csproj index 7c0781eeee1..7c584a84bc8 100644 --- a/src/SignalR/clients/csharp/Client/test/UnitTests/Microsoft.AspNetCore.SignalR.Client.Tests.csproj +++ b/src/SignalR/clients/csharp/Client/test/UnitTests/Microsoft.AspNetCore.SignalR.Client.Tests.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/clients/csharp/Http.Connections.Client/src/Microsoft.AspNetCore.Http.Connections.Client.csproj b/src/SignalR/clients/csharp/Http.Connections.Client/src/Microsoft.AspNetCore.Http.Connections.Client.csproj index ee2e93c7073..c0fedd3797e 100644 --- a/src/SignalR/clients/csharp/Http.Connections.Client/src/Microsoft.AspNetCore.Http.Connections.Client.csproj +++ b/src/SignalR/clients/csharp/Http.Connections.Client/src/Microsoft.AspNetCore.Http.Connections.Client.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <Description>Client for ASP.NET Core Connection Handlers</Description> <TargetFrameworks>netstandard2.0;netstandard2.1</TargetFrameworks> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/clients/ts/FunctionalTests/SignalR.Client.FunctionalTestApp.csproj b/src/SignalR/clients/ts/FunctionalTests/SignalR.Client.FunctionalTestApp.csproj index db743ebecfd..6a5cb67738b 100644 --- a/src/SignalR/clients/ts/FunctionalTests/SignalR.Client.FunctionalTestApp.csproj +++ b/src/SignalR/clients/ts/FunctionalTests/SignalR.Client.FunctionalTestApp.csproj @@ -7,8 +7,6 @@ <!-- The naming of this file doesn't match repo conventions. This overrides the conventions. --> <IsTestAssetProject>true</IsTestAssetProject> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/clients/ts/signalr-protocol-msgpack/signalr-protocol-msgpack.npmproj b/src/SignalR/clients/ts/signalr-protocol-msgpack/signalr-protocol-msgpack.npmproj index 61d5c7477c8..30aa2443165 100644 --- a/src/SignalR/clients/ts/signalr-protocol-msgpack/signalr-protocol-msgpack.npmproj +++ b/src/SignalR/clients/ts/signalr-protocol-msgpack/signalr-protocol-msgpack.npmproj @@ -5,7 +5,6 @@ <PackageId>@microsoft/signalr-protocol-msgpack</PackageId> <IsPackable>true</IsPackable> <IsTestProject>false</IsTestProject> - <IsPackable>true</IsPackable> <PackOnBuild>true</PackOnBuild> </PropertyGroup> diff --git a/src/SignalR/clients/ts/signalr/signalr.npmproj b/src/SignalR/clients/ts/signalr/signalr.npmproj index 2aa54d01fe5..8fbb240c781 100644 --- a/src/SignalR/clients/ts/signalr/signalr.npmproj +++ b/src/SignalR/clients/ts/signalr/signalr.npmproj @@ -5,7 +5,6 @@ <PackageId>@microsoft/signalr</PackageId> <IsPackable>true</IsPackable> <IsTestProject>false</IsTestProject> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/common/Http.Connections/test/Microsoft.AspNetCore.Http.Connections.Tests.csproj b/src/SignalR/common/Http.Connections/test/Microsoft.AspNetCore.Http.Connections.Tests.csproj index 47191a34e23..3bff69e9021 100644 --- a/src/SignalR/common/Http.Connections/test/Microsoft.AspNetCore.Http.Connections.Tests.csproj +++ b/src/SignalR/common/Http.Connections/test/Microsoft.AspNetCore.Http.Connections.Tests.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/common/Protocols.MessagePack/src/Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj b/src/SignalR/common/Protocols.MessagePack/src/Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj index 43f4873c800..1781a2fb168 100644 --- a/src/SignalR/common/Protocols.MessagePack/src/Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj +++ b/src/SignalR/common/Protocols.MessagePack/src/Microsoft.AspNetCore.SignalR.Protocols.MessagePack.csproj @@ -5,7 +5,6 @@ <TargetFramework>netstandard2.0</TargetFramework> <RootNamespace>Microsoft.AspNetCore.SignalR</RootNamespace> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/common/Protocols.NewtonsoftJson/src/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson.csproj b/src/SignalR/common/Protocols.NewtonsoftJson/src/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson.csproj index 73eff24cd10..1338f232b5f 100644 --- a/src/SignalR/common/Protocols.NewtonsoftJson/src/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson.csproj +++ b/src/SignalR/common/Protocols.NewtonsoftJson/src/Microsoft.AspNetCore.SignalR.Protocols.NewtonsoftJson.csproj @@ -5,7 +5,6 @@ <TargetFramework>netstandard2.0</TargetFramework> <RootNamespace>Microsoft.AspNetCore.SignalR</RootNamespace> <AllowUnsafeBlocks>true</AllowUnsafeBlocks> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/common/SignalR.Common/test/Microsoft.AspNetCore.SignalR.Common.Tests.csproj b/src/SignalR/common/SignalR.Common/test/Microsoft.AspNetCore.SignalR.Common.Tests.csproj index f5d711aaaa9..1120424ee60 100644 --- a/src/SignalR/common/SignalR.Common/test/Microsoft.AspNetCore.SignalR.Common.Tests.csproj +++ b/src/SignalR/common/SignalR.Common/test/Microsoft.AspNetCore.SignalR.Common.Tests.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/common/testassets/Tests.Utils/Microsoft.AspNetCore.SignalR.Tests.Utils.csproj b/src/SignalR/common/testassets/Tests.Utils/Microsoft.AspNetCore.SignalR.Tests.Utils.csproj index 782c8410b8d..86cb17cb5f7 100644 --- a/src/SignalR/common/testassets/Tests.Utils/Microsoft.AspNetCore.SignalR.Tests.Utils.csproj +++ b/src/SignalR/common/testassets/Tests.Utils/Microsoft.AspNetCore.SignalR.Tests.Utils.csproj @@ -4,8 +4,6 @@ <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <RootNamespace>Microsoft.AspNetCore.SignalR.Tests</RootNamespace> <DefineConstants>$(DefineConstants);TESTUTILS</DefineConstants> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/perf/Microbenchmarks/Microsoft.AspNetCore.SignalR.Microbenchmarks.csproj b/src/SignalR/perf/Microbenchmarks/Microsoft.AspNetCore.SignalR.Microbenchmarks.csproj index 8bcc41b5725..ff022626496 100644 --- a/src/SignalR/perf/Microbenchmarks/Microsoft.AspNetCore.SignalR.Microbenchmarks.csproj +++ b/src/SignalR/perf/Microbenchmarks/Microsoft.AspNetCore.SignalR.Microbenchmarks.csproj @@ -3,8 +3,6 @@ <PropertyGroup> <OutputType>Exe</OutputType> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/samples/ClientSample/ClientSample.csproj b/src/SignalR/samples/ClientSample/ClientSample.csproj index e5f4fb420fa..82330ad3e98 100644 --- a/src/SignalR/samples/ClientSample/ClientSample.csproj +++ b/src/SignalR/samples/ClientSample/ClientSample.csproj @@ -3,8 +3,6 @@ <PropertyGroup> <TargetFrameworks>$(DefaultNetCoreTargetFramework);net461</TargetFrameworks> <OutputType>Exe</OutputType> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/samples/JwtClientSample/JwtClientSample.csproj b/src/SignalR/samples/JwtClientSample/JwtClientSample.csproj index 0e66b6c40fa..12aaa0f0392 100644 --- a/src/SignalR/samples/JwtClientSample/JwtClientSample.csproj +++ b/src/SignalR/samples/JwtClientSample/JwtClientSample.csproj @@ -3,8 +3,6 @@ <PropertyGroup> <TargetFrameworks>$(DefaultNetCoreTargetFramework)</TargetFrameworks> <OutputType>Exe</OutputType> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/samples/SignalRSamples/SignalRSamples.csproj b/src/SignalR/samples/SignalRSamples/SignalRSamples.csproj index c49287b478f..9ba813ca7a1 100644 --- a/src/SignalR/samples/SignalRSamples/SignalRSamples.csproj +++ b/src/SignalR/samples/SignalRSamples/SignalRSamples.csproj @@ -3,8 +3,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <GenerateRazorAssemblyInfo>false</GenerateRazorAssemblyInfo> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests.csproj b/src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests.csproj index 15574498b1e..24f414747f6 100644 --- a/src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests.csproj +++ b/src/SignalR/server/SignalR/test/Microsoft.AspNetCore.SignalR.Tests.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> @@ -28,4 +26,4 @@ <Reference Include="System.Reactive.Linq" /> </ItemGroup> -</Project> \ No newline at end of file +</Project> diff --git a/src/SignalR/server/Specification.Tests/src/Microsoft.AspNetCore.SignalR.Specification.Tests.csproj b/src/SignalR/server/Specification.Tests/src/Microsoft.AspNetCore.SignalR.Specification.Tests.csproj index 932181d4080..c1be25ec13c 100644 --- a/src/SignalR/server/Specification.Tests/src/Microsoft.AspNetCore.SignalR.Specification.Tests.csproj +++ b/src/SignalR/server/Specification.Tests/src/Microsoft.AspNetCore.SignalR.Specification.Tests.csproj @@ -4,9 +4,6 @@ <Description>Tests for users to verify their own implementations of SignalR types</Description> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> <IsPackable>true</IsPackable> - <HasReferenceAssembly>false</HasReferenceAssembly> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/server/StackExchangeRedis/src/Microsoft.AspNetCore.SignalR.StackExchangeRedis.csproj b/src/SignalR/server/StackExchangeRedis/src/Microsoft.AspNetCore.SignalR.StackExchangeRedis.csproj index 731b94720d8..562720dfb15 100644 --- a/src/SignalR/server/StackExchangeRedis/src/Microsoft.AspNetCore.SignalR.StackExchangeRedis.csproj +++ b/src/SignalR/server/StackExchangeRedis/src/Microsoft.AspNetCore.SignalR.StackExchangeRedis.csproj @@ -3,7 +3,6 @@ <PropertyGroup> <Description>Provides scale-out support for ASP.NET Core SignalR using a Redis server and the StackExchange.Redis client.</Description> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/SignalR/server/StackExchangeRedis/test/Microsoft.AspNetCore.SignalR.StackExchangeRedis.Tests.csproj b/src/SignalR/server/StackExchangeRedis/test/Microsoft.AspNetCore.SignalR.StackExchangeRedis.Tests.csproj index e9395224a65..c884296369d 100644 --- a/src/SignalR/server/StackExchangeRedis/test/Microsoft.AspNetCore.SignalR.StackExchangeRedis.Tests.csproj +++ b/src/SignalR/server/StackExchangeRedis/test/Microsoft.AspNetCore.SignalR.StackExchangeRedis.Tests.csproj @@ -2,8 +2,6 @@ <PropertyGroup> <TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework> - <!-- Avoid CS1705 errors due to mix of assemblies brought in transitively. --> - <CompileUsingReferenceAssemblies>false</CompileUsingReferenceAssemblies> </PropertyGroup> <ItemGroup> diff --git a/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj b/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj index 159ec052729..38353dc6a39 100644 --- a/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj +++ b/src/SiteExtensions/LoggingAggregate/src/Microsoft.AspNetCore.AzureAppServices.SiteExtension/Microsoft.AspNetCore.AzureAppServices.SiteExtension.csproj @@ -66,8 +66,8 @@ <ItemGroup> <!-- LB.csproj package content is bundled into this one. --> <!-- The x64 & x86 SiteExtension packages have identical deps.json files - we only include the x64 files to avoid build warnings --> - <ContentFilesToPack - Include="$(NugetPackageRoot)\%(PackageReference.Identity)\%(PackageReference.Version)\content\**\*.*" + <ContentFilesToPack + Include="$(NugetPackageRoot)\%(PackageReference.Identity)\%(PackageReference.Version)\content\**\*.*" Exclude="$(NugetPackageRoot)\Microsoft.AspNetCore.AzureAppServices.SiteExtension.*.x86\**\Microsoft.AspNetCore.AzureAppServices.HostingStartup.deps.json"/> <!-- Temporarily skip the common files --> diff --git a/src/SiteExtensions/Microsoft.Web.Xdt.Extensions/src/Microsoft.Web.Xdt.Extensions.csproj b/src/SiteExtensions/Microsoft.Web.Xdt.Extensions/src/Microsoft.Web.Xdt.Extensions.csproj index fe2e1357437..0844815979b 100644 --- a/src/SiteExtensions/Microsoft.Web.Xdt.Extensions/src/Microsoft.Web.Xdt.Extensions.csproj +++ b/src/SiteExtensions/Microsoft.Web.Xdt.Extensions/src/Microsoft.Web.Xdt.Extensions.csproj @@ -5,7 +5,6 @@ <TargetFramework>net461</TargetFramework> <CopySymbolsToArtifacts>true</CopySymbolsToArtifacts> <IsPackable>false</IsPackable> - <HasReferenceAssembly>false</HasReferenceAssembly> <IsShippingPackage>false</IsShippingPackage> </PropertyGroup> diff --git a/src/Tools/Extensions.ApiDescription.Client/src/Microsoft.Extensions.ApiDescription.Client.csproj b/src/Tools/Extensions.ApiDescription.Client/src/Microsoft.Extensions.ApiDescription.Client.csproj index 0c631a62117..5e8a85b1a52 100644 --- a/src/Tools/Extensions.ApiDescription.Client/src/Microsoft.Extensions.ApiDescription.Client.csproj +++ b/src/Tools/Extensions.ApiDescription.Client/src/Microsoft.Extensions.ApiDescription.Client.csproj @@ -8,10 +8,8 @@ <NuspecFile>$(MSBuildProjectName).nuspec</NuspecFile> <PackageId>$(MSBuildProjectName)</PackageId> <PackageTags>Build Tasks;MSBuild;Swagger;OpenAPI;code generation;Web API client;service reference</PackageTags> - <IsPackable>true</IsPackable> <TargetFrameworks>netstandard2.0</TargetFrameworks> <DevelopmentDependency>true</DevelopmentDependency> - <HasReferenceAssembly>false</HasReferenceAssembly> </PropertyGroup> <ItemGroup> diff --git a/src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.csproj b/src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.csproj index 40ddf13258e..bf8942884e8 100644 --- a/src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.csproj +++ b/src/Tools/Extensions.ApiDescription.Server/src/Microsoft.Extensions.ApiDescription.Server.csproj @@ -7,11 +7,9 @@ <Description>MSBuild tasks and targets for build-time Swagger and OpenApi document generation</Description> <DisableImplicitFrameworkReferences>true</DisableImplicitFrameworkReferences> - <HasReferenceAssembly>false</HasReferenceAssembly> <NuspecFile>$(MSBuildProjectName).nuspec</NuspecFile> <PackageId>$(MSBuildProjectName)</PackageId> <PackageTags>MSBuild;Swagger;OpenAPI;code generation;Web API;service reference;document generation</PackageTags> - <IsPackable>true</IsPackable> <DevelopmentDependency>true</DevelopmentDependency> <!-- diff --git a/src/Tools/FirstRunCertGenerator/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj b/src/Tools/FirstRunCertGenerator/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj index 99b550dda1a..25053effa60 100644 --- a/src/Tools/FirstRunCertGenerator/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj +++ b/src/Tools/FirstRunCertGenerator/src/Microsoft.AspNetCore.DeveloperCertificates.XPlat.csproj @@ -7,12 +7,11 @@ <PackageTags>aspnet;cli</PackageTags> <!-- This package contains API for the .NET CLI to generate the aspnet HTTPs dev cert during CLI first-run initialization. --> - + <!-- Our publishing logic depends on this particular package being NonShipping - if this ever becomes a Shipping project, we will incorrectly calculate the repo's version string, which will cause us to publish installers & checksums to the wrong place. If this ever becomes a Shipping project, we also need to update the following line to reference a different NonShipping project: https://github.com/dotnet/aspnetcore/blob/6301eefbc346b9ef00ede83ce223d8240b71942a/eng/Publishing.props#L39 --> <IsShippingPackage>false</IsShippingPackage> - <HasReferenceAssembly>false</HasReferenceAssembly> <ExcludeFromSourceBuild>false</ExcludeFromSourceBuild> </PropertyGroup> diff --git a/src/Tools/GetDocumentInsider/src/GetDocumentInsider.csproj b/src/Tools/GetDocumentInsider/src/GetDocumentInsider.csproj index ee962cbe7ee..cf667b1e851 100644 --- a/src/Tools/GetDocumentInsider/src/GetDocumentInsider.csproj +++ b/src/Tools/GetDocumentInsider/src/GetDocumentInsider.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <AssemblyName>GetDocument.Insider</AssemblyName> <Description>GetDocument Command-line Tool inside man</Description> - <HasReferenceAssembly>false</HasReferenceAssembly> <IsPackable>false</IsPackable> <OutputType>Exe</OutputType> <RootNamespace>Microsoft.Extensions.ApiDescription.Tool</RootNamespace> diff --git a/src/Tools/Microsoft.dotnet-openapi/src/Microsoft.dotnet-openapi.csproj b/src/Tools/Microsoft.dotnet-openapi/src/Microsoft.dotnet-openapi.csproj index 1eda67978a2..9f811292276 100644 --- a/src/Tools/Microsoft.dotnet-openapi/src/Microsoft.dotnet-openapi.csproj +++ b/src/Tools/Microsoft.dotnet-openapi/src/Microsoft.dotnet-openapi.csproj @@ -7,7 +7,6 @@ <AssemblyName>dotnet-openapi</AssemblyName> <PackageId>Microsoft.dotnet-openapi</PackageId> <PackAsTool>true</PackAsTool> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj b/src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj index 1ec6fe51ca2..7bcdcbcd7ac 100644 --- a/src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj +++ b/src/Tools/dotnet-getdocument/src/dotnet-getdocument.csproj @@ -2,7 +2,6 @@ <PropertyGroup> <AssemblyName>dotnet-getdocument</AssemblyName> <Description>GetDocument Command-line Tool outside man</Description> - <HasReferenceAssembly>false</HasReferenceAssembly> <IsPackable>false</IsPackable> <OutputType>Exe</OutputType> <RootNamespace>Microsoft.Extensions.ApiDescription.Tool</RootNamespace> diff --git a/src/Tools/dotnet-sql-cache/src/dotnet-sql-cache.csproj b/src/Tools/dotnet-sql-cache/src/dotnet-sql-cache.csproj index 3187186401e..bedcf8c0519 100644 --- a/src/Tools/dotnet-sql-cache/src/dotnet-sql-cache.csproj +++ b/src/Tools/dotnet-sql-cache/src/dotnet-sql-cache.csproj @@ -6,7 +6,6 @@ <Description>Command line tool to create tables and indexes in a Microsoft SQL Server database for distributed caching.</Description> <PackageTags>cache;distributedcache;sqlserver</PackageTags> <PackAsTool>true</PackAsTool> - <IsPackable>true</IsPackable> </PropertyGroup> <ItemGroup> diff --git a/src/WebEncoders/src/Microsoft.Extensions.WebEncoders.csproj b/src/WebEncoders/src/Microsoft.Extensions.WebEncoders.csproj index baed23277e0..920d4e2869d 100644 --- a/src/WebEncoders/src/Microsoft.Extensions.WebEncoders.csproj +++ b/src/WebEncoders/src/Microsoft.Extensions.WebEncoders.csproj @@ -7,7 +7,6 @@ <NoWarn>$(NoWarn);CS1591</NoWarn> <GenerateDocumentationFile>true</GenerateDocumentationFile> <PackageTags>aspnetcore</PackageTags> - <IsPackable>true</IsPackable> <IsAspNetCoreApp>true</IsAspNetCoreApp> <Nullable>enable</Nullable> </PropertyGroup> -- GitLab