diff --git a/Directory.Build.props b/Directory.Build.props
index d901404a132cfb2be10d475d5d5686ae8c3e824c..4b42f630ad43e6e6b850d3697e3a0766081d7169 100644
--- a/Directory.Build.props
+++ b/Directory.Build.props
@@ -36,7 +36,7 @@
<!-- Workaround issue with ComponentsAnalyzer throwing for interfaces -->
<DisableImplicitComponentsAnalyzers>true</DisableImplicitComponentsAnalyzers>
</PropertyGroup>
-
+
<!-- Disable logging of some task parameters or metadata to reduce binlog size.
Reenable logging of any particular item by changing the value of the property below to 'false'
The format is as follows:
@@ -48,22 +48,22 @@
<!-- ItemsToHash is used for incremental building and hashes input properties to a file
This is not generally useful for day-to-day build debugging. -->
<DisableLogTaskParameter_Hash_ItemsToHash>$(TrimTaskParameters)</DisableLogTaskParameter_Hash_ItemsToHash>
-
+
<!-- JoinItems takes input ItemGroups. The output ItemGroup is logged. -->
<DisableLogTaskParameter_JoinItems_Right>$(TrimTaskParameters)</DisableLogTaskParameter_JoinItems_Right>
<DisableLogTaskParameter_JoinItems_Left>$(TrimTaskParameters)</DisableLogTaskParameter_JoinItems_Left>
-
+
<!-- ConvertToAbsolutePaths - The output parameter (AbsolutePaths) is interesting
while the input Path is not generally useful. The output itemgroup's metadata
is not altered by the task. -->
<DisableLogTaskParameter_ConvertToAbsolutePath_Paths>$(TrimTaskParameters)</DisableLogTaskParameter_ConvertToAbsolutePath_Paths>
<DisableLogTaskParameterItemMetadata_ConvertToAbsolutePath_Paths>$(TrimTaskParameters)</DisableLogTaskParameterItemMetadata_ConvertToAbsolutePath_Paths>
-
+
<!-- The standard msbuild Copy task does not use Metadata and thus the input/outputs
item metadata is not relevant -->
<DisableLogTaskParameterItemMetadata_Copy_SourceFiles>$(TrimTaskParameters)</DisableLogTaskParameterItemMetadata_Copy_SourceFiles>
<DisableLogTaskParameterItemMetadata_Copy_DestinationFiles>$(TrimTaskParameters)</DisableLogTaskParameterItemMetadata_Copy_DestinationFiles>
-
+
<!-- Reference metadata for GenerateDepsFile, Csc, RAR, etc. are sometimes useful, but extraordinarily large
when building against a shared framework where the number of input assemblies is very large.
Avoid logging these by default. -->
@@ -101,14 +101,11 @@
<TreatWarningsAsErrors>true</TreatWarningsAsErrors>
<!-- Don't make missing XML docs a fatal build error, but still surface so we have visibility into undocumented APIs. -->
<WarningsNotAsErrors>$(WarningsNotAsErrors);CS1591</WarningsNotAsErrors>
+
<!-- xUnit1004 = warns about skipped tests. Make this a non-fatal build warning. -->
<WarningsNotAsErrors>$(WarningsNotAsErrors);xUnit1004</WarningsNotAsErrors>
- <!-- Working around https://github.com/NuGet/Home/issues/8467 -->
- <NoWarn>$(NoWarn);NU5131</NoWarn>
- <!-- Needed until we resolve https://github.com/dotnet/aspnetcore-internal/issues/3103 -->
- <NoWarn>$(NoWarn);NU5048</NoWarn>
- <!-- TODO: Figure out why these warnings are occuring -->
+ <!-- Ignore specific Roslyn warnings for now, https://github.com/dotnet/aspnetcore/issues/22090 -->
<NoWarn Condition="'$(IsAnalyzersProject)' == 'true'">$(NoWarn);RS1024;RS1025;RS1026</NoWarn>
</PropertyGroup>
diff --git a/build.ps1 b/build.ps1
index d31ab318cc6c8dc9aa73236a98fca6cb8fe5e296..96e5cb7bf07af83032b6b7ed7063a74a5b44e430 100644
--- a/build.ps1
+++ b/build.ps1
@@ -358,17 +358,12 @@ if (-not $foundJdk -and $RunBuild -and ($All -or $BuildJava) -and -not $NoBuildJ
# Initialize global variables need to be set before the import of Arcade is imported
$restore = $RunRestore
-# Though VS Code may indicate $nodeReuse, $warnAsError and $msbuildEngine are unused, tools.ps1 uses them.
+# Though VS Code may indicate $nodeReuse and $msbuildEngine are unused, tools.ps1 uses them.
# Disable node reuse - Workaround perpetual issues in node reuse and custom task assemblies
$nodeReuse = $false
$env:MSBUILDDISABLENODEREUSE=1
-# Our build often has warnings that we can't fix, like "MSB3026: Could not copy" due to race
-# conditions in building C++
-# Fixing this is tracked by https://github.com/dotnet/aspnetcore-internal/issues/601
-$warnAsError = $false
-
# Use `dotnet msbuild` by default
$msbuildEngine = 'dotnet'
diff --git a/build.sh b/build.sh
index 80dbb7f291dae9ce7c913a3cf7e376685e3cc0a0..3c3cab39ce11ed40de162548956374d6cbce931e 100755
--- a/build.sh
+++ b/build.sh
@@ -306,10 +306,6 @@ restore=$run_restore
nodeReuse=false
export MSBUILDDISABLENODEREUSE=1
-# Our build often has warnings that we can't fix
-# Fixing this is tracked by https://github.com/dotnet/aspnetcore-internal/issues/601
-warn_as_error=false
-
# Ensure passing neither --bl nor --nobl on CI avoids errors in tools.sh. This is needed because we set both variables
# to false by default i.e. they always exist. (We currently avoid binary logs but that is made visible in the YAML.)
if [[ "$ci" == true && "$exclude_ci_binary_log" == false ]]; then
diff --git a/eng/Workarounds.props b/eng/Workarounds.props
index eeb9004c6d23e2d46e67f43992b8e652e5dd3301..a56cf44b4661f32baf87dfb9a375ac1eb7b786fb 100644
--- a/eng/Workarounds.props
+++ b/eng/Workarounds.props
@@ -18,13 +18,6 @@
<TestRunnerAdditionalArguments>$(TestRunnerAdditionalArguments) -nocolor</TestRunnerAdditionalArguments>
</PropertyGroup>
- <PropertyGroup>
- <!-- Working around https://github.com/NuGet/Home/issues/8467 -->
- <NoWarn>$(NoWarn);NU5131</NoWarn>
- <!-- Workaround until https://github.com/dotnet/aspnetcore-internal/issues/3103 is resolved -->
- <NoWarn>$(NoWarn);NU5048</NoWarn>
- </PropertyGroup>
-
<!-- Workaround https://github.com/dotnet/roslyn/issues/27975 -->
<PropertyGroup>
<!-- We use the compiler toolset that comes from NuGet Packages rather than the SDK built-in.
diff --git a/src/Mvc/Mvc.Razor.RuntimeCompilation/src/Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.csproj b/src/Mvc/Mvc.Razor.RuntimeCompilation/src/Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.csproj
index 62a1e9eece792b3a40e5849cb39fee59f1abaa01..565757c4917a5f18a815adae31e8ff36ad076490 100644
--- a/src/Mvc/Mvc.Razor.RuntimeCompilation/src/Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.csproj
+++ b/src/Mvc/Mvc.Razor.RuntimeCompilation/src/Microsoft.AspNetCore.Mvc.Razor.RuntimeCompilation.csproj
@@ -4,9 +4,6 @@
<TargetFramework>$(DefaultNetCoreTargetFramework)</TargetFramework>
<NoWarn>$(NoWarn);CS1591</NoWarn>
- <!-- !!! Temporary workaround while we switch TFMs. -->
- <NoWarn>$(NoWarn);NU5129</NoWarn>
-
<GenerateDocumentationFile>true</GenerateDocumentationFile>
<PackageTags>aspnetcore;aspnetcoremvc;razor</PackageTags>
<IsPackable>true</IsPackable>
diff --git a/src/Razor/Microsoft.NET.Sdk.Razor/src/Microsoft.NET.Sdk.Razor.csproj b/src/Razor/Microsoft.NET.Sdk.Razor/src/Microsoft.NET.Sdk.Razor.csproj
index 3156331456f52b8d3548543128990baf576618dd..efe499aacadd4eb2f1163ad56d64463d44678125 100644
--- a/src/Razor/Microsoft.NET.Sdk.Razor/src/Microsoft.NET.Sdk.Razor.csproj
+++ b/src/Razor/Microsoft.NET.Sdk.Razor/src/Microsoft.NET.Sdk.Razor.csproj
@@ -13,8 +13,6 @@
<NoWarn>$(NoWarn);NU5100</NoWarn>
<!-- It is intentional to not include build/netstandard2.0/Microsoft.NET.Sdk.Razor.targets -->
<NoWarn>$(NoWarn);NU5129</NoWarn>
- <!-- Ignore file copy warnings -->
- <NoWarn>$(NoWarn);MSB3030;MSB4181</NoWarn>
<!-- Cannot run pubternal check on net46 -->
<DisablePubternalApiCheck>true</DisablePubternalApiCheck>
<!-- Need to build this project in source build -->
diff --git a/src/Razor/test/testassets/Directory.Build.props b/src/Razor/test/testassets/Directory.Build.props
index b1bd192bc136b0aa6e4e20a3369acabc0b408aaa..ece4b1e25605cc3084a9bd76ed5fbd4fc8487295 100644
--- a/src/Razor/test/testassets/Directory.Build.props
+++ b/src/Razor/test/testassets/Directory.Build.props
@@ -26,9 +26,6 @@
<!-- Working around an issue in XDT transforms -->
<AspNetCoreHostingModel>OutOfProcess</AspNetCoreHostingModel>
-
- <!-- Working around https://github.com/NuGet/Home/issues/8467 -->
- <NoWarn>$(NoWarn);NU5131</NoWarn>
</PropertyGroup>
<!-- Don't use the server when building in place. This locks up rzc.dll -->