diff --git a/.azure/pipelines/ci.yml b/.azure/pipelines/ci.yml index 432836c954bef317e9620a19ea25e6c14252b97b..a46fd2e783dac39028a42b44c492779e81f9217f 100644 --- a/.azure/pipelines/ci.yml +++ b/.azure/pipelines/ci.yml @@ -51,7 +51,12 @@ variables: # to have it in two different forms - name: _InternalRuntimeDownloadCodeSignArgs value: /p:DotNetRuntimeSourceFeed=https://dotnetclimsrc.blob.core.windows.net/dotnet /p:DotNetRuntimeSourceFeedKey=$(dotnetclimsrc-read-sas-token-base64) + - name: _UseHelixOpenQueues + value: 'true' - ${{ if eq(variables['System.TeamProject'], 'internal') }}: + - group: DotNet-HelixApi-Access + - name: _UseHelixOpenQueues + value: 'false' - ${{ if ne(variables['Build.Reason'], 'PullRequest') }}: # DotNet-Blob-Feed provides: dotnetfeed-storage-access-key-1 # Publish-Build-Assets provides: MaestroAccessToken, BotAccount-dotnet-maestro-bot-PAT @@ -640,6 +645,7 @@ stages: - script: .\build.cmd -ci -NoRestore -test -projects eng\helix\helix.proj /p:IsRequiredCheck=true /p:IsHelixJob=true /p:BuildAllProjects=true /p:BuildNative=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log -bl displayName: Run build.cmd helix target env: + HelixApiAccessToken: $(HelixApiAccessToken) # Needed for internal queues SYSTEM_ACCESSTOKEN: $(System.AccessToken) # We need to set this env var to publish helix results to Azure Dev Ops artifacts: - name: Helix_logs @@ -649,6 +655,7 @@ stages: - template: jobs/default-build.yml parameters: + condition: ne(variables['Build.Reason'], 'PullRequest') jobName: Helix_x64_daily jobDisplayName: 'Tests: Helix x64 Daily' agentOs: Windows @@ -659,6 +666,7 @@ stages: - script: .\build.cmd -ci -NoRestore -test -projects eng\helix\helix.proj /p:IsHelixJob=true /p:IsHelixDaily=true /p:BuildAllProjects=true /p:BuildNative=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log -bl displayName: Run build.cmd helix target env: + HelixApiAccessToken: $(HelixApiAccessToken) # Needed for internal queues SYSTEM_ACCESSTOKEN: $(System.AccessToken) # We need to set this env var to publish helix results to Azure Dev Ops artifacts: - name: Helix_logs @@ -680,6 +688,7 @@ stages: - script: ./build.sh -ci --arch arm64 -test --no-build-nodejs -projects $(Build.SourcesDirectory)/eng/helix/helix.proj /p:IsHelixJob=true /p:IsHelixDaily=true /p:BuildAllProjects=true /p:BuildNative=true /p:ASPNETCORE_TEST_LOG_DIR=artifacts/log -bl displayName: Run build.sh helix arm64 target env: + HelixApiAccessToken: $(HelixApiAccessToken) # Needed for internal queues SYSTEM_ACCESSTOKEN: $(System.AccessToken) # We need to set this env var to publish helix results to Azure Dev Ops installNodeJs: false artifacts: diff --git a/eng/Version.Details.xml b/eng/Version.Details.xml index f608c81fd75b8489b89401281b32f9849d211ba0..9034ddd9e13ad7bfe3d57495025cffa34bf22bcf 100644 --- a/eng/Version.Details.xml +++ b/eng/Version.Details.xml @@ -13,21 +13,21 @@ <Uri>https://github.com/dotnet/blazor</Uri> <Sha>dd7fb4d3931d556458f62642c2edfc59f6295bfb</Sha> </Dependency> - <Dependency Name="Microsoft.AspNetCore.Razor.Language" Version="5.0.0-preview.1.20114.1"> + <Dependency Name="Microsoft.AspNetCore.Razor.Language" Version="5.0.0-preview.1.20114.5"> <Uri>https://github.com/dotnet/aspnetcore-tooling</Uri> - <Sha>609026ea14eeb52a068d228d84987f24f3c64136</Sha> + <Sha>9acda9485be8e2238067508474dfa44fcc34f81e</Sha> </Dependency> - <Dependency Name="Microsoft.AspNetCore.Mvc.Razor.Extensions" Version="5.0.0-preview.1.20114.1"> + <Dependency Name="Microsoft.AspNetCore.Mvc.Razor.Extensions" Version="5.0.0-preview.1.20114.5"> <Uri>https://github.com/dotnet/aspnetcore-tooling</Uri> - <Sha>609026ea14eeb52a068d228d84987f24f3c64136</Sha> + <Sha>9acda9485be8e2238067508474dfa44fcc34f81e</Sha> </Dependency> - <Dependency Name="Microsoft.CodeAnalysis.Razor" Version="5.0.0-preview.1.20114.1"> + <Dependency Name="Microsoft.CodeAnalysis.Razor" Version="5.0.0-preview.1.20114.5"> <Uri>https://github.com/dotnet/aspnetcore-tooling</Uri> - <Sha>609026ea14eeb52a068d228d84987f24f3c64136</Sha> + <Sha>9acda9485be8e2238067508474dfa44fcc34f81e</Sha> </Dependency> - <Dependency Name="Microsoft.NET.Sdk.Razor" Version="5.0.0-preview.1.20114.1"> + <Dependency Name="Microsoft.NET.Sdk.Razor" Version="5.0.0-preview.1.20114.5"> <Uri>https://github.com/dotnet/aspnetcore-tooling</Uri> - <Sha>609026ea14eeb52a068d228d84987f24f3c64136</Sha> + <Sha>9acda9485be8e2238067508474dfa44fcc34f81e</Sha> </Dependency> <Dependency Name="dotnet-ef" Version="5.0.0-preview.1.20113.3"> <Uri>https://github.com/dotnet/efcore</Uri> @@ -289,10 +289,6 @@ <Uri>https://github.com/dotnet/extensions</Uri> <Sha>396aff55e0b4628a7a44375e4b72e5d19a6e37ab</Sha> </Dependency> - <Dependency Name="Microsoft.CSharp" Version="5.0.0-alpha.1.19563.6" CoherentParentDependency="Microsoft.NETCore.App.Runtime.win-x64"> - <Uri>https://github.com/dotnet/corefx</Uri> - <Sha>5cee7c97d602f294e27c582d4dab81ec388f1d7b</Sha> - </Dependency> <Dependency Name="Microsoft.Win32.Registry" Version="5.0.0-preview.1.20113.7" CoherentParentDependency="Microsoft.NETCore.App.Runtime.win-x64"> <Uri>https://github.com/dotnet/runtime</Uri> <Sha>0f3f8e1930c28b67f29990126bc2e8527e959a2e</Sha> diff --git a/eng/Versions.props b/eng/Versions.props index 60442119d9c72ba6ce1c31e54c7df5961fd736b5..138de3c19f371cc4b16498c6c697b73a84c9dcad 100644 --- a/eng/Versions.props +++ b/eng/Versions.props @@ -65,14 +65,12 @@ <MicrosoftDotNetGenAPIPackageVersion>5.0.0-beta.20113.3</MicrosoftDotNetGenAPIPackageVersion> <!-- Packages from dotnet/roslyn --> <MicrosoftNetCompilersToolsetPackageVersion>3.5.0-beta3-20114-02</MicrosoftNetCompilersToolsetPackageVersion> - <!-- Packages from dotnet/core-setup --> + <!-- Packages from dotnet/runtime --> <MicrosoftExtensionsDependencyModelPackageVersion>5.0.0-preview.1.20113.7</MicrosoftExtensionsDependencyModelPackageVersion> <MicrosoftNETCoreAppInternalPackageVersion>5.0.0-preview.1.20113.7</MicrosoftNETCoreAppInternalPackageVersion> <MicrosoftNETCoreAppRefPackageVersion>5.0.0-preview.1.20113.7</MicrosoftNETCoreAppRefPackageVersion> <MicrosoftNETCoreAppRuntimewinx64PackageVersion>5.0.0-preview.1.20113.7</MicrosoftNETCoreAppRuntimewinx64PackageVersion> <NETStandardLibraryRefPackageVersion>2.1.0-preview.1.20113.7</NETStandardLibraryRefPackageVersion> - <!-- Packages from dotnet/corefx --> - <MicrosoftCSharpPackageVersion>5.0.0-alpha.1.19563.6</MicrosoftCSharpPackageVersion> <MicrosoftWin32RegistryPackageVersion>5.0.0-preview.1.20113.7</MicrosoftWin32RegistryPackageVersion> <MicrosoftWin32SystemEventsPackageVersion>5.0.0-preview.1.20113.7</MicrosoftWin32SystemEventsPackageVersion> <SystemComponentModelAnnotationsPackageVersion>5.0.0-preview.1.20113.7</SystemComponentModelAnnotationsPackageVersion> @@ -167,10 +165,10 @@ <MicrosoftEntityFrameworkCoreToolsPackageVersion>5.0.0-preview.1.20113.3</MicrosoftEntityFrameworkCoreToolsPackageVersion> <MicrosoftEntityFrameworkCorePackageVersion>5.0.0-preview.1.20113.3</MicrosoftEntityFrameworkCorePackageVersion> <!-- Packages from dotnet/aspnetcore-tooling --> - <MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion>5.0.0-preview.1.20114.1</MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion> - <MicrosoftAspNetCoreRazorLanguagePackageVersion>5.0.0-preview.1.20114.1</MicrosoftAspNetCoreRazorLanguagePackageVersion> - <MicrosoftCodeAnalysisRazorPackageVersion>5.0.0-preview.1.20114.1</MicrosoftCodeAnalysisRazorPackageVersion> - <MicrosoftNETSdkRazorPackageVersion>5.0.0-preview.1.20114.1</MicrosoftNETSdkRazorPackageVersion> + <MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion>5.0.0-preview.1.20114.5</MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion> + <MicrosoftAspNetCoreRazorLanguagePackageVersion>5.0.0-preview.1.20114.5</MicrosoftAspNetCoreRazorLanguagePackageVersion> + <MicrosoftCodeAnalysisRazorPackageVersion>5.0.0-preview.1.20114.5</MicrosoftCodeAnalysisRazorPackageVersion> + <MicrosoftNETSdkRazorPackageVersion>5.0.0-preview.1.20114.5</MicrosoftNETSdkRazorPackageVersion> </PropertyGroup> <!-- @@ -194,6 +192,7 @@ <MicrosoftSymbolUploaderBuildTaskPackageVersion>1.0.0-beta-64023-03</MicrosoftSymbolUploaderBuildTaskPackageVersion> <MicrosoftVSSDKBuildToolsVersion>15.9.3032</MicrosoftVSSDKBuildToolsVersion> <!-- Stable dotnet/corefx packages no longer updated for .NET Core 3 --> + <MicrosoftCSharpPackageVersion>4.7.0</MicrosoftCSharpPackageVersion> <SystemBuffersPackageVersion>4.5.0</SystemBuffersPackageVersion> <SystemCodeDomPackageVersion>4.4.0</SystemCodeDomPackageVersion> <SystemCommandlineExperimentalPackageVersion>0.3.0-alpha.19317.1</SystemCommandlineExperimentalPackageVersion> diff --git a/eng/helix/helix.proj b/eng/helix/helix.proj index 1db18afa98f056eaf17e55cce20c4bff93f233c6..b90569314536be07d57bc78110d22daecbbb0491 100644 --- a/eng/helix/helix.proj +++ b/eng/helix/helix.proj @@ -12,7 +12,8 @@ <Import Project="..\Build.props" /> <ItemGroup> - <HelixTargetQueue Include="@(HelixAvailableTargetQueue)" /> + <HelixTargetQueue Condition="'$(_UseHelixOpenQueues)' == 'true'" Include="@(HelixAvailableTargetQueue)" /> + <HelixTargetQueue Condition="'$(_UseHelixOpenQueues)' != 'true'" Include="@(HelixAvailableTargetQueue->'%(Identity)'->Replace('.Open',''))" /> </ItemGroup> <PropertyGroup> @@ -21,11 +22,13 @@ <IsExternal>true</IsExternal> <SkipInvalidConfigurations>true</SkipInvalidConfigurations> <MaxRetryCount Condition="'$(MaxRetryCount)' == ''">2</MaxRetryCount> + <HelixAccessToken Condition="'$(_UseHelixOpenQueues)' != 'true'">$(HelixApiAccessToken)</HelixAccessToken> </PropertyGroup> <PropertyGroup Condition=" '$(ContinuousIntegrationBuild)' == 'true' "> <HelixType>ci</HelixType> - <Creator>aspnetcore</Creator> + <!-- Creator is not valid for internal queues --> + <Creator Condition="'$(_UseHelixOpenQueues)' == 'true'">aspnetcore</Creator> <HelixBuild>$(BUILD_BUILDNUMBER).$(TargetArchitecture).$(SYSTEM_JOBATTEMPT)</HelixBuild> <WaitForWorkItemCompletion>true</WaitForWorkItemCompletion> <EnableAzurePipelinesReporter>true</EnableAzurePipelinesReporter> @@ -34,8 +37,9 @@ <PropertyGroup Condition=" '$(ContinuousIntegrationBuild)' != 'true' "> <HelixType>dev</HelixType> - <Creator>$(USERNAME)</Creator> - <Creator Condition="'$(USERNAME)' == ''">$(USER)</Creator> + <!-- Creator is not valid for internal queues --> + <Creator Condition="'$(_UseHelixOpenQueues)' == 'true'">$(USERNAME)</Creator> + <Creator Condition="'$(USERNAME)' == '' AND '$(_UseHelixOpenQueues)' == 'true'">$(USER)</Creator> <HelixBuild>$([System.DateTime]::Now.ToString('yyyyMMddHHmm'))</HelixBuild> </PropertyGroup> diff --git a/eng/targets/Helix.targets b/eng/targets/Helix.targets index c6a20b6055ffa14a536ef579aace4516e6e709a3..f3d1ad0f16f2107686647bb49a6a973cd6a9b9d0 100644 --- a/eng/targets/Helix.targets +++ b/eng/targets/Helix.targets @@ -40,6 +40,12 @@ Usage: dotnet msbuild /t:Helix src/MyTestProject.csproj <_SelectedPlatforms>@(HelixProjectPlatform)</_SelectedPlatforms> </PropertyGroup> + <ItemGroup Condition="'$(_UseHelixOpenQueues)' != 'true'"> + <_Temp Include="@(HelixAvailableTargetQueue)" /> + <HelixAvailableTargetQueue Remove="@(HelixAvailableTargetQueue)" /> + <HelixAvailableTargetQueue Include="@(_Temp->'%(Identity)'->Replace('.Open',''))" /> + </ItemGroup> + <ItemGroup> <!-- Include default queues based on platform --> <_HelixProjectTargetQueue Include="%(HelixAvailableTargetQueue.Identity)" Condition="'%(HelixAvailableTargetQueue.Identity)' != '' AND '$(_SelectedPlatforms.Contains(%(Platform)))' == 'true'" /> diff --git a/src/Http/Http.Abstractions/src/HostString.cs b/src/Http/Http.Abstractions/src/HostString.cs index 0f7cbd73f6f0dcff891ecddf546c91019aa7b2b1..c15d59bf569ed6ba273717592308e7816028e245 100644 --- a/src/Http/Http.Abstractions/src/HostString.cs +++ b/src/Http/Http.Abstractions/src/HostString.cs @@ -96,7 +96,7 @@ namespace Microsoft.AspNetCore.Http GetParts(_value, out var host, out var port); if (!StringSegment.IsNullOrEmpty(port) - && int.TryParse(port.ToString(), NumberStyles.None, CultureInfo.InvariantCulture, out var p)) + && int.TryParse(port.AsSpan(), NumberStyles.None, CultureInfo.InvariantCulture, out var p)) { return p; } diff --git a/src/Servers/Connections.Abstractions/src/ConnectionHandler.cs b/src/Servers/Connections.Abstractions/src/ConnectionHandler.cs index e9e208d61a65fa478f7b6a1afa0cc6bc91d95a38..9bc8ab29024c00d5fe2f18dfe278a53cb5d426ce 100644 --- a/src/Servers/Connections.Abstractions/src/ConnectionHandler.cs +++ b/src/Servers/Connections.Abstractions/src/ConnectionHandler.cs @@ -6,15 +6,15 @@ using System.Threading.Tasks; namespace Microsoft.AspNetCore.Connections { /// <summary> - /// Represents an end point that multiple connections connect to. For HTTP, endpoints are URLs, for non HTTP it can be a TCP listener (or similar) + /// Represents an endpoint that multiple connections connect to. For HTTP, endpoints are URLs, for non-HTTP it can be a TCP listener (or similar). /// </summary> public abstract class ConnectionHandler { /// <summary> - /// Called when a new connection is accepted to the endpoint + /// Called when a new connection is accepted to the endpoint. /// </summary> /// <param name="connection">The new <see cref="ConnectionContext"/></param> /// <returns>A <see cref="Task"/> that represents the connection lifetime. When the task completes, the connection is complete.</returns> public abstract Task OnConnectedAsync(ConnectionContext connection); } -} \ No newline at end of file +} diff --git a/src/Servers/Kestrel/test/FunctionalTests/Http2/HandshakeTests.cs b/src/Servers/Kestrel/test/FunctionalTests/Http2/HandshakeTests.cs index 66a31011bb75c6703743c9b613c172ac9117888d..7ffd9b2bc0d103d86e974676c0f062639ce65277 100644 --- a/src/Servers/Kestrel/test/FunctionalTests/Http2/HandshakeTests.cs +++ b/src/Servers/Kestrel/test/FunctionalTests/Http2/HandshakeTests.cs @@ -80,7 +80,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2 [ConditionalFact] [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "Missing SslStream ALPN support: https://github.com/dotnet/corefx/issues/30492")] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10428", Queues = "Debian.8.Amd64.Open")] // Debian 8 uses OpenSSL 1.0.1 which does not support HTTP/2 + [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10428", Queues = "Debian.8.Amd64;Debian.8.Amd64.Open")] // Debian 8 uses OpenSSL 1.0.1 which does not support HTTP/2 [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win81)] public async Task TlsAlpnHandshakeSelectsHttp2From1and2() { @@ -111,7 +111,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2 [ConditionalFact] [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "Missing SslStream ALPN support: https://github.com/dotnet/corefx/issues/30492")] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10428", Queues = "Debian.8.Amd64.Open")] // Debian 8 uses OpenSSL 1.0.1 which does not support HTTP/2 + [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10428", Queues = "Debian.8.Amd64;Debian.8.Amd64.Open")] // Debian 8 uses OpenSSL 1.0.1 which does not support HTTP/2 [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win81)] public async Task TlsAlpnHandshakeSelectsHttp2() { diff --git a/src/Servers/Kestrel/test/FunctionalTests/Http2/ShutdownTests.cs b/src/Servers/Kestrel/test/FunctionalTests/Http2/ShutdownTests.cs index 8d930324491e84a78e4a4c36d7347dc7176dfc6c..7bed5ea335805181aea1c37448d58dae3e5ecf0e 100644 --- a/src/Servers/Kestrel/test/FunctionalTests/Http2/ShutdownTests.cs +++ b/src/Servers/Kestrel/test/FunctionalTests/Http2/ShutdownTests.cs @@ -23,7 +23,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2 { [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "Missing SslStream ALPN support: https://github.com/dotnet/corefx/issues/30492")] [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win10)] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10428", Queues = "Debian.8.Amd64.Open")] // Debian 8 uses OpenSSL 1.0.1 which does not support HTTP/2 + [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10428", Queues = "Debian.8.Amd64;Debian.8.Amd64.Open")] // Debian 8 uses OpenSSL 1.0.1 which does not support HTTP/2 public class ShutdownTests : TestApplicationErrorLoggerLoggedTest { private static X509Certificate2 _x509Certificate2 = TestResources.GetTestCertificate(); @@ -44,7 +44,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.FunctionalTests.Http2 [CollectDump] [ConditionalFact] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/9985", Queues = "Fedora.28.Amd64.Open")] + [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/9985", Queues = "Fedora.28.Amd64;Fedora.28.Amd64.Open")] [Flaky("https://github.com/dotnet/aspnetcore/issues/9985", FlakyOn.All)] public async Task GracefulShutdownWaitsForRequestsToFinish() { diff --git a/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionMiddlewareTests.cs b/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionMiddlewareTests.cs index b7af0267e5e98d4bf70f0e2abde034ff75e446bd..80780257e4bb55ae7308c1bb91315b5f5c4fc444 100644 --- a/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionMiddlewareTests.cs +++ b/src/Servers/Kestrel/test/InMemory.FunctionalTests/HttpsConnectionMiddlewareTests.cs @@ -595,7 +595,7 @@ namespace Microsoft.AspNetCore.Server.Kestrel.InMemory.FunctionalTests [InlineData(HttpProtocols.Http2)] [InlineData(HttpProtocols.Http1AndHttp2)] [OSSkipCondition(OperatingSystems.MacOSX, SkipReason = "Missing SslStream ALPN support: https://github.com/dotnet/corefx/issues/30492")] - [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10428", Queues = "Debian.8.Amd64.Open")] // Debian 8 uses OpenSSL 1.0.1 which does not support HTTP/2 + [SkipOnHelix("https://github.com/dotnet/aspnetcore/issues/10428", Queues = "Debian.8.Amd64;Debian.8.Amd64.Open")] // Debian 8 uses OpenSSL 1.0.1 which does not support HTTP/2 [MinimumOSVersion(OperatingSystems.Windows, WindowsVersions.Win81)] public async Task ListenOptionsProtolsCanBeSetAfterUseHttps(HttpProtocols httpProtocols) { diff --git a/src/Servers/Kestrel/test/Interop.FunctionalTests/Utilities.cs b/src/Servers/Kestrel/test/Interop.FunctionalTests/Utilities.cs index 1e6fb930f8ddb61f19ede379adb5050dc64f017e..db41d1e1b40fabfefd49d72f64af4c352e77cc33 100644 --- a/src/Servers/Kestrel/test/Interop.FunctionalTests/Utilities.cs +++ b/src/Servers/Kestrel/test/Interop.FunctionalTests/Utilities.cs @@ -14,7 +14,7 @@ namespace Interop.FunctionalTests // "Missing SslStream ALPN support: https://github.com/dotnet/corefx/issues/30492" && new OSSkipConditionAttribute(OperatingSystems.MacOSX).IsMet // Debian 8 uses OpenSSL 1.0.1 which does not support ALPN - && new SkipOnHelixAttribute("https://github.com/dotnet/aspnetcore/issues/10428") { Queues = "Debian.8.Amd64.Open" }.IsMet; + && new SkipOnHelixAttribute("https://github.com/dotnet/aspnetcore/issues/10428") { Queues = "Debian.8.Amd64;Debian.8.Amd64.Open" }.IsMet; } } } diff --git a/src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs b/src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs index 8af04058c08244cd64cf0d5ff84d122f97272220..c277df763d4628ac030ee803f6ed6ab91067709c 100644 --- a/src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs +++ b/src/Tools/Microsoft.dotnet-openapi/test/OpenApiAddFileTests.cs @@ -28,7 +28,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public void OpenApi_NoProjectExists() { var app = GetApplication(); @@ -40,7 +39,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public void OpenApi_ExplicitProject_Missing() { var app = GetApplication(); @@ -75,7 +73,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public async Task OpenApi_Add_ReuseItemGroup() { var project = CreateBasicProject(withOpenApi: true); @@ -105,7 +102,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public void OpenApi_Add_File_EquivilentPaths() { var project = CreateBasicProject(withOpenApi: true); @@ -131,7 +127,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public async Task OpenApi_Add_NSwagTypeScript() { var project = CreateBasicProject(withOpenApi: true); @@ -152,7 +147,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public async Task OpenApi_Add_FromJson() { var project = CreateBasicProject(withOpenApi: true); @@ -173,7 +167,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public async Task OpenApi_Add_File_UseProjectOption() { var project = CreateBasicProject(withOpenApi: true); @@ -194,7 +187,6 @@ namespace Microsoft.DotNet.OpenApi.Add.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public async Task OpenApi_Add_MultipleTimes_OnlyOneReference() { var project = CreateBasicProject(withOpenApi: true); diff --git a/src/Tools/Microsoft.dotnet-openapi/test/OpenApiRemoveTests.cs b/src/Tools/Microsoft.dotnet-openapi/test/OpenApiRemoveTests.cs index b48b7f688c9556c5f9ff60895eda87f1a0542f0c..a8db61e99a9f3844ee6b2b9bc2dd460bf4a84128 100644 --- a/src/Tools/Microsoft.dotnet-openapi/test/OpenApiRemoveTests.cs +++ b/src/Tools/Microsoft.dotnet-openapi/test/OpenApiRemoveTests.cs @@ -16,7 +16,6 @@ namespace Microsoft.DotNet.OpenApi.Remove.Tests public OpenApiRemoveTests(ITestOutputHelper output) : base(output) { } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public async Task OpenApi_Remove_File() { var nswagJsonFile = "openapi.json"; @@ -62,7 +61,6 @@ namespace Microsoft.DotNet.OpenApi.Remove.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public async Task OpenApi_Remove_ViaUrl() { _tempDir @@ -151,7 +149,6 @@ namespace Microsoft.DotNet.OpenApi.Remove.Tests } [Fact] - [Flaky("<No longer needed; tracked in Kusto>", FlakyOn.All)] public async Task OpenApi_Remove_Multiple() { var nswagJsonFile = "openapi.json";