diff --git a/build/dependencies.props b/build/dependencies.props index 57db423e186ddad34eccf3fa292154bb0fc152d9..b5f376321702e3907266e1865da73cef9e33c160 100644 --- a/build/dependencies.props +++ b/build/dependencies.props @@ -87,14 +87,6 @@ <MicrosoftVisualStudioWebCodeGenerationTemplatingPackageVersion>2.1.7</MicrosoftVisualStudioWebCodeGenerationTemplatingPackageVersion> <MicrosoftVisualStudioWebCodeGenerationUtilsPackageVersion>2.1.7</MicrosoftVisualStudioWebCodeGenerationUtilsPackageVersion> <MicrosoftVisualStudioWebCodeGeneratorsMvcPackageVersion>2.1.7</MicrosoftVisualStudioWebCodeGeneratorsMvcPackageVersion> - - <!-- These dependencies are required to build. The need to be used as explicit package references --> - <MicrosoftAspNetCoreRazorDesignPackageVersion>2.1.1</MicrosoftAspNetCoreRazorDesignPackageVersion> - <MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion>2.1.1</MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion> - <MicrosoftAspNetCoreRazorRuntimePackageVersion>2.1.1</MicrosoftAspNetCoreRazorRuntimePackageVersion> - <MicrosoftAspNetCoreRazorLanguagePackageVersion>2.1.1</MicrosoftAspNetCoreRazorLanguagePackageVersion> - <MicrosoftCodeAnalysisRazorPackageVersion>2.1.1</MicrosoftCodeAnalysisRazorPackageVersion> - <!-- These dependencies are temporary while we refactor package refs into project refs. --> <MicrosoftAspNetCoreAspNetCoreModulePackageVersion>2.1.1</MicrosoftAspNetCoreAspNetCoreModulePackageVersion> <MicrosoftAspNetCoreAspNetCoreModuleV1PackageVersion>2.1.1</MicrosoftAspNetCoreAspNetCoreModuleV1PackageVersion> diff --git a/eng/scripts/CodeCheck.ps1 b/eng/scripts/CodeCheck.ps1 index f8018995633046699702248eea7089ad53f76a6b..9ad0c6d642d5f55ca0e005f59e286e29a2089216 100644 --- a/eng/scripts/CodeCheck.ps1 +++ b/eng/scripts/CodeCheck.ps1 @@ -32,7 +32,7 @@ try { $slnDir = Split-Path -Parent $_ $sln = $_ & dotnet sln $_ list ` - | ? { $_ -ne 'Project(s)' -and $_ -ne '----------' } ` + | ? { $_ -like '*proj' } ` | % { $proj = Join-Path $slnDir $_ if (-not (Test-Path $proj)) { diff --git a/src/Mvc/Mvc.Razor/src/Microsoft.AspNetCore.Mvc.Razor.csproj b/src/Mvc/Mvc.Razor/src/Microsoft.AspNetCore.Mvc.Razor.csproj index 438e9ef5ef506bd085743c07e6905779a791de90..fb70c4474c4a7a113cb032c2d57bf13c676aabd1 100644 --- a/src/Mvc/Mvc.Razor/src/Microsoft.AspNetCore.Mvc.Razor.csproj +++ b/src/Mvc/Mvc.Razor/src/Microsoft.AspNetCore.Mvc.Razor.csproj @@ -18,10 +18,9 @@ <ItemGroup> <Reference Include="Microsoft.AspNetCore.Mvc.ViewFeatures" /> - - <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions" Version="$(MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion)" /> - <PackageReference Include="Microsoft.AspNetCore.Razor.Runtime" Version="$(MicrosoftAspNetCoreRazorRuntimePackageVersion)" /> - <PackageReference Include="Microsoft.CodeAnalysis.Razor" Version="$(MicrosoftCodeAnalysisRazorPackageVersion)" /> + <Reference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions" /> + <Reference Include="Microsoft.AspNetCore.Razor.Runtime" /> + <Reference Include="Microsoft.CodeAnalysis.Razor" /> <Reference Include="Microsoft.CodeAnalysis.CSharp" /> <Reference Include="Microsoft.Extensions.Caching.Memory" /> <Reference Include="Microsoft.Extensions.FileProviders.Composite" /> @@ -30,24 +29,11 @@ <Target Name="PopulateNuspec" BeforeTargets="GenerateNuspec" DependsOnTargets="BuiltProjectOutputGroup;DebugSymbolsProjectOutputGroup;DocumentationProjectOutputGroup"> - <!-- We can uncomment the below block once https://github.com/aspnet/AspNetCore/issues/6070 is fixed. --> - <!-- - - <PropertyGroup> - <SrcPath>$([MSBuild]::GetDirectoryNameOfFileAbove($(MSBuildThisFileDirectory)..\, Directory.Build.props))\src\</SrcPath> - </PropertyGroup> - <MSBuild Projects="$(SrcPath)Razor\Mvc.Razor.Extensions\src\Microsoft.AspNetCore.Mvc.Razor.Extensions.csproj; - $(SrcPath)Razor\Razor.Runtime\src\Microsoft.AspNetCore.Razor.Runtime.csproj; - $(SrcPath)Razor\CodeAnalysis.Razor\src\Microsoft.CodeAnalysis.Razor.csproj;" - Targets="_GetPackageVersionInfo" Properties="DesignTimeBuild=true;NoBuild=true"> - <Output TaskParameter="TargetOutputs" ItemName="_DependencyPackageInfo" /> - </MSBuild> <PropertyGroup> <MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion>@(_DependencyPackageInfo->WithMetadataValue('PackageId', 'Microsoft.AspNetCore.Mvc.Razor.Extensions')->Metadata('PackageVersion'))</MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion> <MicrosoftAspNetCoreRazorRuntimePackageVersion>@(_DependencyPackageInfo->WithMetadataValue('PackageId', 'Microsoft.AspNetCore.Razor.Runtime')->Metadata('PackageVersion'))</MicrosoftAspNetCoreRazorRuntimePackageVersion> <MicrosoftCodeAnalysisRazorPackageVersion>@(_DependencyPackageInfo->WithMetadataValue('PackageId', 'Microsoft.CodeAnalysis.Razor')->Metadata('PackageVersion'))</MicrosoftCodeAnalysisRazorPackageVersion> </PropertyGroup> - --> <PropertyGroup> <!-- Make sure we create a symbols.nupkg --> diff --git a/src/Mvc/Mvc.TagHelpers/src/Microsoft.AspNetCore.Mvc.TagHelpers.csproj b/src/Mvc/Mvc.TagHelpers/src/Microsoft.AspNetCore.Mvc.TagHelpers.csproj index 1cd35a40b10c275bdea5ffed23dbd60113f164be..2af2516ca1c9d8e03fd9568b13c62fd6faadca61 100644 --- a/src/Mvc/Mvc.TagHelpers/src/Microsoft.AspNetCore.Mvc.TagHelpers.csproj +++ b/src/Mvc/Mvc.TagHelpers/src/Microsoft.AspNetCore.Mvc.TagHelpers.csproj @@ -16,7 +16,7 @@ <ItemGroup> <Reference Include="Microsoft.AspNetCore.Mvc.Razor" /> - <PackageReference Include="Microsoft.AspNetCore.Razor.Runtime" Version="$(MicrosoftAspNetCoreRazorRuntimePackageVersion)" /> + <Reference Include="Microsoft.AspNetCore.Razor.Runtime" /> <Reference Include="Microsoft.AspNetCore.Routing.Abstractions" /> <Reference Include="Microsoft.Extensions.Caching.Memory" /> <Reference Include="Microsoft.Extensions.FileSystemGlobbing" /> diff --git a/src/Mvc/Mvc/src/Microsoft.AspNetCore.Mvc.csproj b/src/Mvc/Mvc/src/Microsoft.AspNetCore.Mvc.csproj index 11964b7926dee3bd013ed89bcaac2b4588ac8355..66495371e0f95dc2289d70d5080c9029bc7f468a 100644 --- a/src/Mvc/Mvc/src/Microsoft.AspNetCore.Mvc.csproj +++ b/src/Mvc/Mvc/src/Microsoft.AspNetCore.Mvc.csproj @@ -20,12 +20,8 @@ <Reference Include="Microsoft.AspNetCore.Mvc.ViewFeatures" /> <!-- Including these here specifically so that apps referencing the MVC package get razor compiler targets --> - <PackageReference Include="Microsoft.AspNetCore.Razor.Design" Version="$(MicrosoftAspNetCoreRazorDesignPackageVersion)"> - <PrivateAssets>None</PrivateAssets> - </PackageReference> - <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions" Version="$(MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion)"> - <PrivateAssets>None</PrivateAssets> - </PackageReference> + <Reference Include="Microsoft.AspNetCore.Razor.Design" PrivateAssets="None" /> + <Reference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions" PrivateAssets="None" /> <Reference Include="Microsoft.Extensions.Caching.Memory" /> <Reference Include="Microsoft.Extensions.DependencyInjection" /> diff --git a/src/Mvc/samples/MvcSandbox/MvcSandbox.csproj b/src/Mvc/samples/MvcSandbox/MvcSandbox.csproj index 27a8ad2cff4202290c724a0edfd250a145a46695..ec148de762f58ce47ce6b75eb18dabffedf03f0c 100644 --- a/src/Mvc/samples/MvcSandbox/MvcSandbox.csproj +++ b/src/Mvc/samples/MvcSandbox/MvcSandbox.csproj @@ -12,8 +12,6 @@ <Reference Include="Microsoft.AspNetCore.Mvc" /> <Reference Include="Microsoft.AspNetCore.Diagnostics" /> - <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions" Version="$(MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion)" /> - <PackageReference Include="Microsoft.AspNetCore.Razor.Design" Version="$(MicrosoftAspNetCoreRazorDesignPackageVersion)" /> <Reference Include="Microsoft.AspNetCore.Server.IISIntegration" /> <Reference Include="Microsoft.AspNetCore.Server.Kestrel" /> <Reference Include="Microsoft.AspNetCore.StaticFiles" /> diff --git a/src/Mvc/shared/Mvc.TestCommon/Microsoft.AspNetCore.Mvc.TestCommon.csproj b/src/Mvc/shared/Mvc.TestCommon/Microsoft.AspNetCore.Mvc.TestCommon.csproj index d1d33183f1ab4b3aea3cd54df78be68c6c104826..cd612b0c93a3c8984aeb4c4ef5ffeb8cf9be751b 100644 --- a/src/Mvc/shared/Mvc.TestCommon/Microsoft.AspNetCore.Mvc.TestCommon.csproj +++ b/src/Mvc/shared/Mvc.TestCommon/Microsoft.AspNetCore.Mvc.TestCommon.csproj @@ -13,8 +13,8 @@ <ItemGroup> <Reference Include="Microsoft.AspNetCore.Html.Abstractions" /> - <PackageReference Include="Microsoft.AspNetCore.Razor.Runtime" Version="$(MicrosoftAspNetCoreRazorRuntimePackageVersion)" /> - <PackageReference Include="Microsoft.AspNetCore.Razor.Language" Version="$(MicrosoftAspNetCoreRazorLanguagePackageVersion)" /> + <Reference Include="Microsoft.AspNetCore.Razor.Runtime" /> + <Reference Include="Microsoft.AspNetCore.Razor.Language" /> <Reference Include="Microsoft.AspNetCore.Testing" /> <Reference Include="Microsoft.Extensions.DependencyInjection" /> <Reference Include="Microsoft.Extensions.FileProviders.Abstractions" /> diff --git a/src/Mvc/test/Mvc.FunctionalTests/Microsoft.AspNetCore.Mvc.FunctionalTests.csproj b/src/Mvc/test/Mvc.FunctionalTests/Microsoft.AspNetCore.Mvc.FunctionalTests.csproj index 00e7e4be5a3cbc8950d76cea60d7b5e935f508d8..eada79a64fd5d6b9d89d9ace3640b19be8673cc1 100644 --- a/src/Mvc/test/Mvc.FunctionalTests/Microsoft.AspNetCore.Mvc.FunctionalTests.csproj +++ b/src/Mvc/test/Mvc.FunctionalTests/Microsoft.AspNetCore.Mvc.FunctionalTests.csproj @@ -31,6 +31,9 @@ <ItemGroup> <Reference Include="Microsoft.AspNetCore.Mvc.Testing" /> + <Reference Include="Microsoft.AspNetCore.Razor.Runtime" /> + <Reference Include="Microsoft.AspNetCore.Razor.Language" /> + <ProjectReference Include="..\WebSites\ApiExplorerWebSite\ApiExplorerWebSite.csproj" /> <ProjectReference Include="..\WebSites\ApplicationModelWebSite\ApplicationModelWebSite.csproj" /> <ProjectReference Include="..\WebSites\BasicWebSite\BasicWebSite.csproj" /> diff --git a/src/Mvc/test/WebSites/ControllersFromServicesClassLibrary/ControllersFromServicesClassLibrary.csproj b/src/Mvc/test/WebSites/ControllersFromServicesClassLibrary/ControllersFromServicesClassLibrary.csproj index 7b342c518871057767b53aa8275e343a2f03b0c9..a5f7b2c2545a206a0964ea6e6287e9618bc85679 100644 --- a/src/Mvc/test/WebSites/ControllersFromServicesClassLibrary/ControllersFromServicesClassLibrary.csproj +++ b/src/Mvc/test/WebSites/ControllersFromServicesClassLibrary/ControllersFromServicesClassLibrary.csproj @@ -8,5 +8,7 @@ <ItemGroup> <Reference Include="Microsoft.AspNetCore.Mvc" /> + <Reference Include="Microsoft.AspNetCore.Razor.Runtime" /> + <Reference Include="Microsoft.AspNetCore.Razor.Language" /> </ItemGroup> </Project> diff --git a/src/Mvc/test/WebSites/ControllersFromServicesWebSite/ControllersFromServicesWebSite.csproj b/src/Mvc/test/WebSites/ControllersFromServicesWebSite/ControllersFromServicesWebSite.csproj index 97813ee2795bc7ca07df2d9748a63ecf2c0ddd81..76bd2977ca95a8af1b002722d8ba925c767d8bb8 100644 --- a/src/Mvc/test/WebSites/ControllersFromServicesWebSite/ControllersFromServicesWebSite.csproj +++ b/src/Mvc/test/WebSites/ControllersFromServicesWebSite/ControllersFromServicesWebSite.csproj @@ -9,6 +9,8 @@ <ProjectReference Include="..\ControllersFromServicesClassLibrary\ControllersFromServicesClassLibrary.csproj" /> <Reference Include="Microsoft.AspNetCore.Mvc" /> + <Reference Include="Microsoft.AspNetCore.Razor.Runtime" /> + <Reference Include="Microsoft.AspNetCore.Razor.Language" /> <Reference Include="Microsoft.AspNetCore.Server.IISIntegration" /> <Reference Include="Microsoft.AspNetCore.Server.Kestrel" /> <Reference Include="Microsoft.AspNetCore.Diagnostics" /> diff --git a/src/Mvc/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj b/src/Mvc/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj index 2cea31cc817179d4af9bb32f11277cd572a5d430..eb459ef73c2f7151085f0f9de17d17bd38953cd6 100644 --- a/src/Mvc/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj +++ b/src/Mvc/test/WebSites/RazorBuildWebSite/RazorBuildWebSite.csproj @@ -19,13 +19,6 @@ <Reference Include="Microsoft.AspNetCore.Server.Kestrel" /> <Reference Include="Microsoft.AspNetCore.StaticFiles" /> <Reference Include="Microsoft.AspNetCore.Diagnostics" /> - - <!-- - Referencing here so you can easily regenerate the C# from Razor. - Just do `dotnet build /t:RazorGenerate /p:TargetFramework=netcoreapp2.0` and look in obj/Debug/netcoreapp2.0/Razor - --> - <PackageReference Include="Microsoft.AspNetCore.Razor.Design" Version="$(MicrosoftAspNetCoreRazorDesignPackageVersion)" /> - <PackageReference Include="Microsoft.AspNetCore.Mvc.Razor.Extensions" Version="$(MicrosoftAspNetCoreMvcRazorExtensionsPackageVersion)" /> </ItemGroup> </Project> diff --git a/src/Mvc/test/WebSites/RazorWebSite/RazorWebSite.csproj b/src/Mvc/test/WebSites/RazorWebSite/RazorWebSite.csproj index be6ee3b5fe2c2aee167de052c3ac96ef8a5545e1..9b08bd081b22580d74150af8af43a169d46011db 100644 --- a/src/Mvc/test/WebSites/RazorWebSite/RazorWebSite.csproj +++ b/src/Mvc/test/WebSites/RazorWebSite/RazorWebSite.csproj @@ -13,6 +13,8 @@ <ItemGroup> <Reference Include="Microsoft.AspNetCore.Mvc" /> + <Reference Include="Microsoft.AspNetCore.Razor.Runtime" /> + <Reference Include="Microsoft.AspNetCore.Razor.Language" /> <Reference Include="Microsoft.AspNetCore.Server.IISIntegration" /> <Reference Include="Microsoft.AspNetCore.Server.Kestrel" /> <Reference Include="Microsoft.AspNetCore.StaticFiles" />